From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#6843: grep-mode and filenames with colons Date: Thu, 27 Jul 2017 15:10:40 +0300 Message-ID: References: <87h8xy93lg.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1501157891 27666 195.159.176.226 (27 Jul 2017 12:18:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Jul 2017 12:18:11 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Thunderbird/55.0 To: npostavs@users.sourceforge.net, bug#6843 <6843@debbugs.gnu.org>, Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 27 14:18:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dahjx-0006ra-DP for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jul 2017 14:18:05 +0200 Original-Received: from localhost ([::1]:42785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dahk3-0004M5-8D for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jul 2017 08:18:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dahjx-0004Lv-Tf for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2017 08:18:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dahju-0003zQ-Pe for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2017 08:18:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55304) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dahju-0003zM-LF for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2017 08:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dahju-00040l-FP for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2017 08:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jul 2017 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 6843-submit@debbugs.gnu.org id=B6843.150115782915360 (code B ref 6843); Thu, 27 Jul 2017 12:18:02 +0000 Original-Received: (at 6843) by debbugs.gnu.org; 27 Jul 2017 12:17:09 +0000 Original-Received: from localhost ([127.0.0.1]:57981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dahj3-0003zg-8Y for submit@debbugs.gnu.org; Thu, 27 Jul 2017 08:17:09 -0400 Original-Received: from mail-wm0-f67.google.com ([74.125.82.67]:35743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dahj1-0003z8-B3 for 6843@debbugs.gnu.org; Thu, 27 Jul 2017 08:17:07 -0400 Original-Received: by mail-wm0-f67.google.com with SMTP id r77so10382887wmd.2 for <6843@debbugs.gnu.org>; Thu, 27 Jul 2017 05:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/ZwBf9FEDfctQX1I56XXQ9mYZ2Oxb8GIU8GHyHP6ikQ=; b=OMK5awWaGpYtGrHCkX817TpNEX8wp6IFhY/x97APQnLRzy8+pa0UpsMNiKjb7bJ8Gs 6lQseEWISkzmtddkzGth4tWrHdHLXbmlVPKZe1DNztUhMdGa3V1qKj+RoUsvod/IgF6b rmbNZeEymXpqC9BkbYP0LpRsGHxjCA+CLj2TSsWf4Nt74YlIyayRcP4TdYOlVQjInDe8 1xv3IfD+ezaxgKtSfAmWRWQO8T5GRPg83khSrZ6fKW8n6EEN8CvVriEgjBcZjbjoDOJf +Jj5v8GxxGFcn2v/naSfkvX++G9m0j4fiRsqz+tai6XxLicJDPul5pMNa9z4b244haFX d2Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/ZwBf9FEDfctQX1I56XXQ9mYZ2Oxb8GIU8GHyHP6ikQ=; b=qj07Kmd/TCk3nhSR4PYa/qMTNaHvf48FK5wbOAbMvucFGtyVYmHzeFWr4DH+chEqsV voRAf5+Tpz1HpgvrlGZ0JRMQECgTS3U3QyJiwqzwrbFIWHBxnu1hNsqc6rAS3qNEh/nL b9SuILOye+LVUWiYq7J/VvaynKYDo59t3j1YdeNXUFO4v+tST7PeWWdeBJPEPfCN1RtA /7nheMo6gFKms5EBscBtLGEfZ2enaG1GtkNMgn2tr88YpBBnOtU25TX5CHBpZleRqL76 o/NvJZwsl5seGleiz34yvFE9VSFCh2T/0Fo/ZLkhM7bS2E2uX2iPPCksq1kHNxCnLDbd M8SQ== X-Gm-Message-State: AIVw112wPRebfJSs2tJQWC5ymxUaOnFhapm09BoBSXrdCRZnstayzpSZ g6Ud8sqAtRnnH+XrWXw= X-Received: by 10.28.211.193 with SMTP id k184mr375078wmg.21.1501157444421; Thu, 27 Jul 2017 05:10:44 -0700 (PDT) Original-Received: from [192.168.0.133] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id p45sm19115772wrb.75.2017.07.27.05.10.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jul 2017 05:10:43 -0700 (PDT) In-Reply-To: <87h8xy93lg.fsf@users.sourceforge.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135045 Archived-At: On 7/27/17 2:32 AM, npostavs@users.sourceforge.net wrote: > As noted in the emacs-devel thread, non-GNU greps don't support it. And we can't always ask the user to install GNU Grep? If we do need to support both ways, maybe tweak the variable names. As of now, they look a bit inconsistent. I'd prefer to have either grep-with-null-regexp-alist and grep-[without-null-]-regexp-alist, or grep-regexp-alist and grep-fallback-regexp-alist. Just a suggestion. >> Any reason to change 2 to 3? Why don't we use a non-capturing group for \0 >> here? > > It's on the next line, I capture the \0 so as to display it with a nicer > string than "^@". Oh, right. Thanks. >>> + (2 '(face unspecified display ":"))) > >> If the numbers are the same, we could keep the variable's name the same as >> well. As a result, most third-party code would continue to simply work. > > Might be worth using explicitly numbered groups to keep the numbers for > FILE and COLUMN the same though. Yes, I think it will be a good idea. Provided we can combine it with renaming either of the variables back to grep-regexp-alist. Otherwise, any backward compatibility is broken anyway. >> Compensating for the multitude of variables by eliminating newlines between >> them doesn't look too hot to me. > > Hmm yeah, I think I had them originally as let-bindings, and then I > forgot to space them out when converting to defconst. Thanks in advance.