From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Update js-mode function heading regexes Date: Mon, 19 Jun 2017 02:59:01 +0300 Message-ID: References: <7ad22b11-406f-1193-c948-faaf01268710@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1497830394 26686 195.159.176.226 (18 Jun 2017 23:59:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 18 Jun 2017 23:59:54 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 To: Adam Niederer , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 19 01:59:50 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dMk6g-0006Rh-AO for ged-emacs-devel@m.gmane.org; Mon, 19 Jun 2017 01:59:50 +0200 Original-Received: from localhost ([::1]:39959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMk6f-0000Zj-Au for ged-emacs-devel@m.gmane.org; Sun, 18 Jun 2017 19:59:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMk60-0000ZP-99 for emacs-devel@gnu.org; Sun, 18 Jun 2017 19:59:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMk5x-00087X-99 for emacs-devel@gnu.org; Sun, 18 Jun 2017 19:59:08 -0400 Original-Received: from mail-wm0-x235.google.com ([2a00:1450:400c:c09::235]:35276) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMk5x-000874-2B for emacs-devel@gnu.org; Sun, 18 Jun 2017 19:59:05 -0400 Original-Received: by mail-wm0-x235.google.com with SMTP id x70so65120031wme.0 for ; Sun, 18 Jun 2017 16:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zUp2CW5/N5WexCjtXxN9APn0O2kFTcoSitRpVtbmWBg=; b=aHAXet5VuHzd/LtinQg6j9dSBtA/Yc1znJqR4ZNeNuaZFNcu+7h3DbyD7t/wNnMCdz vBoeQCLD9G10AlXm0qBuyrrJV+fm8hO4ZRx0GEjasrzxrgUbJvGVo2M63O0taEawDXyG Xv3asLnTHX9UVdD6L9cDHqshKZVKW0VJMoL1Whn6vBH7yPNQ1+fYtl0OI3m2seHDN2U8 EAZxWDsW6OXSoVCyD7otVKJnv5uyMOm2tsaEdCzkxbfVAbwJUsloROm/MN9PBCgPmtxv KDP3X+saX6Oqe3hDyNTnavbNDzFD+NvGXOxrKWL0nevb0Ppxx1DC44bQrDS79qoEHZzY 9kIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zUp2CW5/N5WexCjtXxN9APn0O2kFTcoSitRpVtbmWBg=; b=GzP+NNdcMlMjTEgnmxc1Y5SQtdK/FXRUGVFYlyF6o0noFXSlX6/gh8n/l5t7j7n09Y /T3uXF9LfZEVz1KQmAtnvz0AOozkILm1zyQAt950tBn1EbS6h6dwzFXFwzBt+O+uKugv hpg+dV5rlVytOk4sHyebxi5rU8APvhwyELJ1lvJWooyixyoDRsCGc7vrubZFXJr/grro 3dp5i26FHXWeW+JfmxdIfz7jxyXvMukF2FuxrIvbMoWT5fPXEuME79nTuhdeDh+PQEQY aHj9ehQoqJJObY/HmPSmSFBxtTBvNqPi3FUcXSlUQvDaleskQV+Ty9CrCzsd96xNcNcr iUKA== X-Gm-Message-State: AKS2vOzti04AeUF6mhBTF1iYjG+3b8dBmoKC0jT6uWStX1VtNRwWXuDp j2VH/vOd7o5PE/YQj4I= X-Received: by 10.28.132.210 with SMTP id g201mr13576782wmd.26.1497830343496; Sun, 18 Jun 2017 16:59:03 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id q24sm5330722wra.16.2017.06.18.16.59.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Jun 2017 16:59:02 -0700 (PDT) In-Reply-To: <7ad22b11-406f-1193-c948-faaf01268710@gmail.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:215759 Archived-At: Hi! On 6/17/17 10:30 AM, Adam Niederer wrote: > Below is the file I used to test these changes. make check is failing > for me, but it looks like the failing tests are unrelated (filenotify & > inotify). These are manual tests, right? 'make check' doesn't sound relevant. But we have some automated tests for js.el too. Check out test/lisp/progmodes/js-tests.el. Maybe these scenarios would be better coded with ERT. > This is my first contribution via a mailing list, so please let me know > if I'm missing anything :). Not much. Patch submissions via the bug tracker have higher odds of not being forgotten is they're not applied right away, though. Thanks for the patch.