all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Adam Niederer <adam.niederer@gmail.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] Update js-mode function heading regexes
Date: Mon, 19 Jun 2017 02:59:01 +0300	[thread overview]
Message-ID: <b377e066-067b-a681-e858-2b32c1a561a3@yandex.ru> (raw)
In-Reply-To: <7ad22b11-406f-1193-c948-faaf01268710@gmail.com>

Hi!

On 6/17/17 10:30 AM, Adam Niederer wrote:
> Below is the file I used to test these changes. make check is failing
> for me, but it looks like the failing tests are unrelated (filenotify &
> inotify).

These are manual tests, right? 'make check' doesn't sound relevant.

But we have some automated tests for js.el too. Check out 
test/lisp/progmodes/js-tests.el. Maybe these scenarios would be better 
coded with ERT.

> This is my first contribution via a mailing list, so please let me know
> if I'm missing anything :).

Not much. Patch submissions via the bug tracker have higher odds of not 
being forgotten is they're not applied right away, though.

Thanks for the patch.



  reply	other threads:[~2017-06-18 23:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-17  7:30 [PATCH] Update js-mode function heading regexes Adam Niederer
2017-06-18 23:59 ` Dmitry Gutov [this message]
2017-06-19  7:04   ` Adam Niederer
2017-09-28 21:02     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b377e066-067b-a681-e858-2b32c1a561a3@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=adam.niederer@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.