From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Turning on savehist-mode by default Date: Tue, 28 Nov 2023 23:46:35 +0200 Message-ID: References: <83a5qy7xjx.fsf@gnu.org> <7a6d16c5-90ff-4c5b-be0f-cd19c272eada@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1912"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: emacs-devel@gnu.org, public@thanosapollo.org To: Adam Porter , eliz@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 28 22:47:41 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r85vf-0000CF-V4 for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Nov 2023 22:47:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r85up-0005gv-1y; Tue, 28 Nov 2023 16:46:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r85uk-0005fz-Oj for emacs-devel@gnu.org; Tue, 28 Nov 2023 16:46:42 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r85ui-0003ed-Pd; Tue, 28 Nov 2023 16:46:42 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9E4FD5C0240; Tue, 28 Nov 2023 16:46:39 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 28 Nov 2023 16:46:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1701207999; x=1701294399; bh=dkZ6M8av1993LxdpJzFzWz2HAE0ymZfm+fJ 8nM/zJc4=; b=TNwV/P7qz9EIB7jP33Tnpv1W4Nm+HbgjOy4cyQLnP3QOJU8Kfef scALOJKdXSLtDGFUYFq7y54lV2Jq1XVePwavP6pyROFl6EXfXc+acl81hqoQSWgv RUL05X0+A6lGUK+BLF8HIFg/ViLINw0ipHLucsbw1vSWGXE0gHSd1VZdN8QdNkqU Ol3xMeHiflQlA/Rlsyf8jtXATEL3Wk68qvCw3L3GLSG37187vVrTP4qv2BgPGGno wtTpCxEHsiKt966TkiWkxW5SbkOJ0OVvHH0klWFED2pa/mgu7cz+14rnAx4oZDgb /32ej3W5a7gOZbIkOvpGzKiqzwaj2ghiPcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1701207999; x=1701294399; bh=dkZ6M8av1993LxdpJzFzWz2HAE0ymZfm+fJ 8nM/zJc4=; b=cnjUaZKCgr/VVJbnFZVgLeKt2bNnTxQjW67+kkWSBvJ+TyS+b4r q5DZpxSLDzOjelF3LFAkmVLsxADk8l114JtcY3/LQmvP7Uaoc1SvxamEBD0sOH/P nNSOkELeubQdPlidp+2piGRtIJP8frifdKaiIaTb2VGUSnTUx/VLfyY/HVZvgXwU YoIn2oay3mq0HP3KtKVYrV8o/mxTjSZEF/kVJqU0qJOXNbcRmCHRBIzeSkc3S58e Gag6YSEBTxkWDWU6EBQEOf9wy44Ckh1TzWLtLNFcTFrzARo4oC/2THLymKruk9Ud 7BfW25z2ySeXbq0cdQ6WGxcbMFNikQlHCBg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeifedgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeeuffevieffuefggfevjedvgeetuefhudfgheelleefjedtleettefhtdei gedvudenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Nov 2023 16:46:37 -0500 (EST) Content-Language: en-US In-Reply-To: <7a6d16c5-90ff-4c5b-be0f-cd19c272eada@alphapapa.net> Received-SPF: pass client-ip=66.111.4.26; envelope-from=dmitry@gutov.dev; helo=out2-smtp.messagingengine.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.37, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313338 Archived-At: On 28/11/2023 23:07, Adam Porter wrote: > FWIW, IME, it may not be a good idea to enable savehist-mode by default. >  As an example, see this issue report on Ement.el's repository: > > https://github.com/alphapapa/ement.el/issues/216 > > The gist is that, for users who enabled savehist, it was saving the > variable command-history, which included some complex commands whose > arguments (from interactive completion) included large data structures > (which are hidden from the user when called interactively).  This > resulted in savehist files hundreds of MB in size and very noticeable > pauses whenever savehist saved its data, from timers and upon Emacs exit. savehist-mode is very popular, so even if it's not on by default, such issues might be encountered by a lot of people anyway. Could we try to fix it for those users? Either by filtering out "expensive" entries before saving (with some heuristic), or by entirely blacklisting command-history by default -- through savehist-ignored-variables.