From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#72018: 30.0.60; [PATCH] Don't emit a prompt when a background Eshell process is killed Date: Wed, 10 Jul 2024 12:55:25 -0700 Message-ID: References: <86frsho5u2.fsf@gnu.org> <6a233903-b1df-3d8b-1c25-e6b4b40b4cd5@gmail.com> <86y169m9q6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------Yn7ySHAv59FLcIoGWnaxG4KZ" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31002"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72018@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 10 22:25:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRdsb-0007q7-NR for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jul 2024 22:25:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRdsP-0000QE-2m; Wed, 10 Jul 2024 16:25:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sRds9-0000Mh-3h for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2024 16:25:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sRds8-0003RU-Qm for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2024 16:25:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sRds6-0000kj-IL for bug-gnu-emacs@gnu.org; Wed, 10 Jul 2024 16:25:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jul 2024 20:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72018-submit@debbugs.gnu.org id=B72018.17206430422794 (code B ref 72018); Wed, 10 Jul 2024 20:25:02 +0000 Original-Received: (at 72018) by debbugs.gnu.org; 10 Jul 2024 20:24:02 +0000 Original-Received: from localhost ([127.0.0.1]:50388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRdr6-0000iq-4V for submit@debbugs.gnu.org; Wed, 10 Jul 2024 16:24:00 -0400 Original-Received: from mail-qt1-f176.google.com ([209.85.160.176]:51209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sRdqz-0000iZ-RJ for 72018@debbugs.gnu.org; Wed, 10 Jul 2024 16:23:55 -0400 Original-Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-447ed27aea2so866391cf.2 for <72018@debbugs.gnu.org>; Wed, 10 Jul 2024 13:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720642969; x=1721247769; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=xFCvvdTv6nVrGf8zku9o+oHEXWVPLjU/TkVd4OZ7uoY=; b=Pksh46JLqx1tuoae5XZG6pz2BMn/MV3ZQExhW9ULii8j0Rc4GHVXCi9HIkrDfdgwGm q4lV+AOU0OU5WK5nK276BMDfMgh8ignlRlDCOIwfXrV4nOIYfOgi6ZSCTCKCW1c9mkgk mHqZFbH9GUmLC6UgKaoq5or8ZiQLzttPTNa0kDe8je0Vt1/PJxQAR69MoZD9mRgpcbkm T5c6WK/OZsVz8adraO1bBdk/T/l6HyuRDPORtoCzYTmXVRYzSP/e4VlqrzgFcWRzvpZV /+9U9ydAP/fD69Kt5kSF9lOdD+dtWu5IBauD9t9cTZVe1fXKR82kqBXzBzA1hobMLCDS RHhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720642969; x=1721247769; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xFCvvdTv6nVrGf8zku9o+oHEXWVPLjU/TkVd4OZ7uoY=; b=lvR9jczgvZAPnXf/1aHn8nvVj1iAN1jNwodesFaX4E99Cqkw/ot4GzqqoJ+YyPcaul /dpe9yjA4vKFFe4YrEnvTzMCVoGB4lcdY6oKpAK7VGNXo385u8lrepX5/L3g1vKsGpQ2 Fg9uotrY/kdEOZk5boGPYOPD4Oi9iclBuB2qyMPz1iKxolypheN/neAYhATfWrwRDNrm hsTD8M1lle0Rnb1Ep0MH6Lvh5rCkwQCVl5GCiqH7HxxxZW1TgkXASGGwGD/mgK6eck7y uzCc/HHMegoWzG2osjAM1WvHuy03NNVKd3wiEqZbVwblrhYbXSHuf0Jc79Z1ujkKPiBD 38JQ== X-Gm-Message-State: AOJu0Yx/x1LaMtLyNp8L78kpzKO1Eniu2CWQhjJGu3Lh3yLLsIFfkvNi BJYjnefM6ZBVnXAC5jIXyR3c5/aHgg3rJGOsoFVtFSth0k94cCuZCUqR6Q== X-Google-Smtp-Source: AGHT+IG9unb67x88NSAJUgCb9v++z8xSZ4toV2ZTwZ8fIl74HjiCIpkdogIa4PMn0d42UcsEJ7m+Lw== X-Received: by 2002:a05:6a00:2195:b0:70b:301d:ea68 with SMTP id d2e1a72fcca58-70b43670809mr7210806b3a.31.1720641326912; Wed, 10 Jul 2024 12:55:26 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-70b438cb305sm4201579b3a.49.2024.07.10.12.55.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 12:55:26 -0700 (PDT) Content-Language: en-US In-Reply-To: <86y169m9q6.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288700 Archived-At: This is a multi-part message in MIME format. --------------Yn7ySHAv59FLcIoGWnaxG4KZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/10/2024 10:34 AM, Eli Zaretskii wrote: >> Date: Wed, 10 Jul 2024 09:16:11 -0700 >> Cc: 72018@debbugs.gnu.org >> From: Jim Porter >> >> We want to reset the prompt (this just emits a new command prompt) for >> foreground commands, but for background commands, we don't need to do >> anything. Would it be clearer if I inverted the wording in the comment, >> like, "Don't reset the prompt if the command we just aborted was in the >> background"? > > I think these subtleties just warrant more detailed comments, and then > we'll be fine. How about this? --------------Yn7ySHAv59FLcIoGWnaxG4KZ Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.patch" Content-Disposition: attachment; filename*0="0001-Don-t-emit-a-prompt-in-Eshell-when-a-background-comm.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA4NGZiOTk3YTk0NTAzZTc2YTY1YTViOTYzMDFkOWZmMmJhYWMxZmMzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgOSBKdWwgMjAyNCAxMDo0NTozNSAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIERvbid0IGVtaXQgYSBwcm9tcHQgaW4gRXNoZWxsIHdoZW4gYSBiYWNrZ3JvdW5kIGNv bW1hbmQgaXMKIGtpbGxlZAoKKiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsIChlc2hlbGwtcmVz dW1lLWNvbW1hbmQpOiBDaGVjayBmb3IKYmFja2dyb3VuZC1uZXNzIGJlZm9yZSByZXNldHRp bmcgdGhlIHByb21wdC4KCiogdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsCihl c2gtY21kLXRlc3QvYmFja2dyb3VuZC9zaW1wbGUtY29tbWFuZCk6IE1ha2UgdGhlIHJlZ2V4 cCBhIGJpdApzdHJpY3Rlci4KKGVzaC1jbWQtdGVzdC9iYWNrZ3JvdW5kL2tpbGwpOiBOZXcg dGVzdC4KLS0tCiBsaXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICAgfCAxMSArKysr KysrKystLQogdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3RzLmVsIHwgMTQgKysrKysr KysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtY21kLmVsIGIvbGlzcC9lc2hl bGwvZXNoLWNtZC5lbAppbmRleCAwYjMxMzcxMjdkMi4uZTk3ZTRmNmQwNjcgMTAwNjQ0Ci0t LSBhL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5l bApAQCAtMTAzMCw2ICsxMDMwLDkgQEAgZXNoZWxsLXJlc3VtZS1jb21tYW5kCiBQUk9DIGlz IHRoZSBwcm9jZXNzIHRoYXQgaW52b2tlZCB0aGlzIGZyb20gaXRzIHNlbnRpbmVsLCBhbmQK IFNUQVRVUyBpcyBpdHMgc3RhdHVzLiIKICAgKHdoZW4gcHJvYworICAgIDs7IEl0ZXJhdGUg b3ZlciBhbGwgdGhlIGNvbW1hbmRzIGFzc29jaWF0ZWQgd2l0aCB0aGlzIHByb2Nlc3MuICBF YWNoCisgICAgOzsgZWxlbWVudCBpcyBhIGxpc3Qgb2YgdGhlIGZvcm0gKEJBQ0tHUk9VTkQg Rk9STSBQUk9DRVNTRVMpIChzZWUKKyAgICA7OyBgZXNoZWxsLWFkZC1jb21tYW5kJykuCiAg ICAgKGRvbGlzdCAoY29tbWFuZCAoZXNoZWxsLWNvbW1hbmRzLWZvci1wcm9jZXNzIHByb2Mp KQogICAgICAgKHVubGVzcyAoc2VxLXNvbWUgIydlc2hlbGwtcHJvY2Vzcy1hY3RpdmUtcCAo bnRoIDIgY29tbWFuZCkpCiAgICAgICAgIChzZXRmIChudGggMiBjb21tYW5kKSBuaWwpIDsg Q2xlYXIgcHJvY2Vzc2VzIGZyb20gY29tbWFuZC4KQEAgLTEwNDAsOCArMTA0MywxMiBAQCBl c2hlbGwtcmVzdW1lLWNvbW1hbmQKICAgICAgICAgICAgICAgICAgKG5vdCAoc3RyaW5nLW1h dGNoIGVzaGVsbC1yZXNldC1zaWduYWxzIHN0YXR1cykpKQogICAgICAgICAgICAgKGVzaGVs bC1yZXN1bWUtZXZhbCBjb21tYW5kKQogICAgICAgICAgIChlc2hlbGwtcmVtb3ZlLWNvbW1h bmQgY29tbWFuZCkKLSAgICAgICAgICAoZGVjbGFyZS1mdW5jdGlvbiBlc2hlbGwtcmVzZXQg ImVzaC1tb2RlIiAoJm9wdGlvbmFsIG5vLWhvb2tzKSkKLSAgICAgICAgICAoZXNoZWxsLXJl c2V0KSkpKSkpCisgICAgICAgICAgOzsgQ2hlY2sgaWYgdGhlIGNvbW1hbmQgd2UganVzdCBh Ym9ydGVkIGlzIG1hcmtlZCBhcyBhCisgICAgICAgICAgOzsgYmFja2dyb3VuZCBjb21tYW5k LiAgSWYgbm90LCB3ZSBuZWVkIHRvIHJlc2V0IHRoZSBwcm9tcHQgc28KKyAgICAgICAgICA7 OyB0aGUgdXNlciBjYW4gZW50ZXIgYW5vdGhlciBjb21tYW5kLgorICAgICAgICAgICh1bmxl c3MgKGNhciBjb21tYW5kKQorICAgICAgICAgICAgKGRlY2xhcmUtZnVuY3Rpb24gZXNoZWxs LXJlc2V0ICJlc2gtbW9kZSIgKCZvcHRpb25hbCBuby1ob29rcykpCisgICAgICAgICAgICAo ZXNoZWxsLXJlc2V0KSkpKSkpKQogCiAoZGVmdW4gZXNoZWxsLXJlc3VtZS1ldmFsIChjb21t YW5kKQogICAiRGVzdHJ1Y3RpdmVseSBldmFsdWF0ZSBhIENPTU1BTkQgd2hpY2ggbWF5IG5l ZWQgdG8gYmUgZGVmZXJyZWQuCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZXNoZWxsL2VzaC1j bWQtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC1jbWQtdGVzdHMuZWwKaW5kZXgg NzBlMTkwMWMxNjkuLmQ4MTI0YTE5YWY2IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxs L2VzaC1jbWQtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2VzaGVsbC9lc2gtY21kLXRlc3Rz LmVsCkBAIC0xMTMsNyArMTEzLDcgQEAgZXNoLWNtZC10ZXN0L2JhY2tncm91bmQvc2ltcGxl LWNvbW1hbmQKICAgICAod2l0aC10ZW1wLWVzaGVsbAogICAgICAoZXNoZWxsLW1hdGNoLWNv bW1hbmQtb3V0cHV0CiAgICAgICAoZm9ybWF0ICIqZWNobyBoaSA+ICM8JXM+ICYiIGJ1Zm5h bWUpCi0gICAgICAocnggIltlY2hvIiAoPyAiLmV4ZSIpICJdICIgKCsgZGlnaXQpICJcbiIp KQorICAgICAgKHJ4IGJvcyAiW2VjaG8iICg/ICIuZXhlIikgIl0gIiAoKyBkaWdpdCkgIlxu IikpCiAgICAgIChlc2hlbGwtd2FpdC1mb3Itc3VicHJvY2VzcyB0KSkKICAgICAoc2hvdWxk IChlcXVhbCAoYnVmZmVyLXN0cmluZykgImhpXG4iKSkpKQogCkBAIC0xMjksNiArMTI5LDE4 IEBAIGVzaC1jbWQtdGVzdC9iYWNrZ3JvdW5kL3N1YmNvbW1hbmQKICAgICAgKGVzaGVsbC13 YWl0LWZvci1zdWJwcm9jZXNzIHQpKQogICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3Ry aW5nKSAib2xsZWhcbiIpKSkpCiAKKyhlcnQtZGVmdGVzdCBlc2gtY21kLXRlc3QvYmFja2dy b3VuZC9raWxsICgpCisgICJNYWtlIHN1cmUgdGhhdCBhIGJhY2tncm91bmQgY29tbWFuZCB0 aGF0IGdldHMga2lsbGVkIGRvZXNuJ3QgZW1pdCBhIHByb21wdC4iCisgIChza2lwLXVubGVz cyAoZXhlY3V0YWJsZS1maW5kICJzbGVlcCIpKQorICAobGV0ICgoYmFja2dyb3VuZC1tZXNz YWdlIChyeCBib3MgIltzbGVlcCIgKD8gIi5leGUiKSAiXSAiICgrIGRpZ2l0KSAiXG4iKSkp CisgICAgKHdpdGgtdGVtcC1lc2hlbGwKKyAgICAgIChlc2hlbGwtbWF0Y2gtY29tbWFuZC1v dXRwdXQgIipzbGVlcCAxMCAmIiBiYWNrZ3JvdW5kLW1lc3NhZ2UpCisgICAgICAoa2lsbC1w cm9jZXNzIChjYWFyIGVzaGVsbC1wcm9jZXNzLWxpc3QpKQorICAgICAgKGVzaGVsbC13YWl0 LWZvci1zdWJwcm9jZXNzIHQpCisgICAgICA7OyBFbnN1cmUgd2UgZGlkbid0IGVtaXQgYW5v dGhlciBwcm9tcHQgYWZ0ZXIga2lsbGluZyB0aGUKKyAgICAgIDs7IGJhY2tncm91bmQgcHJv Y2Vzcy4KKyAgICAgIChzaG91bGQgKGVzaGVsbC1tYXRjaC1vdXRwdXQgYmFja2dyb3VuZC1t ZXNzYWdlKSkpKSkKKwogDAogOzsgTGlzcCBmb3JtcwogCi0tIAoyLjI1LjEKCg== --------------Yn7ySHAv59FLcIoGWnaxG4KZ--