From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Renaming eglot -- or at least add an alias? Date: Fri, 7 Oct 2022 15:34:25 +0300 Message-ID: References: <83pmfdduix.fsf@gnu.org> <86wn9ji3ma.fsf@gmail.com> <86tu4lsnqk.fsf@gmail.com> <8335c0p2fn.fsf@gnu.org> <83leproov6.fsf@gnu.org> <83fsfzonwn.fsf@gnu.org> <5a1e604c-4500-a476-da3d-259d9057a7f0@yandex.ru> <838rlromxu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35659"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: rms@gnu.org, ams@gnu.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 07 16:29:50 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogoMI-0009BF-K1 for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Oct 2022 16:29:50 +0200 Original-Received: from localhost ([::1]:60762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogoMH-0000NF-GG for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Oct 2022 10:29:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogmZH-00035z-8x for emacs-devel@gnu.org; Fri, 07 Oct 2022 08:35:10 -0400 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:39732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogmZE-0003J0-Vr; Fri, 07 Oct 2022 08:35:06 -0400 Original-Received: by mail-wr1-x430.google.com with SMTP id f11so7110744wrm.6; Fri, 07 Oct 2022 05:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=TdBEFG8wMIYuey+TrliolALZR3AFcg2OQcWdq+sLhpc=; b=hR3UANVSs9NuQrmMRPvb4jcnJVhneDMH1c62cWxJqVg8fT+ClkUDhfMtwTurgxwaD0 e63C9hVeQ98M+9h7z+iI8lDwa+jAP9TsSL1gNMmItCVf4yC+2wbSUlF6cRkY6eAC9f+M liCYDgiBmj9XGlk0kAU/Aqa1f8iqKBDX/8Lbkd26x9b74NzrAYEFOZmUWACydaaAFyPb 6meXnMvuyZoQnhT/93XzFL4Yetd0Mb8qBNxL809Vh9xfMMPw7kIXYiF8r17pXq4+YInd b/PkkkIujsTJNSSvHo4zYtjrOkdDY6guhn/VId1xpoLcsfqkcPwlRae9xeTqZkXqF10K s9hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TdBEFG8wMIYuey+TrliolALZR3AFcg2OQcWdq+sLhpc=; b=FEHWdjpzWderRBt/kfekGifxX+OTpNTChpYtSbpFSlFAempQeQso0eXaSGDffGxXS0 2IYtcE0GoyhE0qIB1XW///B1SRJsTI3ylPW/RwwKbqRlnBvVQd3SY2r8I06OpJtCEN/O 8JS6itvpwkUWYcl4rNqG+xaOsJzvxnCbiHa3byf8KlkB6vA9Riwmy3Sg4zPVeJmqtFXs UNsaM0s3AovVASJK7n2dgLi4GPviUCykG+9TBR0jfb4OfiVQ7UQDNHgwB2ZqryMKXAcJ XsMGKxqTcu9vkP+IzNzMb5oS5yY7vAMAHi+gWr7+IV056gMO1hBG2i07c73JoRM5+0cM bn3g== X-Gm-Message-State: ACrzQf3cH4MQM9uNh/iRGCn9E8T5lzcgOgbvONQfje5silFTe1oFK5qL HXkwFXhx5e3WVyURBRLrDZazaRqYuBc= X-Google-Smtp-Source: AMsMyM79PXCbPSDF/bmVtRCPJ9Ak0+Q8TjYsOcPd6ITh6cej0OHnBniGOrqZa3DuR64tG+bwDKwGkQ== X-Received: by 2002:a5d:5846:0:b0:22a:f7a5:50d2 with SMTP id i6-20020a5d5846000000b0022af7a550d2mr3140942wrf.329.1665146067802; Fri, 07 Oct 2022 05:34:27 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j38-20020a05600c1c2600b003b3365b38f9sm1294840wms.10.2022.10.07.05.34.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Oct 2022 05:34:27 -0700 (PDT) Content-Language: en-US In-Reply-To: <838rlromxu.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=raaahh@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-2.699, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297152 Archived-At: On 07.10.2022 15:09, Eli Zaretskii wrote: >> Date: Fri, 7 Oct 2022 15:03:36 +0300 >> Cc: rms@gnu.org, ams@gnu.org, emacs-devel@gnu.org >> From: Dmitry Gutov >> >>>> IMHO that can be the best goal for the menu bar. But you might have a >>>> different understanding of its role. >>> Something to revisit at a later date, I think. Too many things are >>> still in flux: Eglot, tree-sitter... The functionalities overlap, and >>> at least I personally don't yet have a clear idea of how to make the >>> best "mix". >> >> IIUC tree-sitter will be used by specific major modes that implement the >> integration. Some will just do that from the outset, and some might have >> user options to toggle. > > Yes, so take python-mode as an example. It has both tree-sitter > support and Eglot support. How to use both? does it even make sense? Sure. Eglot: code completion, navigation, show method docs, calltips. TreeSitter: syntax highlighting, maybe indentation and imenu. So TreeSitter can help improve the "classic" features of major modes, but not build code intelligence on top, because it only works with individual files, just like existing major modes and their regexp based parsers (in font-lock, etc). >> But if those options are featured in the menu bar, they probably will be >> in the major mode's menu, not inside Tools. > > For Eglot, probably. For tree-sitter, I don't know yet. Above, I was talking solely about tree-sitter. > If we have > enough modes with tree-sitter support, it might make sense to allow it > globally. I think the issue is going to be how well each mode integrates with tree-sitter. Those that do it well, can enable it by default right away. Those that don't will have different problems. So it's not like we'll be able to decide that we're fine with a certain class of limitations, so let's enable it wholesale. And there will always remain major modes that don't have tree-sitter integration.