From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62009: 29.0.60; Emacs crashes on setf symbol-name Date: Sat, 11 Mar 2023 00:01:10 +0200 Message-ID: References: <87o7p5of4n.fsf@daniel-mendler.de> <871qm01s6n.fsf@web.de> <9fcf05e8-506c-6566-e214-2ecf3194b85e@daniel-mendler.de> <83bkl45ul4.fsf@gnu.org> <87v8j9zl3i.fsf@posteo.net> <83a60l13p2.fsf@gnu.org> <16ecbe9ea8ba9d39d058@heytings.org> <16ecbe9ea85b22d008fd@heytings.org> <43460d2c-ba80-0f2f-656c-ef0aca5667b5@daniel-mendler.de> <87fsacx2qf.fsf@gmail.com> <3a9f613f-baa9-2c48-f779-aaf43363a865@daniel-mendler.de> <83mt4kztwe.fsf@gnu.org> <20b91f20-1ed8-c38f-0165-b0eb3de1ee80@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8160"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Cc: philipk@posteo.net, michael_heerdegen@web.de, rpluim@gmail.com, gregory@heytings.org, monnier@iro.umontreal.ca, 62009@debbugs.gnu.org, arstoffel@gmail.com To: Daniel Mendler , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 10 23:02:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pakom-0001tt-He for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Mar 2023 23:02:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pakoV-0002Vm-RO; Fri, 10 Mar 2023 17:02:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pakoN-0002UF-B0 for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 17:02:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pakoM-0001M5-Vt for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 17:02:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pakoM-00032C-Ro for bug-gnu-emacs@gnu.org; Fri, 10 Mar 2023 17:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Mar 2023 22:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62009 X-GNU-PR-Package: emacs Original-Received: via spool by 62009-submit@debbugs.gnu.org id=B62009.167848568111572 (code B ref 62009); Fri, 10 Mar 2023 22:02:02 +0000 Original-Received: (at 62009) by debbugs.gnu.org; 10 Mar 2023 22:01:21 +0000 Original-Received: from localhost ([127.0.0.1]:56048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pakng-00030a-Rc for submit@debbugs.gnu.org; Fri, 10 Mar 2023 17:01:21 -0500 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:36842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paknf-00030N-6k for 62009@debbugs.gnu.org; Fri, 10 Mar 2023 17:01:19 -0500 Original-Received: by mail-wr1-f43.google.com with SMTP id l25so6342296wrb.3 for <62009@debbugs.gnu.org>; Fri, 10 Mar 2023 14:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678485673; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=5chzSR0H+hOgPm2g0TckewTLEdBpd17uthy8aowjTwo=; b=en+9ZGraJl/bV2Scse4CWPKd0C/wZdUMXoe6MnP7/PLhVY+Pd8LJfc5mKLDMbarlL9 ifsrqk0usoYQdxU24jeERy+GX8wC3q1STcmc+Wyv9wMgg00wX26zw/3X+7HsSq9XC4pw VdFSi4tgu6rgdzF91sP81WDrla/7dG9EiZlpKN8C1o2xr13cx/PjiyjX4sbLyDyH9STO aGw0duCnLfjIfA3MR7wyuKLlZDrtawQCOnId24vUGl6DduAh2vBrhxIfOjrDyUKEMu9Y m1qAW6tuCU7dDlr3c418l1in+Ylr0JzoLeAWrpB5r5dO8KURWZ/EVkG+IlhchKGSj6EG zneg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678485673; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5chzSR0H+hOgPm2g0TckewTLEdBpd17uthy8aowjTwo=; b=Bd0C4OArE9Tq2iXuSz8a1T6fEKLsI3sUWK45He+s5i5CZfpGTQOJzDJmfqsjfrhzaY FYSp7PThEO28AhGKM3RXprlATLTzI+9UkCkeyX4bKGfxtci39R1NJd3u/CbJTXnYRSWP tVIRVgQ6rg5F6iGGiLKVzXYduIDz07EQCpxbwB3wePhcAYgTI2RBRi3IpUXmSyaoZbDd 7dyf7SsfFAG+NfihNFgsZwiHeCXJy2Kyt+sUDXi1WSAgRZuIh+vmEVaqjgi7CeyZq4t4 Sl6RU2R+YxJ3vG4c1y6SkMl6IetENr6rFWtI5fQLs9ESTph8vh23unezd79Q0SK0IUs7 TRqA== X-Gm-Message-State: AO0yUKUt/zP+gKeEyGwydMdFwtWChqoltd626RF0yt2ksD0sd253pDxD Aazppy+UE4PasSX7iw8kwVE= X-Google-Smtp-Source: AK7set+mtXXJjAa65rlZ8mr1UFA8Kh+z8m4WWB90lkmiFmOZFqwFYU/9cWSYg5uReIiihhk6FvGM7g== X-Received: by 2002:adf:f546:0:b0:2c5:51a5:9ef8 with SMTP id j6-20020adff546000000b002c551a59ef8mr2516249wrp.8.1678485673016; Fri, 10 Mar 2023 14:01:13 -0800 (PST) Original-Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id t7-20020a7bc3c7000000b003e2066a6339sm1105744wmj.5.2023.03.10.14.01.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Mar 2023 14:01:12 -0800 (PST) Content-Language: en-US In-Reply-To: <20b91f20-1ed8-c38f-0165-b0eb3de1ee80@daniel-mendler.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257727 Archived-At: On 10/03/2023 14:24, Daniel Mendler wrote: > On 3/10/23 13:13, Eli Zaretskii wrote: >>> Date: Fri, 10 Mar 2023 12:36:17 +0100 >>> Cc: Gregory Heytings, >>> Philip Kaludercic,michael_heerdegen@web.de, >>> monnier@iro.umontreal.ca,62009@debbugs.gnu.org, Eli Zaretskii >>> , Augusto Stoffel >>> From: Daniel Mendler >>> >>>> /* Number of characters in string; MSB is used as the mark bit. */ >>>> ptrdiff_t size; >>>> /* If nonnegative, number of bytes in the string (which is multibyte). >>>> If negative, the string is unibyte: >>>> -1 for data normally allocated >>>> -2 for data in rodata (C string constants) >>>> -3 for data that must be immovable (used for bytecode) */ >>>> ptrdiff_t size_byte; >>> Thanks! That's good. Given that a read only flag already exists, it is >>> easy to fix the issue. We just have to make sure that the size is >>> negative for the symbol names and add a check in `aset`. >> Let's not do that! > Why not? There won't be a performance cost. Perhaps we could use some exact benchmark results.