From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#12492: Acknowledgement (24.2.50; Open vc-dir buffer easier and faster) Date: Fri, 5 Jul 2019 16:44:59 +0300 Message-ID: References: <505E43E1.9090801@yandex.ru> <505E4A57.5020305@yandex.ru> <9fb5adb4-05c0-695a-82be-6b001b6a1c5d@yandex.ru> <87h881y2bs.fsf@mail.linkov.net> <878stdv4kf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="73342"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 Cc: Andreas Schwab , 12492@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 05 15:50:49 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hjObx-000IxT-1h for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 15:50:49 +0200 Original-Received: from localhost ([::1]:53342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjObv-0003OO-0C for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Jul 2019 09:50:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41407) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hjOXU-0000lA-2V for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 09:46:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hjOXK-0005Jt-QL for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 09:46:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43723) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hjOXK-0005Hv-FN for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 09:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hjOXK-0001fP-Cb for bug-gnu-emacs@gnu.org; Fri, 05 Jul 2019 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jul 2019 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12492 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12492-submit@debbugs.gnu.org id=B12492.15623343096336 (code B ref 12492); Fri, 05 Jul 2019 13:46:02 +0000 Original-Received: (at 12492) by debbugs.gnu.org; 5 Jul 2019 13:45:09 +0000 Original-Received: from localhost ([127.0.0.1]:52544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjOWS-0001e7-Ni for submit@debbugs.gnu.org; Fri, 05 Jul 2019 09:45:08 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:50972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjOWQ-0001dH-VM for 12492@debbugs.gnu.org; Fri, 05 Jul 2019 09:45:07 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id n9so8953833wmi.0 for <12492@debbugs.gnu.org>; Fri, 05 Jul 2019 06:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hwtGH6vrcQSIu0Q50xwzP1XPOwyb+S4Df0MrcymnOI8=; b=MRrSSTjXG3hnHYdCFHdSChIcrL2ESbe4dbI6c3exBzTJE4r9TxQqdG7G/wAztfV3AK cnz2PCGC1ycMsQYLyck+de7lFJ3rOWkscY11qSbZaB46D/za6f7QIL7boS4mZj7OD4cC AR1cl7aKDDsg+jbI+qH3WTQYUS5byhkAA9ejUfCU/eBfXDrgyQud5sojhBmIi38W1G7X H7ahPmJHDDhK99oCvIiwHRnGAuWKKJ2zUZmWTqr5I0J/y2kRlHlnuSUMZBhpkrDFnDwI nqz0sfpXmgpRMWmh7SHU0aU6OKPLeckP9EauZyRnk8woO8NkrivqTHLnYtuAaxQzDCTi dIsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hwtGH6vrcQSIu0Q50xwzP1XPOwyb+S4Df0MrcymnOI8=; b=E4yhiwsiXhomsH7a1Ep0dXcKrwSHmZO3La/GRwsEYZwlvxI6ME7W2s+avQjcrsJrS+ Y2lYrTb3QB37GmKx6mzsmXAe0yDi1l0MWB28g4uAkkz1ouQVnszIRzOVRbPELAf1Wm1o JUo/aeVkKM/N+SYvgXxrC3OdQ5XGLvBDfrh1s176I8klpBSg9GBQ9UZqRynD3DYMD9rE X3hcFD9GFktGvqh9OLtE+WkF+H+jcp9B36JPTa0ITmgv4keyqKSfvww1QZJQ+IWMngql Y4m/wJiy7m4OMOP1uIKnt+dTSRaBFcX5yMufeDLQKGMmpC9Q7vCro0cjm3HBJTxJIoc8 phBg== X-Gm-Message-State: APjAAAWC1vBlykTNm7b6lwYMeVtGe6R4FgeUPDI4AhKdv0HhDlBurtiH w2VPcouWR+ysJq1HORmadbPef//XjJk= X-Google-Smtp-Source: APXvYqyJ6jZE6t7PnkI3RFY4vuy5NrBmGG0L+SNBau4P5b5bb6SBBCaB9gVLjnMYg+PKv/szsmflYQ== X-Received: by 2002:a05:600c:22ce:: with SMTP id 14mr3746775wmg.27.1562334301033; Fri, 05 Jul 2019 06:45:01 -0700 (PDT) Original-Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id c65sm8598297wma.44.2019.07.05.06.45.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jul 2019 06:45:00 -0700 (PDT) In-Reply-To: <878stdv4kf.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162126 Archived-At: On 05.07.2019 1:05, Juri Linkov wrote: > BTW, why vc-git-log-incoming and vc-git-log-outgoing are interactive? > It seems these functions are not intended to be used as commands: Makes sense, thank you. Please install. > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index f62e108322..6a6036cf8a 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1048,7 +1050,6 @@ vc-git-print-log > '("--"))))))) > > (defun vc-git-log-outgoing (buffer remote-location) > - (interactive) > (vc-setup-buffer buffer) > (vc-git-command > buffer 'async nil > @@ -1062,7 +1063,6 @@ vc-git-log-outgoing > "..HEAD"))) > > (defun vc-git-log-incoming (buffer remote-location) > - (interactive) > (vc-setup-buffer buffer) > (vc-git-command nil 0 nil "fetch") > (vc-git-command >