From: Dmitry Gutov <dgutov@yandex.ru>
To: Alan Mackenzie <acm@muc.de>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] comment-cache 223d16f 2/3: Apply `comment-depth' text properties when calling `back_comment'.
Date: Mon, 14 Mar 2016 21:33:25 +0200 [thread overview]
Message-ID: <b234bb07-13d0-e84a-a96d-372de6c16107@yandex.ru> (raw)
In-Reply-To: <20160314184621.GH1894@acm.fritz.box>
Hi Alan,
On 03/14/2016 08:46 PM, Alan Mackenzie wrote:
>>> CC Mode doesn't use syntax-ppss. It would be too much work to put it in,
>>> particularly as that function's future is unclear.
>
>> Could you please avoid FUD like that?
>
> There's no FUD in my last paragraph, it's an accurate representation of
> the facts.
Not at all. syntax-ppss's future is rather clear, and it's here to stay,
after years of successfully being in use.
> I am not prepared to spend the time needed to adapt CC Mode
> to use syntax-ppss, and wouldn't be even if it worked properly.
That's a separate issue. Right now we're discussing how to best
implement "comment cache", and if it's needed at all.
> I'm still trying to work out the point you're trying to make.
Apparently, the point is that you've been offered a simpler solution for
the same problem, and that you basically ignored it.
> Ah, so by "it" in "please try it already" you meant "apply Stefan's
> patch". That wasn't clear. Sorry.
Isn't what this subthread is about? The alternative approach?
> Yes, applying that patch and doing measurements would be a lot of work.
> You're welcome to do it if you're interested enough.
I might, but you'd first have to let me know what to test. If the
comment cache patch doesn't actually help with 22884, why are we even
discussing it?
> I have tried out Stefan's patch, and for the vast majority of
> comments on which it actually works, I've no doubt it will work fast
> enough. Its speed isn't the issue.
Ah, so the speed advantage of using text properties is not that much of
advantage. Correct?
> Stefan's patch doesn't actually fix what I see as the root cause of bug
> #22884, namely that comments get scanned backwards. At some time in the
> future this backward scanning will cause more bugs.
Can you produce a test case where it fails? This time without involving
narrowing, please.
> What has been tried is Martin Rudalics's `foo' and `bar' functions
> (which repeatedly perform `c-end-of-defun' and `c-beginning-of-defun'
> respectively). I'm not the only person who has noticed a dramatic
> increase in speed for the comment-cache branch in these
> (unrepresentative) tests. If you're interested, look at some of the
> timings in the posts branching off of Martin's first post in this
> thread.
Do you have any non-synthetic tests? (while (not (eobp)) (end-of-defun))
is not something that is likely to occur is a user's interation with
Emacs with any regularity.
For a synthetic test, by the way, a 60%-80% increase in performance is
not that impressive.
> It will make no difference to the scenario in #22884, no, and it was
> never envisaged that it would. What all these things have in common is
> problems caused by scanning comments backwards.
syntax-ppss helps with avoiding that.
next prev parent reply other threads:[~2016-03-14 19:33 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160308132530.861.91488@vcs.savannah.gnu.org>
[not found] ` <E1adHdj-0000FI-0W@vcs.savannah.gnu.org>
2016-03-08 14:19 ` [Emacs-diffs] comment-cache 223d16f 2/3: Apply `comment-depth' text properties when calling `back_comment' Stefan Monnier
2016-03-08 18:30 ` Alan Mackenzie
2016-03-08 18:42 ` Stefan Monnier
2016-03-08 20:07 ` Alan Mackenzie
2016-03-08 21:22 ` Dmitry Gutov
2016-03-08 21:43 ` Alan Mackenzie
2016-03-09 0:17 ` Stefan Monnier
2016-03-09 1:54 ` Stefan Monnier
2016-03-09 10:49 ` Problems with syntax-ppss: Was [... Apply `comment-depth' text properties when calling `back_comment'.] Alan Mackenzie
2016-03-09 13:11 ` Stefan Monnier
2016-03-09 14:19 ` Alan Mackenzie
2016-03-09 19:16 ` Stefan Monnier
2016-03-09 19:22 ` Clément Pit--Claudel
2016-03-09 19:37 ` Alan Mackenzie
2016-03-09 21:40 ` Stefan Monnier
2016-03-10 13:01 ` Alan Mackenzie
2016-03-10 14:52 ` Stefan Monnier
2016-03-10 15:29 ` Alan Mackenzie
2016-03-10 16:45 ` Stefan Monnier
2016-03-10 17:25 ` Alan Mackenzie
2016-03-10 17:34 ` Stefan Monnier
2016-03-10 19:08 ` Alan Mackenzie
2016-03-10 23:10 ` Stefan Monnier
2016-03-11 12:50 ` Stefan Monnier
2016-03-11 20:48 ` Alan Mackenzie
2016-03-11 22:35 ` Stefan Monnier
2016-03-11 23:08 ` Alan Mackenzie
2016-03-11 23:09 ` Clément Pit--Claudel
2016-03-11 23:31 ` Stefan Monnier
2016-03-10 23:31 ` John Wiegley
2016-03-11 2:08 ` Clément Pit--Claudel
2016-03-11 3:08 ` Stefan Monnier
2016-03-11 7:27 ` Andreas Röhler
2016-03-11 12:08 ` Alan Mackenzie
2016-03-11 12:30 ` Dmitry Gutov
2016-03-11 13:04 ` Alan Mackenzie
2016-03-11 20:21 ` Dmitry Gutov
2016-03-12 20:19 ` Andreas Röhler
2016-03-12 20:38 ` Dmitry Gutov
2016-03-12 20:45 ` Alan Mackenzie
2016-03-13 14:56 ` Andreas Röhler
2016-03-10 13:41 ` Stefan Monnier
2016-03-09 17:06 ` How do you check if the current point is in a comment or a string? (Was Re: Problems with syntax-ppss: Was [... Apply `comment-depth' text properties when calling `back_comment'.]) Clément Pit--Claudel
2016-03-09 17:24 ` Kaushal Modi
2016-03-09 17:56 ` Clément Pit--Claudel
2016-03-09 19:19 ` Kaushal Modi
2016-03-09 19:34 ` Clément Pit--Claudel
2016-03-10 14:28 ` Stefan Monnier
2016-03-10 15:03 ` Clément Pit--Claudel
2016-03-10 15:20 ` Stefan Monnier
2016-03-10 17:21 ` Clément Pit--Claudel
2016-03-12 20:45 ` Andreas Röhler
2016-03-12 20:53 ` Clément Pit--Claudel
2016-03-09 16:37 ` [Emacs-diffs] comment-cache 223d16f 2/3: Apply `comment-depth' text properties when calling `back_comment' Richard Stallman
2016-03-09 17:06 ` Dmitry Gutov
2016-03-10 21:20 ` Richard Stallman
2016-03-11 0:26 ` Dmitry Gutov
2016-03-11 12:22 ` Alan Mackenzie
2016-03-11 12:52 ` Stefan Monnier
2016-03-11 16:20 ` Drew Adams
2016-03-09 17:48 ` Alan Mackenzie
2016-03-09 19:58 ` martin rudalics
2016-03-09 20:36 ` Eli Zaretskii
2016-03-09 20:53 ` John Wiegley
2016-03-13 9:30 ` Daniel Colascione
2016-03-13 15:28 ` Stefan Monnier
2016-03-13 16:24 ` Eli Zaretskii
2016-03-13 16:27 ` Daniel Colascione
2016-03-13 17:19 ` Eli Zaretskii
2016-03-14 1:13 ` Stefan Monnier
2016-03-14 16:10 ` Eli Zaretskii
2016-03-11 18:27 ` Alan Mackenzie
2016-03-12 17:08 ` Alan Mackenzie
2016-03-12 18:10 ` martin rudalics
2016-03-12 18:22 ` Paul Eggert
2016-03-12 18:46 ` martin rudalics
2016-03-12 19:36 ` Alan Mackenzie
2016-03-13 9:26 ` martin rudalics
2016-03-13 11:52 ` Alan Mackenzie
2016-03-13 12:08 ` martin rudalics
2016-03-13 12:49 ` Alan Mackenzie
2016-03-13 13:32 ` martin rudalics
2016-03-13 17:59 ` Eli Zaretskii
2016-03-13 20:09 ` martin rudalics
2016-03-14 1:15 ` Paul Eggert
2016-03-14 7:42 ` martin rudalics
2016-03-14 11:22 ` Alan Mackenzie
2016-03-14 19:41 ` martin rudalics
2016-03-14 20:58 ` Alan Mackenzie
2016-03-14 16:15 ` Eli Zaretskii
2016-03-14 19:41 ` martin rudalics
2016-03-14 17:00 ` Paul Eggert
2016-03-14 19:41 ` martin rudalics
2016-03-14 16:09 ` Eli Zaretskii
2016-03-13 18:00 ` Eli Zaretskii
2016-03-13 18:41 ` Alan Mackenzie
2016-03-12 20:56 ` Dmitry Gutov
2016-03-12 21:29 ` Clément Pit--Claudel
2016-03-12 21:59 ` Dmitry Gutov
2016-03-12 21:58 ` Alan Mackenzie
2016-03-12 22:16 ` Dmitry Gutov
2016-03-13 17:59 ` Alan Mackenzie
2016-03-13 22:49 ` Stefan Monnier
2016-03-14 12:51 ` Alan Mackenzie
2016-03-15 3:14 ` Stefan Monnier
2016-03-14 1:13 ` Dmitry Gutov
2016-03-14 1:30 ` Stefan Monnier
2016-03-14 1:45 ` Dmitry Gutov
2016-03-14 2:18 ` Stefan Monnier
2016-03-14 12:23 ` Alan Mackenzie
2016-03-14 16:15 ` Dmitry Gutov
2016-03-14 17:29 ` Alan Mackenzie
2016-03-14 17:52 ` Dmitry Gutov
2016-03-14 18:46 ` Alan Mackenzie
2016-03-14 19:33 ` Dmitry Gutov [this message]
2016-03-14 21:20 ` Alan Mackenzie
2016-03-15 3:10 ` Stefan Monnier
2016-03-17 0:47 ` Dmitry Gutov
2016-03-17 18:47 ` Alan Mackenzie
2016-03-18 1:24 ` Dmitry Gutov
2016-03-10 21:20 ` Richard Stallman
2016-03-10 22:24 ` Alan Mackenzie
2016-03-12 1:53 ` Richard Stallman
2016-03-12 3:28 ` Stefan Monnier
2016-03-12 19:28 ` Richard Stallman
2016-03-09 17:51 ` Clément Pit--Claudel
2016-03-10 21:20 ` Richard Stallman
2016-03-10 21:38 ` Clément Pit--Claudel
2016-03-12 1:53 ` Richard Stallman
2016-03-10 7:14 ` Andreas Röhler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b234bb07-13d0-e84a-a96d-372de6c16107@yandex.ru \
--to=dgutov@yandex.ru \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.