From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 618310c: Work on `tramp-completion-mode-p' Date: Tue, 28 Feb 2017 02:06:01 +0200 Message-ID: References: <20170226114525.28549.46289@vcs0.savannah.gnu.org> <20170226114526.6EC2026044@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1488240374 24454 195.159.176.226 (28 Feb 2017 00:06:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Feb 2017 00:06:14 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 To: emacs-devel@gnu.org, Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 28 01:06:10 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciVIt-0005pp-Na for ged-emacs-devel@m.gmane.org; Tue, 28 Feb 2017 01:06:07 +0100 Original-Received: from localhost ([::1]:57757 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciVIz-0004uu-SK for ged-emacs-devel@m.gmane.org; Mon, 27 Feb 2017 19:06:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciVIu-0004up-J3 for emacs-devel@gnu.org; Mon, 27 Feb 2017 19:06:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciVIq-0004ZE-Lm for emacs-devel@gnu.org; Mon, 27 Feb 2017 19:06:08 -0500 Original-Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:34309) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ciVIq-0004Z4-Ep for emacs-devel@gnu.org; Mon, 27 Feb 2017 19:06:04 -0500 Original-Received: by mail-wm0-x22c.google.com with SMTP id 196so20961456wmm.1 for ; Mon, 27 Feb 2017 16:06:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Poia+KfV1xD3MuMSlxc8EkkSTFCsPSpVCUGreYyrQGc=; b=Cb3oV8TlTBBg7jSdpO3EYR4a+qLMmfS2ulZObxaFNX3pqSi5l4nrDkO3viQd6zLIdL b9e2+21Td1w87nvBpaJLwcNXKlZNFKVn0YKAxfMAVrvY6jtBRT4o1M4FW6gIE3cBkISQ YptCujCzPwYpJYJP1IckZX+RoX/MW+nU9ViNrabM1qLbX4ap1X4e5aguRq0tanLqOmtt 3j9RA48u+f+ADUtKOIE9Cgz5wVQ14M7Sr86GTR9hpo41jB5OqjOCCpiwt3BQ/ekmIOkJ PEngS+B2qyCE/Gy8fuSA7fFtKH70GqgX1+mhP8S3Tqe7sWZil6jjaerAy4xAGXvGkd/+ 1kww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Poia+KfV1xD3MuMSlxc8EkkSTFCsPSpVCUGreYyrQGc=; b=U9kIz1Zh3tBlxotsNy8Az3H8C3LMpWX1Iklx3gEnR6NVygZVOzDQAuphW0pP/PzVuA YWvwIkwRMr07m1nVK8YkwwDt6eMyEFZLufIiy+V1NqEzhryllNOfnMr0jMjo0fhlxqeh JT7drtUBkc/snDVaX2vtZGk3E3rSbCOSXuzk1aLJ6LxFEy4jy/D6wm9Eq1uIlsmc/NG7 uTfNI+NgiSidyqfQlPem0ndHdi5RezdTJBlJCrztLLAHGQRT77zbNyFfde+Vbbg8aCiY 0u9c6Pn/dDerOdVoifNpLP4jKctPxFEJTq5+/EwetDeSqTO7VLmU2gVSSUtenHO+C9a8 KWxQ== X-Gm-Message-State: AMke39mn72PQaIyaHj009CA82ofk/CBSiiWP527S9iYC0+9ELUAeKY6uo9WcJ1bZXa7ZEQ== X-Received: by 10.28.113.9 with SMTP id m9mr16303894wmc.60.1488240363425; Mon, 27 Feb 2017 16:06:03 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id k43sm236977wrk.42.2017.02.27.16.06.02 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 27 Feb 2017 16:06:02 -0800 (PST) In-Reply-To: <20170226114526.6EC2026044@vcs0.savannah.gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212634 Archived-At: On 26.02.2017 13:45, Michael Albinus wrote: > (progn (defun tramp-completion-mode-p () > "Check, whether method / user name / host name completion is active." > (or > ;; Signal from outside. `non-essential' has been introduced in Emacs 24. > (and (boundp 'non-essential) (symbol-value 'non-essential)) > - tramp-completion-mode))) > + ;; This variable has been obsoleted in Emacs 26. > + tramp-completion-mode > + ;; Fallback. Some completion packages still don't support > + ;; `non-essential' sufficiently. Any packages in particular? Should we try working with their authors? > + (equal last-input-event 'tab)))) Not sure I understand what's going on here. It seems you are making `non-essential' being non-nil and `tab' being the last input event have the same impact. Whereas, IME, the user pressing TAB usually means that the completion operation *is essential*, and they would probably be willing to input their connection credentials if necessary. Like the discussion in https://debbugs.gnu.org/25607 has touched on.