From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#18092: 24.4.50; doc string of `define-prefix-command' Date: Wed, 23 Jul 2014 13:16:50 -0700 (PDT) Message-ID: References: <59128bf2-e1e4-4f8d-89da-f04a5c31950b@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1406146716 4705 80.91.229.3 (23 Jul 2014 20:18:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Jul 2014 20:18:36 +0000 (UTC) To: 18092@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 23 22:18:26 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XA2zZ-0003nD-W3 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jul 2014 22:18:26 +0200 Original-Received: from localhost ([::1]:46801 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA2zZ-0001o3-IO for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jul 2014 16:18:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA2zN-0001mz-DM for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 16:18:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XA2zC-0002MP-K5 for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 16:18:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XA2zC-0002ML-Hc for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 16:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XA2zC-0001uB-0c for bug-gnu-emacs@gnu.org; Wed, 23 Jul 2014 16:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jul 2014 20:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18092-submit@debbugs.gnu.org id=B18092.14061466257125 (code B ref 18092); Wed, 23 Jul 2014 20:18:01 +0000 Original-Received: (at 18092) by debbugs.gnu.org; 23 Jul 2014 20:17:05 +0000 Original-Received: from localhost ([127.0.0.1]:35907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XA2yF-0001qo-Sn for submit@debbugs.gnu.org; Wed, 23 Jul 2014 16:17:04 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:50192) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XA2yC-0001pu-Ez for 18092@debbugs.gnu.org; Wed, 23 Jul 2014 16:17:01 -0400 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s6NKGqDv008221 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <18092@debbugs.gnu.org>; Wed, 23 Jul 2014 20:16:54 GMT Original-Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s6NKGpQB019300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for <18092@debbugs.gnu.org>; Wed, 23 Jul 2014 20:16:52 GMT Original-Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6NKGpVW014366 for <18092@debbugs.gnu.org>; Wed, 23 Jul 2014 20:16:51 GMT In-Reply-To: <59128bf2-e1e4-4f8d-89da-f04a5c31950b@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6691.5000 (x86)] X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91764 Archived-At: Things are actually worse than that. The notion of "prefix command" is not introduced or explained anywhere. It is not in either the Emacs manual or the Elisp manual.=20 `define-prefix-command' has been around for a long time, but it is a poorly chosen name. The symbol is NOT defined as a command or even as a function (it is fboundp but not functionp or commandp). This name is misleading and confusing. The Elisp manual speaks better of `define-prefix-command', by saying that it "prepares SYMBOL for use as a prefix key's binding" - nothing about "prefix command". Such wording should be used also for the doc string. It would even be good to rename the function (keeping `define-prefix-command' as a deprecated alias). Maybe something like `prepare-symbol-for-prefix-key'. The doc should also make clear that the value it puts in the function cell is a new, empty keymap. Thus, if you do (define-prefix-command 'foo), and then you define keys in that keymap, and then you do (define-prefix-command 'foo) again, the keys you bound earlier are lost (since a new map is now used for foo).