From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Tue, 18 Apr 2023 23:38:19 +0300 Message-ID: References: <87a5zj2vfo.fsf@gmail.com> <834jpk5hih.fsf@gnu.org> <871qkom3fj.fsf@posteo.net> <83mt3b4yfc.fsf@gnu.org> <87edonlsxi.fsf@posteo.net> <83jzyf4vzb.fsf@gnu.org> <871qknllkj.fsf@posteo.net> <83fs934pjf.fsf@gnu.org> <87wn2fk47y.fsf@posteo.net> <83sfd2g2ek.fsf@gnu.org> <875y9yfxrr.fsf@gmail.com> <87y1muefks.fsf@gmail.com> <834jpifizy.fsf@gnu.org> <83y1mue1qi.fsf@gnu.org> <83sfd2e01f.fsf@gnu.org> <1a5e5837-513b-84d8-3260-cdbf42b71267@gutov.dev> <83sfcz9rf2.fsf@gnu.org> <09a49ab9-ac72-36a9-3e68-9c633710eba7@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22747"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: 62720@debbugs.gnu.org, rpluim@gmail.com, philipk@posteo.net, monnier@iro.umontreal.ca, Eli Zaretskii , larsi@gnus.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 18 22:39:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pos6b-0005kE-MR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 18 Apr 2023 22:39:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pos6S-0005b4-Gr; Tue, 18 Apr 2023 16:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pos6Q-0005ae-9s for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 16:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pos6Q-0004ud-24 for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 16:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pos6P-00076B-Tr for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 16:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Apr 2023 20:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168185031327249 (code B ref 62720); Tue, 18 Apr 2023 20:39:01 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 18 Apr 2023 20:38:33 +0000 Original-Received: from localhost ([127.0.0.1]:60519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pos5x-00075R-2S for submit@debbugs.gnu.org; Tue, 18 Apr 2023 16:38:33 -0400 Original-Received: from new2-smtp.messagingengine.com ([66.111.4.224]:53687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pos5s-000758-O1 for 62720@debbugs.gnu.org; Tue, 18 Apr 2023 16:38:31 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id A70515822FC; Tue, 18 Apr 2023 16:38:23 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 18 Apr 2023 16:38:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681850303; x=1681853903; bh=6GSxkk/Ip0+SKuM9ZS36HI4PbCL5ocILOCz oG0jQgJ0=; b=Qq/T1xgmgoi6y69i4UVibB+VM0ZvhqPdFDAs26BP9zm+Elw8DAz IXcojhLoEk1wvu5QeGJ6ySIEl3Ra1XEl4cSFyG+dohR6lGO06tyju1Ya45s9QdNZ u0dUXZyvxF2oalllUUGCKaQd+Zeb7ETBW6HqW1D6e5a/SVKfpJUhgU4h2a5lH30s tMbq2tDrK8cRJDyZ495OzcsZ3Zdyd/iNAJjR6ooY5q36z3CNVYiAPOvVAc8iPx2X h0Twhe+/AcdncyBqOeEJM15PHqQEnL46CJ3+dN11/4lbngoF3us0BN6YaHATP5T3 DlzA5WU7RQHJQZIf4Fh9DlMNxlGXVM3kSFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681850303; x=1681853903; bh=6GSxkk/Ip0+SKuM9ZS36HI4PbCL5ocILOCz oG0jQgJ0=; b=kD6h2D1XflOuNn1Vhns+Dse4prn/etHyKMQietkI+UQcKOJAanP LKPSmDE1gpMxT+8dbWHp/TX2AqC7jhDmVmzxl0MXHNjYIre2+vxPMxFeEdwNcwMA h0K3rlZVI7EXSHqKpaFn/fX67b7O8TTzd5IOKyhAMtvVf+OOt22q+pRZcYOUjnU/ SIZc9xJpwRTsCyFmIF2kKixtsaIoJddd64BsEcmtVmdlNB2k9DQtnRyj2IqelUj5 syq4id80QmLFIPWjFqHF8pOqX60Ecl1jcps2bETdQgDIN1/2a+vo2EredNI0DdZs 7GKkV6tErC9+iDvDRoDn5sEU8KIf5APzaPQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelkedgudehudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpefhffehleejffegffeugefhkeektdffgfehjedvgeejtedtudehueffgffg feejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Apr 2023 16:38:21 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260237 Archived-At: On 18/04/2023 14:44, João Távora wrote: >> BTW, if you recall the threads before Eglot was added, I was against >> that, and one of the things I cited is an LSP client has inherently high >> development velocity. Maybe the LSP community will settle/mature/stop >> adding features one day, but it's not there yet. > > Very true, but the conclusion is only half-true. > > It didn't have to be like this: Eglot _can_ grow rapidly in master > and and have its periodic stable releases. And in the major Emacs > versions released to the public could have an even stabler release > (because it went through more testing). This is just like any other > :core package until now. This particular one didn't have to, but it's a problem very characteristic of joining a strongly centralized project with ultimately one person having the last word in all major decisions. And it's not like Eli is being unreasonable: we do need a stability cutoff, and we're really long past it. These one-more-change kind of arguments repeat year over year, with reasonable, well-intentioned people on both sides. I don't see any better solutions than better modularity (which delegates responsibility by its nature) and/or more frequent releases somehow. > The solution picked for this issue is bad in that it breaks some Eglot > users workflows and expectations when using very common configuration > recipes. We should revert it and pick a fix that relies on recognizing > that there are different "sets of criteria" as you propose. One > such fix remains uncriticized and unchallenged in this thread. Sure, and I agree, but I don't really see how to present that in terms Eli would feel suitable to accept. One "trick" that worked in the past was to somehow enumerate all potential execution flows (functions involved, etc) that would be affected by the change. > But if that doesn't happen, we shouldn't make a bad situation worse, > by backporting 100's of lines of code of Eglot and friends into Emacs 29. > That's the polar opposite in the pursuit of stability. Hand-picked > bugfixes for problems manifesting themselves in Emacs 29, sure! But > wholesale changes are just asking for trouble and destroying the > value of the pretest and RC periods. As bug#62907 shows, there are > certain edge-case bugs due to refactorings in upcoming Eglot 1.15 > that are not in 1.12.29 bundled with Emacs 29. Good! That's the way > it should be. Let's not ruin that. I don't insist, not at all. It was just my own impression of what would constitute a reasonable Eglot release that we could be satisfied with having a large number of people use without upgrading, for years. Issues like blinking eldoc messages, or eldoc messages that can take up half the height of the window seem like things that we wouldn't want in it. Perhaps the second issue affects only a minority of servers, and I'm wrong to be worried. Because otherwise, I really don't understand why it hasn't been reported and fixed until recently. Not blaming you, just to be clear. >>>> Because since we've decided in favor of stability of package.el, and >>>> against eglot's easy upgradability, I would suggest to backport Eglot >>>> 1.14 to emacs-29. >>> >>> I won't object. In fact, I asked up front why not. >> >> Note that that suggestion comes with a fix to eldoc which you so far >> have rejected for emacs-29. > > ...to name but one change to the non-Eglot, already-there-in-Emacs-28, > libraries Eglot depends on (or will depend on). > > I do think _that_ ElDoc fix should be just backported. It's not > a complicated fix by any measure, it's easy to test, and it indeed > has value and safety. Together with your similar fix for Company, > it'll make Emacs 29 users happier. That's what I'm thinking, too.