From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#58960: 29.0.50; Assert fails when browsing an URL, bug#58960: 29.0.50; Assert fails when browsing an URL Date: Wed, 2 Nov 2022 13:29:39 -0700 Organization: UCLA Computer Science Department Message-ID: References: <87k04dodxs.fsf@gmail.com> <83wn8da4eo.fsf@gnu.org> <87zgd9mpa8.fsf@gmail.com> <83k04d9yva.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------e2txKZLswJTael9QkOSavieE" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8530"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Cc: gerd.moellmann@gmail.com, 58960-done@debbugs.gnu.org, tino.calancha@gmail.com To: Eli Zaretskii , Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 02 21:30:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqKNh-00023B-OK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Nov 2022 21:30:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqKNK-0004Ff-BQ; Wed, 02 Nov 2022 16:30:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqKNA-0004C2-Dw for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 16:30:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oqKN9-0001v4-5A for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 16:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oqKN8-0002uo-F4 for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2022 16:30:02 -0400 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 20:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 58960 X-GNU-PR-Package: emacs Mail-Followup-To: 58960@debbugs.gnu.org, eggert@cs.ucla.edu, tino.calancha@gmail.com Original-Received: via spool by 58960-done@debbugs.gnu.org id=D58960.166742099011157 (code D ref 58960); Wed, 02 Nov 2022 20:30:02 +0000 Original-Received: (at 58960-done) by debbugs.gnu.org; 2 Nov 2022 20:29:50 +0000 Original-Received: from localhost ([127.0.0.1]:47255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqKMv-0002tt-Jv for submit@debbugs.gnu.org; Wed, 02 Nov 2022 16:29:50 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqKMt-0002tf-1L for 58960-done@debbugs.gnu.org; Wed, 02 Nov 2022 16:29:48 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 484CD160049; Wed, 2 Nov 2022 13:29:41 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 9CB2-CHh137c; Wed, 2 Nov 2022 13:29:40 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 588E516004A; Wed, 2 Nov 2022 13:29:40 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 588E516004A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1667420980; bh=AxkLF2AUZq4yaJPHp11F8J1iQU26KMEwcEmJKf6sPxI=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:From; b=KLrJY0AfiqDnURrtfJDpt9oNabug1KgUJcqiTmDg2QCL18Eea82bEEfD1VzSFXGVn h951KeBDoQU8D0FUziqXcxOF8iaROcbY+cSWSSqO4BNnGKYX+C7NJZqSLmDc/mPyVD zxQqgwjoSwru72ZdBzdUF+KmAl9xWra10zi8MXrI= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id oRT1fsbJ88AP; Wed, 2 Nov 2022 13:29:40 -0700 (PDT) Original-Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 20423160049; Wed, 2 Nov 2022 13:29:40 -0700 (PDT) Content-Language: en-US In-Reply-To: <83k04d9yva.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246893 Archived-At: This is a multi-part message in MIME format. --------------e2txKZLswJTael9QkOSavieE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11/2/22 08:09, Eli Zaretskii wrote: >> Why can=CA=BCt we just call `child_signal_init' from `init_process_ema= cs' >> instead of `create_process'? > Maybe we could. Assuming the signal stuff is already set so early, I > don't know exactly how posix_spawn works. child_signal_init is reasonably heavyweight in that it keeps a couple of=20 file descriptors open, so the idea is to be lazy and not call it unless=20 Emacs plans to have children. I installed the attached, which is like Robert's patch except it keeps=20 the critical section smaller and checks the declaration of the=20 now-extern function. Please give it a try. I'll boldly close the bug=20 report; we can reopen it if I'm wrong. --------------e2txKZLswJTael9QkOSavieE Content-Type: text/x-patch; charset=UTF-8; name="0001-Initialize-child-signal-handling-before-posix_spawn-.patch" Content-Disposition: attachment; filename*0="0001-Initialize-child-signal-handling-before-posix_spawn-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAwNWY1ZDk3OGFlNzBjNDg0OWE1YzQ3ODY1ZDYyMzAxZDI3MzE3YThhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDIgTm92IDIwMjIgMTM6MjQ6MjYgLTA3MDAKU3ViamVjdDogW1BBVENI XSBJbml0aWFsaXplIGNoaWxkIHNpZ25hbCBoYW5kbGluZyBiZWZvcmUgcG9zaXhfc3Bhd24g dG9vLgoKUHJvYmxlbSByZXBvcnRlZCBieSBUaW5vIENhbGFuY2hhIChCdWcjNTg5NjApLgoq IHNyYy9jYWxscHJvYy5jIChjYWxsX3Byb2Nlc3MpOiBJbml0aWFsaXplIFNJR0NITEQgaGFu ZGxpbmcKYmVmb3JlIHBvc3NpYmx5IGNyZWF0aW5nIGEgY2hpbGQgd2l0aCBlbWFjc19zcGFu LiAgVGhpcyBuZWVkIG5vdApiZSBpbiB0aGUgY3JpdGljYWwgc2VjdGlvbiB0aGF0IGNhbGxz IGVtYWNzX3NwYXduLCBzbyBkbyBpdApvdXRzaWRlIHRoZSBjcml0aWNhbCBzZWN0aW9uLgoq IHNyYy9wcm9jZXNzLmMgKGNoaWxkX3NpZ25hbF9pbml0KTogTm93IGV4dGVybi4KLS0tCiBz cmMvY2FsbHByb2MuYyB8IDEgKwogc3JjL2xpc3AuaCAgICAgfCAxICsKIHNyYy9wcm9jZXNz LmMgIHwgMyArLS0KIDMgZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9jYWxscHJvYy5jIGIvc3JjL2NhbGxwcm9jLmMK aW5kZXggNGQ0Yjg2NjI5Yy4uZjlmODQwZTU0NCAxMDA2NDQKLS0tIGEvc3JjL2NhbGxwcm9j LmMKKysrIGIvc3JjL2NhbGxwcm9jLmMKQEAgLTY0OCw2ICs2NDgsNyBAQCBjYWxsX3Byb2Nl c3MgKHB0cmRpZmZfdCBuYXJncywgTGlzcF9PYmplY3QgKmFyZ3MsIGludCBmaWxlZmQsCiAK ICNpZm5kZWYgTVNET1MKIAorICBjaGlsZF9zaWduYWxfaW5pdCAoKTsKICAgYmxvY2tfaW5w dXQgKCk7CiAgIGJsb2NrX2NoaWxkX3NpZ25hbCAoJm9sZHNldCk7CiAKZGlmZiAtLWdpdCBh L3NyYy9saXNwLmggYi9zcmMvbGlzcC5oCmluZGV4IGQ4N2Y5NTQ5MzguLmVhZmEyNDFhZGYg MTAwNjQ0Ci0tLSBhL3NyYy9saXNwLmgKKysrIGIvc3JjL2xpc3AuaApAQCAtNDkxNSw2ICs0 OTE1LDcgQEAgI2RlZmluZSBEQUVNT05fUlVOTklORyAodzMyX2RhZW1vbl9ldmVudCAhPSBJ TlZBTElEX0hBTkRMRV9WQUxVRSkKIAogLyogRGVmaW5lZCBpbiBwcm9jZXNzLmMuICAqLwog c3RydWN0IExpc3BfUHJvY2VzczsKK2V4dGVybiB2b2lkIGNoaWxkX3NpZ25hbF9pbml0ICh2 b2lkKTsKIGV4dGVybiB2b2lkIGtpbGxfYnVmZmVyX3Byb2Nlc3NlcyAoTGlzcF9PYmplY3Qp OwogZXh0ZXJuIGludCB3YWl0X3JlYWRpbmdfcHJvY2Vzc19vdXRwdXQgKGludG1heF90LCBp bnQsIGludCwgYm9vbCwgTGlzcF9PYmplY3QsCiAJCQkJCXN0cnVjdCBMaXNwX1Byb2Nlc3Mg KiwgaW50KTsKZGlmZiAtLWdpdCBhL3NyYy9wcm9jZXNzLmMgYi9zcmMvcHJvY2Vzcy5jCmlu ZGV4IDM1ODg5OWNkZWQuLjUxNDRjNWQ2YzkgMTAwNjQ0Ci0tLSBhL3NyYy9wcm9jZXNzLmMK KysrIGIvc3JjL3Byb2Nlc3MuYwpAQCAtMjkyLDcgKzI5Miw2IEBAIG5ldHdvcmtfbG9va3Vw X2FkZHJlc3NfaW5mb18xIChMaXNwX09iamVjdCBob3N0LCBjb25zdCBjaGFyICpzZXJ2aWNl LAogICAgZGVzY3JpcHRvciB0byBub3RpZnkgYHdhaXRfcmVhZGluZ19wcm9jZXNzX291dHB1 dCcgb2YgcHJvY2VzcwogICAgc3RhdHVzIGNoYW5nZXMuICAqLwogc3RhdGljIGludCBjaGls ZF9zaWduYWxfd3JpdGVfZmQgPSAtMTsKLXN0YXRpYyB2b2lkIGNoaWxkX3NpZ25hbF9pbml0 ICh2b2lkKTsKICNpZm5kZWYgV0lORE9XU05UCiBzdGF0aWMgdm9pZCBjaGlsZF9zaWduYWxf cmVhZCAoaW50LCB2b2lkICopOwogI2VuZGlmCkBAIC03MzIzLDcgKzczMjIsNyBAQCBERUZV TiAoInByb2Nlc3Mtc2VuZC1lb2YiLCBGcHJvY2Vzc19zZW5kX2VvZiwgU3Byb2Nlc3Nfc2Vu ZF9lb2YsIDAsIDEsIDAsCiAKIC8qIFNldCB1cCBgY2hpbGRfc2lnbmFsX3JlYWRfZmQnIGFu ZCBgY2hpbGRfc2lnbmFsX3dyaXRlX2ZkJy4gICovCiAKLXN0YXRpYyB2b2lkCit2b2lkCiBj aGlsZF9zaWduYWxfaW5pdCAodm9pZCkKIHsKICAgLyogRWl0aGVyIGJvdGggYXJlIGluaXRp YWxpemVkLCBvciBib3RoIGFyZSB1bmluaXRpYWxpemVkLiAgKi8KLS0gCjIuMzguMQoK --------------e2txKZLswJTael9QkOSavieE--