From: "Clément Pit--Claudel" <clement.pit@gmail.com>
To: Drew Adams <drew.adams@oracle.com>, 24353@debbugs.gnu.org
Subject: bug#24353: 25.1.1: looking-back wrong info
Date: Sat, 3 Sep 2016 14:24:59 -0400 [thread overview]
Message-ID: <b19baf34-19b3-9a39-338a-de51bba73b3b@gmail.com> (raw)
In-Reply-To: <aa4844fe-f893-4829-8777-42f28ae6a1ab@default>
[-- Attachment #1.1: Type: text/plain, Size: 1101 bytes --]
On 2016-09-03 14:10, Drew Adams wrote:
> When you first wrote your code, presumably you consulted
> the doc string. The problem, if you did read the doc,
> is that the "general recommendation" there, at the very
> end, SAYS NOTHING about LIMIT.
Maybe? Or maybe I knew looking-at and used eldoc to get the signature. I can't recall.
> …
> NOTHING HAS CHANGED in this function, apart from a minor
> doc change and addition of `advertised-calling-convention'.
Right. And the addition of the advertised-calling-convention caused me, and perhaps others, to revisit existing code that did not include a limit.
So it was a neat addition, since the misleading doc string, or my own carelessness, caused me to make mistakes in the past. Fortunately, these mistakes are now fixed, because I got byte-compilation warnings. Very convenient.
Of course, upgrading the docstring could still be a good idea; but I don't make the mistake anymore, since when I write new calls to this function eldoc asks me to add the LIMIT argument, so mostly don't care about that update.
Clément.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-03 18:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 8:48 bug#24353: 25.1.1: looking-back wrong info Andreas Röhler
2016-09-02 8:58 ` Eli Zaretskii
2016-09-02 9:57 ` Andreas Röhler
2016-09-02 10:04 ` Eli Zaretskii
2016-09-02 17:51 ` Drew Adams
2016-09-02 19:03 ` Eli Zaretskii
2016-09-02 20:10 ` Dmitry Gutov
2016-09-02 23:59 ` Drew Adams
2016-09-03 0:03 ` Dmitry Gutov
2016-09-03 0:10 ` Drew Adams
2016-09-03 0:14 ` npostavs
2016-09-03 0:15 ` Dmitry Gutov
2016-09-03 0:28 ` Drew Adams
2016-09-03 17:35 ` Clément Pit--Claudel
2016-09-03 18:10 ` Drew Adams
2016-09-03 18:24 ` Clément Pit--Claudel [this message]
2016-09-03 18:31 ` npostavs
2016-09-03 18:57 ` Drew Adams
2016-09-04 13:08 ` Michael Heerdegen
2016-09-03 17:50 ` Clément Pit--Claudel
2016-09-03 18:42 ` Drew Adams
2016-09-03 18:52 ` Eli Zaretskii
[not found] <<e554564c-50a0-8c71-3b79-183ffd54b9c3@easy-emacs.de>
[not found] ` <<83lgzael08.fsf@gnu.org>
[not found] ` <<a404cb34-311e-3fb3-dde8-4340e57c97e5@easy-emacs.de>
[not found] ` <<83k2euehyc.fsf@gnu.org>
[not found] ` <<bf60cf1c-b9b9-4505-ab9f-d518dcf1725c@default>
[not found] ` <<83eg52dszc.fsf@gnu.org>
2016-09-02 20:03 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b19baf34-19b3-9a39-338a-de51bba73b3b@gmail.com \
--to=clement.pit@gmail.com \
--cc=24353@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.