From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jes Bodi Klinke" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/1] compile.el bug in recognizing -o switches among Date: Thu, 28 Oct 2010 12:43:26 -0700 (PDT) Message-ID: References: <5e0d0f4adb8ef5510aeacb9bcbe9a1a7.squirrel@xspect.dk> <93ede5c63f6ca7272e5b0feb43e929f4.squirrel@xspect.dk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1288295022 20529 80.91.229.12 (28 Oct 2010 19:43:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 28 Oct 2010 19:43:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 28 21:43:39 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PBYNs-00068F-1i for ged-emacs-devel@m.gmane.org; Thu, 28 Oct 2010 21:43:36 +0200 Original-Received: from localhost ([127.0.0.1]:37283 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBYNr-0001BT-3s for ged-emacs-devel@m.gmane.org; Thu, 28 Oct 2010 15:43:35 -0400 Original-Received: from [140.186.70.92] (port=39086 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBYNl-0001BO-DM for emacs-devel@gnu.org; Thu, 28 Oct 2010 15:43:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBYNk-00017Y-Aq for emacs-devel@gnu.org; Thu, 28 Oct 2010 15:43:29 -0400 Original-Received: from xspect.dk ([77.66.17.204]:39996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBYNk-00017M-5e for emacs-devel@gnu.org; Thu, 28 Oct 2010 15:43:28 -0400 Original-Received: from xspect.dk (xspect.dk [127.0.0.1]) by xspect.dk (Postfix) with ESMTP id 7221D8ABF3; Thu, 28 Oct 2010 21:43:26 +0200 (CEST) Original-Received: from 216.239.45.4 (SquirrelMail authenticated user jesk) by xspect.dk with HTTP; Thu, 28 Oct 2010 12:43:26 -0700 (PDT) In-Reply-To: User-Agent: SquirrelMail/1.4.15 X-Priority: 3 (Normal) Importance: Normal X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132166 Archived-At: >> (by adding an outer pair of parentheses). The correct regex is: >> " -\\(?:o[=3D ]?\\|-\\(?:outfile\\|output\\)[=3D ]\\)\\(\\S +\\)" > > Thanks, installed. > But, could you tell me how you made your patches? > Neither diff-mode nor `patch' understand their format: Thank you. Responses like this to my feedback encourages me to spend mor= e time on Emacs the next time. About the patch. I manually edited the output from bzr diff. I deleted what I thought was a comment line. It looked like bzr had tried to extract the name of the enclosing function, but it had failed badly and pulled out part of an unrelated text literal. I thought that letting it be could confuse human readers of the patch, but I guess I should have just deleted the text to the right of the ***********, not the entire line. Regards Jes Bodi Klinke