From: "Jes Bodi Klinke" <jes@bodi-klinke.dk>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 1/1] compile.el bug in recognizing -o switches among
Date: Thu, 28 Oct 2010 12:43:26 -0700 (PDT) [thread overview]
Message-ID: <b195f4077e3aec2c69e64cecb97714e3.squirrel@xspect.dk> (raw)
In-Reply-To: <jwvzktzjf5n.fsf-monnier+emacs@gnu.org>
>> (by adding an outer pair of parentheses). The correct regex is:
>> " -\\(?:o[= ]?\\|-\\(?:outfile\\|output\\)[= ]\\)\\(\\S +\\)"
>
> Thanks, installed.
> But, could you tell me how you made your patches?
> Neither diff-mode nor `patch' understand their format:
Thank you. Responses like this to my feedback encourages me to spend more
time on Emacs the next time.
About the patch. I manually edited the output from bzr diff. I deleted
what I thought was a comment line. It looked like bzr had tried to
extract the name of the enclosing function, but it had failed badly and
pulled out part of an unrelated text literal. I thought that letting it
be could confuse human readers of the patch, but I guess I should have
just deleted the text to the right of the ***********, not the entire
line.
Regards
Jes Bodi Klinke
next prev parent reply other threads:[~2010-10-28 19:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:11 [PATCH 1/1] compile.el bug in recognizing -o switches among output Jes Bodi Klinke
2010-10-27 21:37 ` Jes Bodi Klinke
2010-10-28 1:13 ` [PATCH 1/1] compile.el bug in recognizing -o switches among Stefan Monnier
2010-10-28 19:43 ` Jes Bodi Klinke [this message]
2010-10-29 17:32 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b195f4077e3aec2c69e64cecb97714e3.squirrel@xspect.dk \
--to=jes@bodi-klinke.dk \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.