From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67977: 30.0.50; tree-sitter: Emacs crashes when accessing treesit-nodes in a narrowed buffer Date: Thu, 28 Dec 2023 13:44:43 +0200 Message-ID: References: <87r0jdddxf.fsf@yandex.ru> <835y0pfkgr.fsf@gnu.org> <1DE32BF7-75D8-4F49-975D-53C782D26016@gmail.com> <08D379EF-1556-4498-8E60-F7972A25752A@gmail.com> <83edfccbwi.fsf@gnu.org> <262157E9-A92C-4063-ADA4-725C156FB227@gmail.com> <83r0j79522.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27535"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Denis Zubarev , 67977@debbugs.gnu.org To: Yuan Fu , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 28 12:45:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIop8-0006tB-Hy for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Dec 2023 12:45:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rIooy-0002zr-Vm; Thu, 28 Dec 2023 06:45:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rIoox-0002zc-T9 for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 06:45:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rIoox-0000dE-Ky for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 06:45:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rIoow-0004ub-Dt for bug-gnu-emacs@gnu.org; Thu, 28 Dec 2023 06:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Dec 2023 11:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67977 X-GNU-PR-Package: emacs Original-Received: via spool by 67977-submit@debbugs.gnu.org id=B67977.170376389718849 (code B ref 67977); Thu, 28 Dec 2023 11:45:02 +0000 Original-Received: (at 67977) by debbugs.gnu.org; 28 Dec 2023 11:44:57 +0000 Original-Received: from localhost ([127.0.0.1]:38639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIoor-0004tx-1h for submit@debbugs.gnu.org; Thu, 28 Dec 2023 06:44:57 -0500 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:54463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rIooo-0004tg-Nj for 67977@debbugs.gnu.org; Thu, 28 Dec 2023 06:44:55 -0500 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id 2F8723200A3B; Thu, 28 Dec 2023 06:44:49 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 28 Dec 2023 06:44:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1703763888; x=1703850288; bh=0hMbGBXdvFN8qsNz6b5uGGGaJ5W94yhfCYwjHTp4kfI=; b= hSb6dqMzNdOGIKUHnLTZLwOZsGVzm8PH0DJ3FHTzADfEQ7yTuV6a+RhCIk1b3x8X rNHGntZDUlJoZOdSlF5JUi8IyQYaOW8Qqvkh1E5JEPnIGd+yMkMlupqZ7iRiBWeh fohRlmKYldmGUiYsUcOBIY6bT5LxFhs+opd2hgVcgYq+dj4xih2/A7FkwTZmNVXI Qr7JKuTKzF5hOScHZv8oe8GREMpaEBWGo07I345k0ugpesxQ/e0eE7QdC+2kszwQ W9I/Ww2z+hhQWHdE6vRQxASV5Qnf7v/N2c24whHIFtAkQbj3Fa43vuadnqBctctU RTYdmHyIlHGDpMTlIb9txQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1703763888; x= 1703850288; bh=0hMbGBXdvFN8qsNz6b5uGGGaJ5W94yhfCYwjHTp4kfI=; b=q BSNiV0SpR4fAPLoG2w7dhGVIqIurhLzWqnAuz/9ie6bsHobHVr8NrQytV8IEhohY qtwUv+L0hpC5HQmlwxi3Mb1Mq9W7/f/bewRCO68cWP1lgpAMbx4v7dGTmICk/G/H LMAhrhfRahXTgZxARJ4/7D3o41jG3huG3zjTl8OYWE7M2b0KEw5cPK6i7KS4/2am ljzGtqcAqCrLxF0xPh25UcDQFd/TOn1QPSMI3vI4Zf96cGv5dog5loBFir8l+y1k QvNzhQ3G1C8ffcrD7pATK+plK6LkVnmmPa8b5fYsybLsp2qSgCK3MjuJqcyomhbt 2vv/NF3x2kILr4KI2MJWQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdefuddgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveegtedthefhudekteehffeu keeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Dec 2023 06:44:47 -0500 (EST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276970 Archived-At: On 28/12/2023 10:07, Yuan Fu wrote: > >> On Dec 27, 2023, at 4:57 AM, Eli Zaretskii wrote: >> >>> From: Yuan Fu >>> Date: Tue, 26 Dec 2023 20:15:24 -0800 >>> Cc: Denis Zubarev, >>> 67977@debbugs.gnu.org >>> >>>> Btw, I hope that these calls to 'widen' don't require unnecessary >>>> reparsing by tree-sitter, do they? >>> Yes, but only because we called treesit-node-at while the buffer is narrowed, which triggers a reparse. Font-lock and jit-lock themselves always access the parser with widened buffer so they don’t trigger reparse on their own. >>> >>> So it seems working in a narrowed buffer would trigger a lot of back-and-fortch reparse. I wonder if it’s worth optimizing for (eg, use two parsers behind the scenes, one for widened buffer and one for narrowed buffer). >> Could font-lock-dont-widen help, perhaps? > Yes. If font-lock doesn’t widen, then there wouldn’t be back-and-forth reparses. But then treesit major modes will be affected by user narrowing (e.g. if the user narrowed to inside the string, the buffer won't be highlighted as a string).