From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Sat, 29 May 2021 10:11:09 +0200 Message-ID: References: <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87y2c5nhsr.fsf@mail.linkov.net> <87h7irss50.fsf@mail.linkov.net> <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <874kenulu2.fsf@gmail.com> <5f032d77-670e-e83e-fa37-f0a57e08e166@daniel-mendler.de> <87v973t5q3.fsf@gmail.com> <87v972hf1r.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36164"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "emacs-devel@gnu.org" , =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , monnier@iro.umontreal.ca, Dmitry Gutov To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 29 10:11:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmu4d-0009Ek-Bd for ged-emacs-devel@m.gmane-mx.org; Sat, 29 May 2021 10:11:59 +0200 Original-Received: from localhost ([::1]:53338 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmu4c-000686-98 for ged-emacs-devel@m.gmane-mx.org; Sat, 29 May 2021 04:11:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmu3v-0005IG-OP for emacs-devel@gnu.org; Sat, 29 May 2021 04:11:15 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:58013 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmu3t-0000RN-NY for emacs-devel@gnu.org; Sat, 29 May 2021 04:11:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lt3EXezVWKpfYau31ZjUNXHjZCKzDnV6Um/mpecCFks=; b=oBK6P1OqhmsMaMqGvwYhunRtk+ CncJ5NOwyqQjdbhLLn4CL/jl7ME5QLuDVkek2s+2iFdP+/43N3gvrx+qlhKyPNyRQSHYQ1ZW3J3fA st6s843O2IekGRnpvnyPn9fbcCrw00Yu/pcu/vt8Teai2bR4OV5LaFhs6JqQPsYWBHp8=; In-Reply-To: <87v972hf1r.fsf@mail.linkov.net> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270036 Archived-At: On 5/28/21 8:46 PM, Juri Linkov wrote: > (funcall resolution/decoration-function "candidate") > ⇒ > (:prefix "prefix" :suffix "suffix" :my-annotation1 "suffix1" :my-annotation2 "suffix2" ...) > > 2. A call with nil instead of the string candidate could return > the metadata of all supported fields, e.g.: > > (funcall resolution/decoration-function nil) > ⇒ > ((:name :prefix > :type 'string) > (:name :suffix > :type 'string) > (:name :my-annotation1 > :type 'number > :tags '(:expensive-field :unstable)) > (:name :my-annotation2 > :type 'image) > (:name :tablist > :type 'list)) > > 3. A call with an additional field could restrict the output only > to that field: > > (funcall resolution/decoration-function "candidate" :prefix) > ⇒ > "prefix" What about adding a descriptor to the `metadata` alist itself for the field type information? I think we could go with a slightly simpler definition. 1. Add a `decoration-function` to the metadata. The function takes two arguments, a candidate string and a list of field symbols. It returns returns a plist of the requested fields. 2. Add a `decoration-fields` list to the metadata, which describes all the available decoration fields with the necessary field type information in a format similar to the one you described above. Daniel