From: Davis Herring <herring@lanl.gov>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] ash, lsh: Avoid code duplication
Date: Tue, 22 Nov 2016 09:48:20 -0700 [thread overview]
Message-ID: <b0ac559a-dbe4-84ae-991d-73900aba73f5@lanl.gov> (raw)
In-Reply-To: <83bmx892lx.fsf@gnu.org>
>> --- a/src/lisp.h
>> +++ b/src/lisp.h
>> @@ -602,6 +602,7 @@ extern void char_table_set (Lisp_Object, int, Lisp_Object);
>> /* Defined in data.c. */
>> extern _Noreturn Lisp_Object wrong_type_argument (Lisp_Object, Lisp_Object);
>> extern _Noreturn void wrong_choice (Lisp_Object, Lisp_Object);
>> +Lisp_Object ash_lsh_impl (Lisp_Object, Lisp_Object, bool);
>
> No need to declare it here, as it is a static function used only in
> the file in which it is defined.
In case it helps explain the issue, note that the "extern" here did
nothing substantive: functions are extern if not static, and the extern
keyword isn't needed to prevent a function declaration being a definition.
Davis
--
This product is sold by volume, not by mass. If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.
prev parent reply other threads:[~2016-11-22 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 14:45 [PATCH] ash, lsh: Avoid code duplication Tino Calancha
2016-11-21 15:57 ` Eli Zaretskii
2016-11-21 16:20 ` Tino Calancha
2016-11-21 17:14 ` Eli Zaretskii
2016-11-22 2:17 ` Tino Calancha
2016-11-22 16:12 ` Eli Zaretskii
2016-11-22 16:16 ` Tino Calancha
2016-11-27 3:28 ` Tino Calancha
2016-11-22 16:48 ` Davis Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0ac559a-dbe4-84ae-991d-73900aba73f5@lanl.gov \
--to=herring@lanl.gov \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.