From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Mon, 2 Jan 2017 22:13:40 +0300 Message-ID: References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> <877f95deig.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1483384443 8219 195.159.176.226 (2 Jan 2017 19:14:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 2 Jan 2017 19:14:03 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: Eli Zaretskii , emacs-devel@gnu.org To: Michael Albinus , Nikolay Kudryavtsev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 02 20:13:59 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cO83K-0000Wx-LP for ged-emacs-devel@m.gmane.org; Mon, 02 Jan 2017 20:13:50 +0100 Original-Received: from localhost ([::1]:58581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cO83O-0000AU-Kx for ged-emacs-devel@m.gmane.org; Mon, 02 Jan 2017 14:13:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cO83H-000095-GH for emacs-devel@gnu.org; Mon, 02 Jan 2017 14:13:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cO83D-0000oe-JK for emacs-devel@gnu.org; Mon, 02 Jan 2017 14:13:47 -0500 Original-Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:34080) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cO83D-0000nA-AP; Mon, 02 Jan 2017 14:13:43 -0500 Original-Received: by mail-lf0-x242.google.com with SMTP id d16so28459898lfb.1; Mon, 02 Jan 2017 11:13:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Tx9zMQy2b77mHZTd1/mJE0lnOn6Q6BgCtrlHmSH1RzE=; b=FL9zlyoQeaxF5fbhruWdkLxLJsWuqC1cDRToxIrXQrW58iD5z5UbB+EDWbJTU1PG1y ooocrWqSlZ1Ujz6KE5DshBRYmOPgqsV2WFs3fGjInA9dVmp3fH7BNmgQ3lYbX7EtRJ83 NJWPnB3a4K7/wCeHgIt7ClwXGKnkIoAlftKP7KjWnD/kHvL+fK/TwqDMxWQKzhXiX8Pi BsDKyJ2oG0zW2VDUtUsuU0WolGAjzCOMjEckmjQLOZKcarX/Ji/CdEvRfAPCt2S5cq9m e2WIlQ0oYe65KDXWR9e61YTcDHAdKhNvvB7QDM+cvsODPmoeAHgX88ilzgNXLIM39iaq g+IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Tx9zMQy2b77mHZTd1/mJE0lnOn6Q6BgCtrlHmSH1RzE=; b=fgYFq7yCmc4heEKwCek9sTo43NvGNqSwaJBxIgNleyX6X7YE6IQcmIY7g2ABeyqSDn vbwsONgyOCE5hir+1a0EDZ9iyu0AlHl82VOy4hSwRrGs0rDmbXMGDc4Cn2l3OysXKu3G /6gkPdu4ao62sW/HaZeEN+ggNOX9YU1ssQPhWuR2Mr1akZp0/Jz4dQyRGeP3kqglhQtF 6fPVuAWoq5l5yF5u7sdQQkjlD7+pbUS0JQyWpTRTil22LL4uAtXBy2eLgJmb2tXfskUU Qp4SrZCF7OjUCK9gEkxTlZS3QyOewE6125Uc2mbp964D5nq6uL3pxguPc0g95Q3Ub6Wj Chkw== X-Gm-Message-State: AIkVDXKfV25iCDtKgYLjUxqHrp7oYOsGoJdh2ql5yd54tLvBawOb555QePeIHMFiFXKsEg== X-Received: by 10.25.15.39 with SMTP id e39mr21695129lfi.117.1483384421968; Mon, 02 Jan 2017 11:13:41 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id d135sm16027149lfg.12.2017.01.02.11.13.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Jan 2017 11:13:41 -0800 (PST) In-Reply-To: <877f95deig.fsf@gmx.de> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211071 Archived-At: On 18.10.2016 15:32, Michael Albinus wrote: > I don't decide whether such a patch shall be applied; it shall be > decided by the vc maintainer. But in case of, the patch could be written > shorter: Trying this patch again, I'm getting these byte-compilation warnings: 712 22 warning reference to free variable ‘method’ (emacs-lisp) 712 29 warning reference to free variable ‘user’ (emacs-lisp) 712 34 warning reference to free variable ‘host’ (emacs-lisp) 713 50 warning reference to free variable ‘v’ (emacs-lisp) 1503 1 warning the following functions are not known to be defined: with-parsed-tramp-file-name, tramp-make-tramp-file-name, tramp-make-tramp-temp-file (emacs-lisp) Which probably means that we need to load Tramp somehow at least during compilation, for the macro. And also declare the missing functions.