Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Stefan Kangas]

Gerd Moellmann <gerd@gnu.org> writes:

> branch: master
> commit 8aef5d224a6fccb675729748836d5ebfdcfa1101
> Merge: ea865c98cf3 6fa2050ee76
> Author: Gerd Möllmann <gerd@gnu.org>
> Commit: Gerd Möllmann <gerd@gnu.org>
>
>     Merge branch 'scratch/tty-child-frames'
>
>     Add support for child frames on tty
>
>     The redisplay part is complete.  The frame-handling part supports
>     use-cases like Posframe, Corfu, and child frames acting like tooltips.
>     Other use-cases of child frames are not currently supported.  In
>     particular, trying to create minibuffer-only child frames on ttys will
>     signal an error.

Very nice, thank you!  And congratulations.

I can't find anything about this in NEWS, though.

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Gerd Möllmann]

Stefan Kangas <stefankangas@gmail.com> writes:

> Gerd Moellmann <gerd@gnu.org> writes:
>
>> branch: master
>> commit 8aef5d224a6fccb675729748836d5ebfdcfa1101
>> Merge: ea865c98cf3 6fa2050ee76
>> Author: Gerd Möllmann <gerd@gnu.org>
>> Commit: Gerd Möllmann <gerd@gnu.org>
>>
>>     Merge branch 'scratch/tty-child-frames'
>>
>>     Add support for child frames on tty
>>
>>     The redisplay part is complete.  The frame-handling part supports
>>     use-cases like Posframe, Corfu, and child frames acting like tooltips.
>>     Other use-cases of child frames are not currently supported.  In
>>     particular, trying to create minibuffer-only child frames on ttys will
>>     signal an error.
>
> Very nice, thank you!  And congratulations.

Thanks, one thing less to try to not forget :-). Or two actually, with
the not pausing for input, even better.

> I can't find anything about this in NEWS, though.

I'll add one real soon now (tm). Need to synchronize with GNU first.

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Gerd Möllmann]

Stefan Kangas <stefankangas@gmail.com> writes:

> Gerd Moellmann <gerd@gnu.org> writes:
>
>> branch: master
>> commit 8aef5d224a6fccb675729748836d5ebfdcfa1101
>> Merge: ea865c98cf3 6fa2050ee76
>> Author: Gerd Möllmann <gerd@gnu.org>
>> Commit: Gerd Möllmann <gerd@gnu.org>
>>
>>     Merge branch 'scratch/tty-child-frames'
>>
>>     Add support for child frames on tty
>>
>>     The redisplay part is complete.  The frame-handling part supports
>>     use-cases like Posframe, Corfu, and child frames acting like tooltips.
>>     Other use-cases of child frames are not currently supported.  In
>>     particular, trying to create minibuffer-only child frames on ttys will
>>     signal an error.
>
> Very nice, thank you!  And congratulations.
>
> I can't find anything about this in NEWS, though.

Now done, but it would be nice if someone could check if that's
sufficient and so on.

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Robert Pluim]

>>>>> On Thu, 19 Dec 2024 13:44:54 +0100, Gerd Möllmann <gerd.moellmann@gmail.com> said:

    Gerd> Stefan Kangas <stefankangas@gmail.com> writes:
    >> Gerd Moellmann <gerd@gnu.org> writes:
    >> 
    >>> branch: master
    >>> commit 8aef5d224a6fccb675729748836d5ebfdcfa1101
    >>> Merge: ea865c98cf3 6fa2050ee76
    >>> Author: Gerd Möllmann <gerd@gnu.org>
    >>> Commit: Gerd Möllmann <gerd@gnu.org>
    >>> 
    >>> Merge branch 'scratch/tty-child-frames'
    >>> 
    >>> Add support for child frames on tty
    >>> 
    >>> The redisplay part is complete.  The frame-handling part supports
    >>> use-cases like Posframe, Corfu, and child frames acting like tooltips.
    >>> Other use-cases of child frames are not currently supported.  In
    >>> particular, trying to create minibuffer-only child frames on ttys will
    >>> signal an error.
    >> 
    >> Very nice, thank you!  And congratulations.
    >> 
    >> I can't find anything about this in NEWS, though.

    Gerd> Now done, but it would be nice if someone could check if that's
    Gerd> sufficient and so on.

I was thinking of sticking something like this on top. Do we need to
document the limitations there, such as no suport for minibuffer-only?

diff --git a/doc/lispref/frames.texi b/doc/lispref/frames.texi
index bf4d5c05f3a..cc7d3f79a7f 100644
--- a/doc/lispref/frames.texi
+++ b/doc/lispref/frames.texi
@@ -3393,8 +3393,8 @@ Child Frames
 
   By design, operations to make or modify child frames are implemented
 with the help of frame parameters (@pxref{Frame Parameters}) without any
-specialized functions or customizable variables.  Note that child frames
-are meaningful on graphical terminals only.
+specialized functions or customizable variables.  Child frames
+are meaningful on graphical and text terminals.
 
   To create a new child frame or to convert a normal frame into a child
 frame, set that frame's @code{parent-frame} parameter (@pxref{Frame


Robert
-- 

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Gerd Möllmann]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Thu, 19 Dec 2024 13:44:54 +0100, Gerd Möllmann <gerd.moellmann@gmail.com> said:
>
>     Gerd> Stefan Kangas <stefankangas@gmail.com> writes:
>     >> Gerd Moellmann <gerd@gnu.org> writes:
>     >> 
>     >>> branch: master
>     >>> commit 8aef5d224a6fccb675729748836d5ebfdcfa1101
>     >>> Merge: ea865c98cf3 6fa2050ee76
>     >>> Author: Gerd Möllmann <gerd@gnu.org>
>     >>> Commit: Gerd Möllmann <gerd@gnu.org>
>     >>> 
>     >>> Merge branch 'scratch/tty-child-frames'
>     >>> 
>     >>> Add support for child frames on tty
>     >>> 
>     >>> The redisplay part is complete.  The frame-handling part supports
>     >>> use-cases like Posframe, Corfu, and child frames acting like tooltips.
>     >>> Other use-cases of child frames are not currently supported.  In
>     >>> particular, trying to create minibuffer-only child frames on ttys will
>     >>> signal an error.
>     >> 
>     >> Very nice, thank you!  And congratulations.
>     >> 
>     >> I can't find anything about this in NEWS, though.
>
>     Gerd> Now done, but it would be nice if someone could check if that's
>     Gerd> sufficient and so on.
>
> I was thinking of sticking something like this on top. Do we need to
> document the limitations there, such as no suport for minibuffer-only?
>
> diff --git a/doc/lispref/frames.texi b/doc/lispref/frames.texi
> index bf4d5c05f3a..cc7d3f79a7f 100644
> --- a/doc/lispref/frames.texi
> +++ b/doc/lispref/frames.texi
> @@ -3393,8 +3393,8 @@ Child Frames
>  
>    By design, operations to make or modify child frames are implemented
>  with the help of frame parameters (@pxref{Frame Parameters}) without any
> -specialized functions or customizable variables.  Note that child frames
> -are meaningful on graphical terminals only.
> +specialized functions or customizable variables.  Child frames
> +are meaningful on graphical and text terminals.
>  
>    To create a new child frame or to convert a normal frame into a child
>  frame, set that frame's @code{parent-frame} parameter (@pxref{Frame
>
> Robert

Thanks!

Can't answer your question, but I just stumbled over the last paragraph
above. Changing a root to a child frame or vice versa is also not
supported on ttys.

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Robert Pluim]

>>>>> On Thu, 19 Dec 2024 17:09:03 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> I was thinking of sticking something like this on top.

    Eli> Please do, and thanks.

Done

    >> Do we need to document the limitations there, such as no suport for
    >> minibuffer-only?

    Eli> No.  It's in NEWS, and that is enough for now.

>>>>> On Thu, 19 Dec 2024 15:58:50 +0100, Gerd Möllmann <gerd.moellmann@gmail.com> said:

    Gerd> Can't answer your question, but I just stumbled over the last paragraph
    Gerd> above. Changing a root to a child frame or vice versa is also not
    Gerd> supported on ttys.

Iʼve put that in NEWS too.

Robert
-- 

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Gerd Möllmann]

> On 19. Dec 2024, at 16:30, Robert Pluim <rpluim@gmail.com> wrote:
> 
>>>>>> On Thu, 19 Dec 2024 17:09:03 +0200, Eli Zaretskii <eliz@gnu.org> said:
> 
>>> I was thinking of sticking something like this on top.
> 
>    Eli> Please do, and thanks.
> 
> Done
> 
>>> Do we need to document the limitations there, such as no suport for
>>> minibuffer-only?
> 
>    Eli> No.  It's in NEWS, and that is enough for now.
> 
>>>>>> On Thu, 19 Dec 2024 15:58:50 +0100, Gerd Möllmann <gerd.moellmann@gmail.com> said:
> 
>    Gerd> Can't answer your question, but I just stumbled over the last paragraph
>    Gerd> above. Changing a root to a child frame or vice versa is also not
>    Gerd> supported on ttys.
> 
> Iʼve put that in NEWS too.
> 
> Robert
> --
Thansk!

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Eli Zaretskii]

> From: Robert Pluim <rpluim@gmail.com>
> Cc: Stefan Kangas <stefankangas@gmail.com>,  Gerd Moellmann <gerd@gnu.org>,
>  emacs-devel@gnu.org
> Date: Thu, 19 Dec 2024 15:50:07 +0100
> 
> I was thinking of sticking something like this on top.

Please do, and thanks.

> Do we need to document the limitations there, such as no suport for
> minibuffer-only?

No.  It's in NEWS, and that is enough for now.

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Michael Albinus]

Gerd Moellmann <gerd@gnu.org> writes:

Hi Gerd,

>     Merge branch 'scratch/tty-child-frames'
>
>     Add support for child frames on tty

This breaks xt-mouse-tests:

--8<---------------cut here---------------start------------->8---
# make -C test xt-mouse-tests
Test xt-mouse-tracking-basic condition:
    (error "tty frame should be used")
   FAILED  1/3  xt-mouse-tracking-basic (0.776520 sec) at lisp/xt-mouse-tests.el:61
Test xt-mouse-tracking-sgr condition:
    (error "tty frame should be used")
   FAILED  2/3  xt-mouse-tracking-sgr (0.000466 sec) at lisp/xt-mouse-tests.el:102
Test xt-mouse-tracking-utf-8 condition:
    (error "tty frame should be used")
   FAILED  3/3  xt-mouse-tracking-utf-8 (0.000746 sec) at lisp/xt-mouse-tests.el:80
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Gerd Möllmann]

Michael Albinus <michael.albinus@gmx.de> writes:

> Gerd Moellmann <gerd@gnu.org> writes:
>
> Hi Gerd,
>
>>     Merge branch 'scratch/tty-child-frames'
>>
>>     Add support for child frames on tty
>
> This breaks xt-mouse-tests:
>
> --8<---------------cut here---------------start------------->8---
> # make -C test xt-mouse-tests
> Test xt-mouse-tracking-basic condition:
>     (error "tty frame should be used")
>    FAILED  1/3  xt-mouse-tracking-basic (0.776520 sec) at lisp/xt-mouse-tests.el:61
> Test xt-mouse-tracking-sgr condition:
>     (error "tty frame should be used")
>    FAILED  2/3  xt-mouse-tracking-sgr (0.000466 sec) at lisp/xt-mouse-tests.el:102
> Test xt-mouse-tracking-utf-8 condition:
>     (error "tty frame should be used")
>    FAILED  3/3  xt-mouse-tracking-utf-8 (0.000746 sec) at lisp/xt-mouse-tests.el:80
> --8<---------------cut here---------------end--------------->8---
>
> Best regards, Michael.

Hi Michael,

The new code now _requires_ a tty frame to be used (decode_tty_frame,
check_tty), which I think the tests can't provide, running in batch. And
I'd rather not be less picky for the sake of these tests.

Kind of a predicament. Any idea what could be done? 

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Eli Zaretskii]

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 19 Dec 2024 12:59:44 +0100
> 
> Michael Albinus <michael.albinus@gmx.de> writes:
> 
> > Gerd Moellmann <gerd@gnu.org> writes:
> >
> > Hi Gerd,
> >
> >>     Merge branch 'scratch/tty-child-frames'
> >>
> >>     Add support for child frames on tty
> >
> > This breaks xt-mouse-tests:
> >
> > --8<---------------cut here---------------start------------->8---
> > # make -C test xt-mouse-tests
> > Test xt-mouse-tracking-basic condition:
> >     (error "tty frame should be used")
> >    FAILED  1/3  xt-mouse-tracking-basic (0.776520 sec) at lisp/xt-mouse-tests.el:61
> > Test xt-mouse-tracking-sgr condition:
> >     (error "tty frame should be used")
> >    FAILED  2/3  xt-mouse-tracking-sgr (0.000466 sec) at lisp/xt-mouse-tests.el:102
> > Test xt-mouse-tracking-utf-8 condition:
> >     (error "tty frame should be used")
> >    FAILED  3/3  xt-mouse-tracking-utf-8 (0.000746 sec) at lisp/xt-mouse-tests.el:80
> > --8<---------------cut here---------------end--------------->8---
> >
> > Best regards, Michael.
> 
> Hi Michael,
> 
> The new code now _requires_ a tty frame to be used (decode_tty_frame,
> check_tty), which I think the tests can't provide, running in batch. And
> I'd rather not be less picky for the sake of these tests.

Why is that a problem?  A batch session does have a frame, you just
need to account for that.  I think the test that emits the error is
too strict, and should be relaxed when noninteractive is non-zero.  Or
maybe invert the test and check for !FRAME_WINDOW_P (which would then
allow the frame that exists in the batch session).

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Gerd Möllmann]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Gerd Möllmann <gerd.moellmann@gmail.com>
>> Cc: emacs-devel@gnu.org
>> Date: Thu, 19 Dec 2024 12:59:44 +0100
>> 
>> Michael Albinus <michael.albinus@gmx.de> writes:
>> 
>> > Gerd Moellmann <gerd@gnu.org> writes:
>> >
>> > Hi Gerd,
>> >
>> >>     Merge branch 'scratch/tty-child-frames'
>> >>
>> >>     Add support for child frames on tty
>> >
>> > This breaks xt-mouse-tests:
>> >
>> > --8<---------------cut here---------------start------------->8---
>> > # make -C test xt-mouse-tests
>> > Test xt-mouse-tracking-basic condition:
>> >     (error "tty frame should be used")
>> >    FAILED  1/3  xt-mouse-tracking-basic (0.776520 sec) at lisp/xt-mouse-tests.el:61
>> > Test xt-mouse-tracking-sgr condition:
>> >     (error "tty frame should be used")
>> >    FAILED  2/3  xt-mouse-tracking-sgr (0.000466 sec) at lisp/xt-mouse-tests.el:102
>> > Test xt-mouse-tracking-utf-8 condition:
>> >     (error "tty frame should be used")
>> >    FAILED  3/3  xt-mouse-tracking-utf-8 (0.000746 sec) at lisp/xt-mouse-tests.el:80
>> > --8<---------------cut here---------------end--------------->8---
>> >
>> > Best regards, Michael.
>> 
>> Hi Michael,
>> 
>> The new code now _requires_ a tty frame to be used (decode_tty_frame,
>> check_tty), which I think the tests can't provide, running in batch. And
>> I'd rather not be less picky for the sake of these tests.
>
> Why is that a problem?  

You mean why removing the checks (decode_tty_frame, check_tty) is a
problem?. My question is more what these tests bring tot he table that
outweighs removing checks.
 
> A batch session does have a frame, you just need to account for that.

I know it has an initial frame, which is neither a tty nor a window
system frame. The idea of testing xt-mouse with that is, let's say,
interesting. And then that comment

;; FIXME: this doesn't work when called inside a non-batch mode Emacs
;; session.

> I think the test that emits the error is too strict, and should be
> relaxed when noninteractive is non-zero. Or maybe invert the test and
> check for !FRAME_WINDOW_P (which would then allow the frame that
> exists in the batch session).

I could maybe make check_tty not signal if noninteractive == true. I
guess that could make things work, one has to try, but it surely doesn't
win a beauty price :-(.

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Eli Zaretskii]

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: michael.albinus@gmx.de,  emacs-devel@gnu.org
> Date: Thu, 19 Dec 2024 14:19:20 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> The new code now _requires_ a tty frame to be used (decode_tty_frame,
> >> check_tty), which I think the tests can't provide, running in batch. And
> >> I'd rather not be less picky for the sake of these tests.
> >
> > Why is that a problem?  
> 
> You mean why removing the checks (decode_tty_frame, check_tty) is a
> problem?. My question is more what these tests bring tot he table that
> outweighs removing checks.
>  
> > A batch session does have a frame, you just need to account for that.
> 
> I know it has an initial frame, which is neither a tty nor a window
> system frame. The idea of testing xt-mouse with that is, let's say,
> interesting. And then that comment

That frame is very much like a tty frame, AFAIR.  I suggest to try
relaxing the test and seeing if the xt-mouse tests then pass.

> > I think the test that emits the error is too strict, and should be
> > relaxed when noninteractive is non-zero. Or maybe invert the test and
> > check for !FRAME_WINDOW_P (which would then allow the frame that
> > exists in the batch session).
> 
> I could maybe make check_tty not signal if noninteractive == true. I
> guess that could make things work, one has to try, but it surely doesn't
> win a beauty price :-(.

If it makes a test work, why not?  We can even document this in a
comment.

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Gerd Möllmann]

Eli Zaretskii <eliz@gnu.org> writes:

>> I could maybe make check_tty not signal if noninteractive == true. I
>> guess that could make things work, one has to try, but it surely doesn't
>> win a beauty price :-(.
>
> If it makes a test work, why not?  We can even document this in a
> comment.

The test now succeeds for me, but I'm feeling a little bit dirty :-).

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[Eli Zaretskii]

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: michael.albinus@gmx.de,  emacs-devel@gnu.org
> Date: Fri, 20 Dec 2024 07:08:32 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> I could maybe make check_tty not signal if noninteractive == true. I
> >> guess that could make things work, one has to try, but it surely doesn't
> >> win a beauty price :-(.
> >
> > If it makes a test work, why not?  We can even document this in a
> > comment.
> 
> The test now succeeds for me, but I'm feeling a little bit dirty :-).

Welcome to the club.

Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

[John ff]

[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]




-------- Original Message --------
From: Eli Zaretskii <eliz@gnu.org>
Sent: Thu Dec 19 12:46:48 GMT 2024
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: michael.albinus@gmx.de, emacs-devel@gnu.org
Subject: Re: master 8aef5d224a6: Merge branch 'scratch/tty-child-frames'

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 19 Dec 2024 12:59:44 +0100
> 
> Michael Albinus <michael.albinus@gmx.de> writes:
> 
> > Gerd Moellmann <gerd@gnu.org> writes:
> >
> > Hi Gerd,
> >
> >>     Merge branch 'scratch/tty-child-frames'
> >>
> >>     Add support for child frames on tty
> >
> > This breaks xt-mouse-tests:
> >
> > --8<---------------cut here---------------start------------->8---
> > # make -C test xt-mouse-tests
> > Test xt-mouse-tracking-basic condition:
> >     (error "tty frame should be used")
> >    FAILED  1/3  xt-mouse-tracking-basic (0.776520 sec) at lisp/xt-mouse-tests.el:61
> > Test xt-mouse-tracking-sgr condition:
> >     (error "tty frame should be used")
> >    FAILED  2/3  xt-mouse-tracking-sgr (0.000466 sec) at lisp/xt-mouse-tests.el:102
> > Test xt-mouse-tracking-utf-8 condition:
> >     (error "tty frame should be used")
> >    FAILED  3/3  xt-mouse-tracking-utf-8 (0.000746 sec) at lisp/xt-mouse-tests.el:80
> > --8<---------------cut here---------------end--------------->8---
> >
> > Best regards, Michael.
> 
> Hi Michael,
> 
> The new code now _requires_ a tty frame to be used (decode_tty_frame,
> check_tty), which I think the tests can't provide, running in batch. And
> I'd rather not be less picky for the sake of these tests.

Why is that a problem?  A batch session does have a frame, you just
need to account for that.  I think the test that emits the error is
too strict, and should be relaxed when noninteractive is non-zero.  Or
maybe invert the test and check for !FRAME_WINDOW_P (which would then
allow the frame that exists in the batch session).



[-- Attachment #2: Type: text/html, Size: 2734 bytes --]