* bug#47316: 27.1; commands with color input should use a common color chooser
@ 2021-03-22 11:01 scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-22 11:33 ` Eli Zaretskii
2021-03-22 18:49 ` Lars Ingebrigtsen
0 siblings, 2 replies; 7+ messages in thread
From: scame via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-03-22 11:01 UTC (permalink / raw)
To: 47316
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
set-foreground-color uses a color chooser: read-color.
customize-face uses something else which looks more readable IMO, though
the usefulness of the underline is debatable:
https://necromuralist.github.io/posts/changing-emacs-font-colors/color_selector.png
Other commands like set-face-foreground, highlight-regexp and others show only
color names, but not the colors themselves.
All color input commands should use a common color selector which shows the
actual colors too.
[-- Attachment #2: Type: text/html, Size: 759 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#47316: 27.1; commands with color input should use a common color chooser
2021-03-22 11:01 bug#47316: 27.1; commands with color input should use a common color chooser scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-03-22 11:33 ` Eli Zaretskii
2021-03-22 12:11 ` scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-22 18:49 ` Lars Ingebrigtsen
1 sibling, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2021-03-22 11:33 UTC (permalink / raw)
To: laszlomail, 47316
On March 22, 2021 1:01:13 PM GMT+02:00, "scame via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> wrote:
> set-foreground-color uses a color chooser: read-color.
>
> customize-face uses something else which looks more readable IMO,
> though
> the usefulness of the underline is debatable:
>
> https://necromuralist.github.io/posts/changing-emacs-font-colors/color_selector.png
>
> Other commands like set-face-foreground, highlight-regexp and others
> show only
> color names, but not the colors themselves.
>
> All color input commands should use a common color selector which
> shows the
> actual colors too.
read-color will show you the colors from which you can select if you type '?', the standard Emacs command that requests the list of possible candidate values.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#47316: 27.1; commands with color input should use a common color chooser
2021-03-22 11:33 ` Eli Zaretskii
@ 2021-03-22 12:11 ` scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-22 17:42 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: scame via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-03-22 12:11 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 47316
> read-color will show you the colors from which you can select if you type '?', the standard Emacs command that requests the list of possible candidate values.
Yes, I mentioned it in my mail:
> > set-foreground-color uses a color chooser: read-color.
But customize use a different implementation, not read-color (at least on 27)
and other commands do not use read-color at all, despite getting color input,
they just list the color names without coloring them.
Other commands which read a face, not a color, show just face names for
completion. Showing face colors and other attributes inline (like in case
of list-faces-display) could be a nice improvement.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#47316: 27.1; commands with color input should use a common color chooser
2021-03-22 12:11 ` scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-03-22 17:42 ` Eli Zaretskii
0 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2021-03-22 17:42 UTC (permalink / raw)
To: scame; +Cc: 47316
> Date: Mon, 22 Mar 2021 12:11:56 +0000
> From: scame <laszlomail@protonmail.com>
> Cc: "scame via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>, "47316@debbugs.gnu.org" <47316@debbugs.gnu.org>
>
> > read-color will show you the colors from which you can select if you type '?', the standard Emacs command that requests the list of possible candidate values.
>
> Yes, I mentioned it in my mail:
>
> > > set-foreground-color uses a color chooser: read-color.
The way it was written, together with the rest of the message, could
cause people to interpret that as if read-color didn't display the
colors. My intent was to point out that it does.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#47316: 27.1; commands with color input should use a common color chooser
2021-03-22 11:01 bug#47316: 27.1; commands with color input should use a common color chooser scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-22 11:33 ` Eli Zaretskii
@ 2021-03-22 18:49 ` Lars Ingebrigtsen
2021-03-22 19:57 ` scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2021-03-22 18:49 UTC (permalink / raw)
To: scame; +Cc: 47316
scame <laszlomail@protonmail.com> writes:
> set-foreground-color uses a color chooser: read-color.
>
> customize-face uses something else which looks more readable IMO, though
> the usefulness of the underline is debatable:
>
> https://necromuralist.github.io/posts/changing-emacs-font-colors/color_selector.png
I think the Customize face interface probably should remain separate...
> Other commands like set-face-foreground, highlight-regexp and others show only
> color names, but not the colors themselves.
>
> All color input commands should use a common color selector which shows the
> actual colors too.
I've now fixed set-face-*, but highlight-regexp does not prompt for a
colour name -- it prompts for a face, so it can't use read-color.
Are there any other commands that prompts for colours that doesn't use
read-color?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#47316: 27.1; commands with color input should use a common color chooser
2021-03-22 18:49 ` Lars Ingebrigtsen
@ 2021-03-22 19:57 ` scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-22 20:01 ` Lars Ingebrigtsen
0 siblings, 1 reply; 7+ messages in thread
From: scame via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-03-22 19:57 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 47316@debbugs.gnu.org
>
> I've now fixed set-face-*, but highlight-regexp does not prompt for a
> colour name -- it prompts for a face, so it can't use read-color.
>
> Are there any other commands that prompts for colours that doesn't use
> read-color?
I encountered this problem with the set-face- commands only. Other color
commands seem to use read-color.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#47316: 27.1; commands with color input should use a common color chooser
2021-03-22 19:57 ` scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-03-22 20:01 ` Lars Ingebrigtsen
0 siblings, 0 replies; 7+ messages in thread
From: Lars Ingebrigtsen @ 2021-03-22 20:01 UTC (permalink / raw)
To: scame; +Cc: 47316@debbugs.gnu.org
scame <laszlomail@protonmail.com> writes:
>> I've now fixed set-face-*, but highlight-regexp does not prompt for a
>> colour name -- it prompts for a face, so it can't use read-color.
>>
>> Are there any other commands that prompts for colours that doesn't use
>> read-color?
>
> I encountered this problem with the set-face- commands only. Other color
> commands seem to use read-color.
OK; thanks for checking. I'm closing this bug report, then.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-22 20:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-22 11:01 bug#47316: 27.1; commands with color input should use a common color chooser scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-22 11:33 ` Eli Zaretskii
2021-03-22 12:11 ` scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-22 17:42 ` Eli Zaretskii
2021-03-22 18:49 ` Lars Ingebrigtsen
2021-03-22 19:57 ` scame via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-22 20:01 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.