From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] OS X: make configure work better out of the box with FSF GCC Date: Mon, 28 Feb 2011 14:56:59 -0500 Message-ID: References: <4D69DBAE.5070401@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1298923031 7484 80.91.229.12 (28 Feb 2011 19:57:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 28 Feb 2011 19:57:11 +0000 (UTC) Cc: Emacs development discussions To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 28 20:57:07 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pu9DP-00055B-1f for ged-emacs-devel@m.gmane.org; Mon, 28 Feb 2011 20:57:07 +0100 Original-Received: from localhost ([127.0.0.1]:42113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pu9DO-00023j-Gs for ged-emacs-devel@m.gmane.org; Mon, 28 Feb 2011 14:57:06 -0500 Original-Received: from [140.186.70.92] (port=37183 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pu9DJ-00023e-Dx for emacs-devel@gnu.org; Mon, 28 Feb 2011 14:57:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pu9DI-0005LT-Ht for emacs-devel@gnu.org; Mon, 28 Feb 2011 14:57:01 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:34501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pu9DI-0005LO-F6 for emacs-devel@gnu.org; Mon, 28 Feb 2011 14:57:00 -0500 Original-Received: from localhost ([127.0.0.1]:45997) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pu9DI-0000wr-2d; Mon, 28 Feb 2011 14:57:00 -0500 X-Spook: Compsec oil blackjack Abbas Rand Corporation genetic X-Ran: >[|c|iTt)tZL\$,J-Mod|LuDf[qw)*z]Z2>8Dm':L0}l$ (Daniel Colascione's message of "Sat, 26 Feb 2011 21:05:50 -0800") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136614 Archived-At: Daniel Colascione wrote: > I didn't include the corresponding configure changes; I figure I can let > whoever installs this patch regenerate the script. Could you explain what problem this change is supposed to fix? > + case "$(which "${CC-cc}")" in > + /usr/bin/* | /usr/lib/* ) > + CPP="${CC-cc} -E -no-cpp-precomp" > + ;; > + * ) > + # The below macro prevents the Carbon headers from defining > + # nonstandard constructs not understood by FSF GCC. > + CPPFLAGS="$CPPFLAGS -D__INTEL_COMPILER=1" > + CPP="${CC-cc} -E -D__INTEL_COMPILER=1" "FSF GCC" seems tautological at best. It seems fragile to test the location of the compiler. Why not test for the actual compiler version?