From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Joe Buehler Newsgroups: gmane.emacs.devel Subject: various bugs in 21.3.50 found during Cygwin port Date: Thu, 05 Dec 2002 11:12:50 -0500 Sender: emacs-devel-admin@gnu.org Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1039105708 2601 80.91.224.249 (5 Dec 2002 16:28:28 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 5 Dec 2002 16:28:28 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18JyrT-0000fi-00 for ; Thu, 05 Dec 2002 17:28:27 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18Jyzg-0004AC-00 for ; Thu, 05 Dec 2002 17:36:56 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18JyjN-0004W1-00; Thu, 05 Dec 2002 11:20:05 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18JyiN-0004Do-00 for emacs-devel@gnu.org; Thu, 05 Dec 2002 11:19:03 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18JycU-00027p-00 for emacs-devel@gnu.org; Thu, 05 Dec 2002 11:13:29 -0500 Original-Received: from main.gmane.org ([80.91.224.249]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18JycT-00026l-00 for emacs-devel@gnu.org; Thu, 05 Dec 2002 11:12:58 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18JycP-0007jH-00 for ; Thu, 05 Dec 2002 17:12:53 +0100 Original-To: emacs-devel@gnu.org X-Injected-Via-Gmane: http://gmane.org/ Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18JycN-0007il-00 for ; Thu, 05 Dec 2002 17:12:51 +0100 Original-Path: not-for-mail Original-Lines: 99 Original-NNTP-Posting-Host: 64.47.34.2 Original-X-Trace: main.gmane.org 1039104771 29675 64.47.34.2 (5 Dec 2002 16:12:51 GMT) Original-X-Complaints-To: usenet@main.gmane.org Original-NNTP-Posting-Date: Thu, 5 Dec 2002 16:12:51 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.2) Gecko/20021126 X-Accept-Language: en-us, en Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:9890 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:9890 Here are some things I found while moving the 21.2 Cygwin patches to 21.3.50 (i.e. the CVS version). 1. There are some places in the Makefiles that run emacs during "make bootstrap" but emacs cannot find the lisp files it needs. There is already a setting for $(emacs) that sets EMACSLOADPATH, so I used that and it worked. 2. x-win.el will not byte-compile when making a non-X11 emacs, because it references functions in fontset.c, which is not compiled when not making an X11 emacs. I am ignoring errors in byte-compiles at the moment (no patch included here). 3. There is an _P macro in pop.c that conflicts with a cygwin header file. 4. LOGNAME is not defined on Cygwin systems. USERNAME is, so I use that if LOGNAME is not set. It is not clear to me why one would want to do "chown $LOGNAME" in the first place, though. Joe Buehler --- lisp/Makefile.in 2002-11-20 02:15:41.000000000 -0500 +++ lisp/Makefile.in 2002-12-04 16:28:45.000000000 -0500 @@ -166,7 +166,7 @@ autoloads: loaddefs.el doit wd=$(lisp); $(setwins); \ echo Directories: $$wins; \ - $(EMACS) $(EMACSOPT) -l autoload --eval '(setq generated-autoload-file "$(lisp)/loaddefs.el")' -f batch-update-autoloads $$wins + $(emacs) -l autoload --eval '(setq generated-autoload-file "$(lisp)/loaddefs.el")' -f batch-update-autoloads $$wins subdirs.el: $(MAKE) $(MFLAGS) update-subdirs --- lisp/Makefile.in 2002-11-20 02:15:41.000000000 -0500 +++ lisp/Makefile.in 2002-12-04 16:28:45.000000000 -0500 @@ -146,12 +146,12 @@ custom-deps: cus-load.el doit wd=$(lisp); $(setwins_almost); \ echo Directories: $$wins; \ - $(EMACS) $(EMACSOPT) -l cus-dep -f custom-make-dependencies $$wins + $(emacs) -l cus-dep -f custom-make-dependencies $$wins finder-data: doit wd=$(lisp); $(setwins_almost); \ echo Directories: $$wins; \ - $(EMACS) $(EMACSOPT) -l finder -f finder-compile-keywords-make-dist $$wins + $(emacs) -l finder -f finder-compile-keywords-make-dist $$wins loaddefs.el: echo ";;; loaddefs.el --- automatically extracted autoloads" >> $@ @@ -270,7 +270,7 @@ # .elc is present. recompile: doit - $(EMACS) $(EMACSOPT) -f batch-byte-recompile-directory $(lisp) + $(emacs) -f batch-byte-recompile-directory $(lisp) # Prepare a bootstrap in the lisp subdirectory. Build loaddefs.el, # because it's not sure it's up-to-date, and if it's not, that might --- lib-src/pop.c 2002-05-17 07:24:02.000000000 -0400 +++ lib-src/pop.c 2002-12-04 20:50:26.000000000 -0500 @@ -119,6 +119,9 @@ #endif #endif +#ifdef _P +#undef _P +#endif #ifndef _P # ifdef __STDC__ # define _P(a) a --- Makefile.in 2002-11-11 04:03:08.000000000 -0500 +++ Makefile.in 2002-12-05 08:09:24.000000000 -0500 @@ -397,7 +397,7 @@ (cd $${dir}; tar -chf - . ) \ | (cd $${dest}; umask 022; \ tar -xvf - && cat > /dev/null) || exit 1; \ - find $${dest} -exec chown $$LOGNAME {} ';' ;\ + find $${dest} -exec chown $${LOGNAME:-$$USERNAME} {} ';' ;\ for subdir in `find $${dest} -type d ! -name RCS ! -name CVS -print` ; do \ chmod a+rx $${subdir} ; \ rm -rf $${subdir}/RCS ; \ @@ -436,7 +436,7 @@ echo "Copying etc/DOC-* to ${docdir} ..." ; \ (cd ./etc; tar -chf - DOC*) \ |(cd ${docdir}; umask 022; tar -xvf - && cat > /dev/null) || exit 1; \ - (cd $(docdir); chown $${LOGNAME} DOC*; chmod a+r DOC*; \ + (cd $(docdir); chown $${LOGNAME:-$$USERNAME} DOC*; chmod a+r DOC*; \ if test "`echo DOC-*`" != "DOC-*"; then rm DOC; fi); \ else true; fi -unset CDPATH; \ @@ -447,7 +447,7 @@ echo "Copying lisp/*.el and lisp/*.elc to ${lispdir} ..." ; \ (cd ${srcdir}/lisp; tar -chf - *.el *.elc) \ |(cd ${lispdir}; umask 022; tar -xvf - && cat > /dev/null) || exit 1; \ - (cd ${lispdir}; find . -exec chown $${LOGNAME} {} ';') ; \ + (cd ${lispdir}; find . -exec chown $${LOGNAME:-$$USERNAME} {} ';') ; \ else true; fi -unset CDPATH; \ thisdir=`/bin/pwd`; \