(minor) Configure should(?) check for 'patch'..

(minor) Configure should(?) check for 'patch'..

[D. Goel]

Greetings

not very sure if this is a bug, but erring on the side of safety by
reporting :)   --->


Was just building from CVS on a new debian box, that did not know the
patch command.  It configured just fine... but 'make bootstrap'
broke-->

,----
| .....
| Loading ange-ftp (source)...
| Loading ediff-help.el (source)...
| Loading ediff-mult.el (source)...
| Loading ediff-wind.el (source)...
| Loading ediff-diff.el (source)...
| Loading ediff-merg.el (source)...
| Loading ediff.el (source)...
| Loading dired (source)...
| Loading info (source)...
| Loading ediff-ptch.el (source)...
| Searching for program: no such file or directory, patch
| make[1]: *** [autoloads] Error 255
| make[1]: Leaving directory `/home/deego/pub/pub/src/emacs/emacs/lisp'
| make: *** [bootstrap-lisp] Error 2
`----

(Shouldn't configure have detected this absence of patch? )



====================================================
bug-headers:
====================================================
Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.1.3 (alphaev56-dec-osf4.0f, X toolkit, Xaw3d scroll bars)
 of 2001-10-30 on shorty.csc.umd.edu
configured using `configure  --prefix=/usr/local/gnu --infodir=/usr/local/gnu/info/emacs-21.1 --with-kerberos --with-x --with-x-toolkit=yes --with-xpm --with-jpeg --with-tiff --with-gif --with-png'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:




Recent input:
d d d ESC O A ESC O A RET d = d d d d d d d d d d d 
d ESC O A d d d ESC O A ESC O A ESC O A ESC O A ESC 
O A ESC O A ESC O A ESC O A ESC O A ESC O A ESC O A 
ESC O A RET y RET RET d RET = d d d d q s ESC < ESC 
x r e p o r t - e m a c s - b u g RET

Recent messages:
Saving /homes/deego/.newsrc...
Wrote /homes/deego/.newsrc
Saving /homes/deego/.newsrc...done
Saving /homes/deego/.newsrc.eld...
Saving file /homes/deego/.newsrc.eld...
Wrote /homes/deego/.newsrc.eld
Saving /homes/deego/.newsrc.eld...done
idledo imminent--> (idledo-deepak-setup)
Mark set
Loading emacsbug...done

Re: (minor) Configure should(?) check for 'patch'..

[Richard Stallman]

Does this fix it?

*** ediff-ptch.el.~1.17.~	Thu Mar 21 04:09:01 2002
--- ediff-ptch.el	Fri Jul  5 03:33:51 2002
***************
*** 85,96 ****
    :group 'ediff-ptch)
  
  (defun ediff-test-patch-utility ()
!   (cond ((zerop (call-process ediff-patch-program nil nil nil "-z." "-b"))
! 	 ;; GNU `patch' v. >= 2.2
! 	 'gnu)
! 	((zerop (call-process ediff-patch-program nil nil nil "-b"))
! 	 'posix)
! 	(t 'traditional)))
  
  (defcustom ediff-backup-specs 
    (let ((type (ediff-test-patch-utility)))
--- 85,98 ----
    :group 'ediff-ptch)
  
  (defun ediff-test-patch-utility ()
!   (condition-case nil
!       (cond ((zerop (call-process ediff-patch-program nil nil nil "-z." "-b"))
! 	     ;; GNU `patch' v. >= 2.2
! 	     'gnu)
! 	    ((zerop (call-process ediff-patch-program nil nil nil "-b"))
! 	     'posix)
! 	    (t 'traditional))
!     (file-error nil)))
  
  (defcustom ediff-backup-specs 
    (let ((type (ediff-test-patch-utility)))

Re: (minor) Configure should(?) check for 'patch'..

[D. Goel]

> Does this fix it?

Your patch for ediff-patch reg. the absence of patch did fix the
problem.  Thanks for the patch RMS. :)