From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Redisplay slower in Emacs 28 than Emacs 27 Date: Mon, 07 Dec 2020 18:45:28 +0000 Message-ID: References: <877dptiro7.fsf@gnus.org> <87pn3lhcdd.fsf@gnus.org> <878sa9hbe2.fsf@gnus.org> <877dptfvae.fsf@gnus.org> <83czzl8qwu.fsf@gnu.org> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2286"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 07 19:48:03 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmLYI-0000TX-5n for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 19:48:02 +0100 Original-Received: from localhost ([::1]:36810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmLYH-00046L-6n for ged-emacs-devel@m.gmane-mx.org; Mon, 07 Dec 2020 13:48:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmLW2-0003Ef-4A for emacs-devel@gnu.org; Mon, 07 Dec 2020 13:45:43 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:51973) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmLVy-00076E-Jp; Mon, 07 Dec 2020 13:45:41 -0500 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 0B7IjVwj026453 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 7 Dec 2020 18:45:31 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 0B7IjUq2017815; Mon, 7 Dec 2020 18:45:30 GMT In-Reply-To: <83czzl8qwu.fsf@gnu.org> Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:260507 Archived-At: >>>> No, with the tests were ran with emacs -Q. I forgot to mention this, >>>> it was too obvious to me. >>> >>> But "emacs -Q" does show images in the tool bar. :-) (Very small >>> ones, though.) >> >> Yes, and as you probably understood, by "does not load any image" I >> meant "in a buffer"... ;-) > > You asked why Emacs messes with the image cache although there are no > images in the buffer, > No, I did not ask this. > > and the answer is probably that Emacs doesn't mess with images in the > buffer, it messes with images elsewhere on display. Depending on > whether your build uses GTK, this could happen each time Emacs scrolls > the window, because it then examines the tool bar in order to decide > whether it needs to be redrawn. > I don't know, that's possible indeed. In the other thread I referenced in my initial message, you wrote: "If someone can afford [to search the history to find the source of the slowdown], it would be nice to know. Assuming a single commit causes it, that is (it could be several commits instead, each one slowing down Emacs by a few percents)." I did exactly that, no more, no less. That being said, it seems to me that this slowdown is avoidable. Lars considers that the minor modification he made should not have changed anything.