From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Feature branches review please Date: Thu, 05 Nov 2020 21:19:27 +0000 Message-ID: References: <20201104161200.tyeo2r5jibdahukb.ref@Ergus> <20201104161200.tyeo2r5jibdahukb@Ergus> <234bba7f-fd5c-ed39-8a5e-8a6ce3125bf1@inventati.org> <20201105210915.3rl3z6jngsrzgbwv@Ergus> Reply-To: Gregory Heytings Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2915"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Alpine 2.22 (NEB 394 2020-01-19) Cc: Jean Louis , Manuel Uberti , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 05 22:20:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kamgS-0000f8-Ur for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 22:20:40 +0100 Original-Received: from localhost ([::1]:32788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kamgS-00020T-0c for ged-emacs-devel@m.gmane-mx.org; Thu, 05 Nov 2020 16:20:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kamfU-0001WY-FY for emacs-devel@gnu.org; Thu, 05 Nov 2020 16:19:41 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:58941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kamfR-0004zM-0z for emacs-devel@gnu.org; Thu, 05 Nov 2020 16:19:40 -0500 Original-Received: from sdf.org (IDENT:ghe@faeroes.freeshell.org [205.166.94.9]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 0A5LJTMD028184 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 5 Nov 2020 21:19:30 GMT Original-Received: (from ghe@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 0A5LJvxw027003; Thu, 5 Nov 2020 21:19:58 GMT In-Reply-To: <20201105210915.3rl3z6jngsrzgbwv@Ergus> Received-SPF: pass client-ip=205.166.94.24; envelope-from=ghe@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 15:39:08 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258760 Archived-At: >> As I said earlier in this thread, you can have icomplete-vertical >> without using that branch, with the master branch you only need to >> `(setq icomplete-separator "\n")'. >> >> If you want a more robust solution however (neither the above nor the >> branch are always correct), > > In which case the branch is not correct? > This has been discussed at length earlier: it is in practice impossible to calculate the height of the minibuffer, and to calculate the size of the completion candidates list to insert in the minibuffer. Yet you need to do both to have a correct solution with the approach of the branch.