all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Gregory Heytings via "Emacs development discussions." <emacs-devel@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: juri@linkov.net, acm@muc.de, monnier@iro.umontreal.ca,
	emacs-devel@gnu.org
Subject: Re: New multi-command facility displays in the wrong echo area.
Date: Mon, 12 Oct 2020 16:31:27 +0000	[thread overview]
Message-ID: <alpine.NEB.2.22.394.2010121808250453.19729@sdf.lonestar.org> (raw)
In-Reply-To: <83mu0r3030.fsf@gnu.org>


>>> In any case, I think the condition could be relaxed: we only care 
>>> about how much space is left from the minibuffer text's end till the 
>>> end of the screen line, so "if minibuffer text size modulo 
>>> window-width is less than something" would be better, I think.  E.g., 
>>> if you use 70 instead of 67 in your recipe, the problem is mostly 
>>> gone.
>>
>> The condition could be refined indeed, but the modulo operation you 
>> propose would not work with variable pitch faces.
>
> It will, if the calculation is done in pixels.  The APIs you mentioned 
> can return pixels instead of columns, or there are alternatives which 
> do.
>

Indeed, this would also work:

(< (mod (car (window-text-pixel-size (active-minibuffer-window))) (window-text-width (active-minibuffer-window) t))
    (/ (car (window-text-pixel-size (active-minibuffer-window))) 2))

But going in that direction means that one should also take the current 
window height into account: if the miniwindow is tall enough, the above 
condition could be nil even though there would be enough room to display 
the message.

>> See above.  I've now read that bug thread, and I'm not at all convinced 
>> that the chosen solution was TRT, quite the contrary.
>
> We can discuss other solutions, of course.  However, significant changes 
> will have to wait for Emacs 28.
>

Ouch.  So this last-minute change will last for several years?

>> It seems to me that being wiser would mean taking the time to evaluate 
>> a proposed solution, instead of rejecting it outright based on a gut 
>> feeling.
>
> Please give me the credit of having done so.  I've given you no reason 
> to believe otherwise; disagreement doesn't imply incompetence or 
> sloppiness on my part.  It is simply unfair and even rude to suggest 
> that.
>

I do not suggest anything like that.  But I'm a doubting Thomas, and I 
can't give you this credit until I see a recipe that would convincingly 
demonstrate a potential problem that my proposed solution would create. 
Especially given I explained that this solution is only _at the moment_ 
the best solution, for earlier versions and the current version of Emacs, 
until a better solution is implemented.



  reply	other threads:[~2020-10-12 16:31 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 16:34 New multi-command facility displays in the wrong echo area Alan Mackenzie
2020-10-09 19:47 ` Stefan Monnier
2020-10-09 20:38   ` Alan Mackenzie
2020-10-09 22:12     ` Stefan Monnier
2020-10-09 22:56       ` Drew Adams
2020-10-10  6:52     ` Eli Zaretskii
2020-10-10 10:32       ` Alan Mackenzie
2020-10-10 11:13         ` Eli Zaretskii
2020-10-10 12:36           ` Gregory Heytings via Emacs development discussions.
2020-10-10 12:44           ` Alan Mackenzie
2020-10-10 12:50             ` Eli Zaretskii
2020-10-10 13:00               ` Eli Zaretskii
2020-10-10 20:30                 ` Gregory Heytings via Emacs development discussions.
2020-10-11 14:38                   ` Eli Zaretskii
2020-10-12  9:12                     ` Gregory Heytings via Emacs development discussions.
2020-10-12 12:00                       ` Alan Mackenzie
2020-10-12 12:18                         ` Gregory Heytings via Emacs development discussions.
2020-10-12 14:37                       ` Eli Zaretskii
2020-10-12 15:41                         ` Gregory Heytings via Emacs development discussions.
2020-10-12 16:01                           ` Eli Zaretskii
2020-10-12 16:31                             ` Gregory Heytings via Emacs development discussions. [this message]
2020-10-12 17:20                               ` Eli Zaretskii
2020-10-12 21:06                                 ` Gregory Heytings via Emacs development discussions.
2020-10-13 14:03                                   ` Eli Zaretskii
2020-10-13 19:27                                     ` Gregory Heytings via Emacs development discussions.
2020-10-13 21:22                                       ` Gregory Heytings via Emacs development discussions.
2020-10-12 17:12                         ` Drew Adams
2020-10-12 17:34                           ` Eli Zaretskii
2020-10-12 19:46                         ` Juri Linkov
2020-10-13  2:25                           ` Eli Zaretskii
2020-10-14 20:44                       ` Gregory Heytings via Emacs development discussions.
     [not found]                         ` <1cd65040-f7ad-4613-b3fb-7cfa62bb0488@default>
2020-10-14 22:15                           ` Gregory Heytings via Emacs development discussions.
2020-10-14 22:51                         ` Stefan Monnier
2020-10-16  7:19                           ` Eli Zaretskii
2020-10-16  7:19                         ` Eli Zaretskii
2020-10-10 13:03             ` Gregory Heytings via Emacs development discussions.
2020-10-10 13:47               ` Alan Mackenzie
2020-10-10 20:20                 ` Gregory Heytings via Emacs development discussions.
2020-10-09 21:14   ` Gregory Heytings via Emacs development discussions.
2020-10-09 21:48     ` Gregory Heytings via Emacs development discussions.
2020-10-10 10:15       ` Alan Mackenzie
2020-10-10 13:44         ` Stefan Monnier
     [not found] <<20201009163445.GB4027@ACM>
     [not found] ` <<jwv362nkwss.fsf-monnier+emacs@gnu.org>
     [not found]   ` <<20201009203810.GC4027@ACM>
     [not found]     ` <<83imbi609a.fsf@gnu.org>
2020-10-10 16:11       ` Drew Adams
2020-10-10 20:40         ` Gregory Heytings via Emacs development discussions.
2020-10-11  0:59           ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.NEB.2.22.394.2010121808250453.19729@sdf.lonestar.org \
    --to=emacs-devel@gnu.org \
    --cc=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=ghe@sdf.org \
    --cc=juri@linkov.net \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.