From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#22694: 25.0.91; dired-mark-files-containing-regexp read file disk Date: Sun, 10 Apr 2016 16:02:59 +0900 (JST) Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: ger.gmane.org 1460271616 23756 80.91.229.3 (10 Apr 2016 07:00:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 Apr 2016 07:00:16 +0000 (UTC) To: 22694@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 10 09:00:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ap9Lu-0003A6-Hz for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Apr 2016 09:00:10 +0200 Original-Received: from localhost ([::1]:33991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ap9Lt-0002qR-Pq for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Apr 2016 03:00:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ap9Lp-0002n9-Sz for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2016 03:00:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ap9Lm-0001iT-Nz for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2016 03:00:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44171) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ap9Lm-0001iM-Jk for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2016 03:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ap9Lm-0007BA-B4 for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2016 03:00:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Apr 2016 07:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22694 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22694-submit@debbugs.gnu.org id=B22694.146027159127549 (code B ref 22694); Sun, 10 Apr 2016 07:00:02 +0000 Original-Received: (at 22694) by debbugs.gnu.org; 10 Apr 2016 06:59:51 +0000 Original-Received: from localhost ([127.0.0.1]:56508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ap9Lb-0007AG-IH for submit@debbugs.gnu.org; Sun, 10 Apr 2016 02:59:51 -0400 Original-Received: from calancha-ilc.kek.jp ([130.87.234.234]:57815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ap9LZ-0007A1-NQ for 22694@debbugs.gnu.org; Sun, 10 Apr 2016 02:59:50 -0400 Original-Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id 624B45959; Sun, 10 Apr 2016 16:03:00 +0900 (JST) Original-Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 0241CC83 for <22694@debbugs.gnu.org>; Sun, 10 Apr 2016 16:03:00 +0900 (JST) X-X-Sender: calancha@calancha-ilc.kek.jp User-Agent: Alpine 2.20 (LRH 67 2015-01-07) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116300 Archived-At: Let me argue more about why i found more useful if we change the current behaviour: Let's suppose the following case: 1) An user submit several hundred of jobs to a batch server. 2) The output consist of just log files (1 per job) which are written under the submission directory until the jobs succeded of fail. When the job fails, the logfile contains the word 'aborting'. 3) To resubmit the failed jobs, the user may put all logfiles together in a dired buffer using `find-name-dired'. From time to time, he/she call `dired-mark-files-containing-regexp' using 'aborting' as regexp: from this, he/she obtain directly the list of failed jobs... 4) ...But if the user has opened some of the logfiles from failed jobs, the word 'aborting' may not be in the buffer (the user need to revert it first), so the list of failed jobs at 3) will not be exhaustive. This behaviour is not consistent with the doc. string of the function: "Mark all files with contents containing REGEXP for use in later commands. A prefix argument means to unmark them instead. `.' and `..' are never marked." - As mentioned in 4) this function may not mark all files containing REGEXP and this is not obvious unless you read the source code. - Just from the doc. string i would expect this function behaves as in the patch within this thread. - Using the buffer when available seems like an optimization but in fact it's not because it may produce different results. I suggest in order of preference: A) Apply the patch in this thread: then, the funcion behaves as described in the doc. string. B) Modify the doc. string to account for the case when there are buffers visiting the files.