all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tino Calancha <f92capac@gmail.com>
To: 22694@debbugs.gnu.org
Subject: bug#22694: 25.0.91; dired-mark-files-containing-regexp read file disk
Date: Sun, 10 Apr 2016 16:02:59 +0900 (JST)	[thread overview]
Message-ID: <alpine.LRH.2.20.1604101553280.27325@calancha-ilc.kek.jp> (raw)
In-Reply-To: <alpine.LRH.2.20.1602162134160.6276@calancha-ilc.kek.jp>


Let me argue more about why i found more useful if we change the current 
behaviour:

Let's suppose the following case:

1) An user submit several hundred of jobs to a batch server.

2) The output consist of just log files (1 per job) which are written
    under the submission directory until the jobs succeded of fail.
    When the job fails, the logfile contains the word 'aborting'.

3) To resubmit the failed jobs, the user may put all logfiles together in a
    dired buffer using `find-name-dired'.  From time to time, he/she call
    `dired-mark-files-containing-regexp' using 'aborting' as regexp: from this,
    he/she obtain directly the list of failed jobs...

4) ...But if the user has opened some of the logfiles from failed jobs, the word
    'aborting' may not be in the buffer (the user need to revert it first), so the
    list of failed jobs at 3) will not be exhaustive.  This behaviour is not
    consistent with the doc. string of the function:

"Mark all files with contents containing REGEXP for use in later commands.
A prefix argument means to unmark them instead.
`.' and `..' are never marked."

  - As mentioned in 4) this function may not mark all files containing
    REGEXP and this is not obvious unless you read the source code.

  - Just from the doc. string i would expect this function behaves as in
    the patch within this thread.

  - Using the buffer when available seems like an optimization but
    in fact it's not because it may produce different results.

  I suggest in order of preference:

A) Apply the patch in this thread: then, the funcion behaves as described in the doc. string.

B) Modify the doc. string to account for the case when there are buffers visiting the files.






  parent reply	other threads:[~2016-04-10  7:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-16 12:47 bug#22694: 25.0.91; dired-mark-files-containing-regexp read file disk Tino Calancha
2016-02-16 16:05 ` Eli Zaretskii
2016-02-17 14:07   ` Tino Calancha
2016-02-24  9:31 ` Tino Calancha
2016-04-10  7:02 ` Tino Calancha [this message]
2016-04-20 14:55   ` Eli Zaretskii
2016-04-20 15:31     ` Tino Calancha
2016-04-20 15:48       ` Eli Zaretskii
2016-06-26 15:32         ` Tino Calancha
2016-07-09 11:07           ` Eli Zaretskii
2016-07-11  5:48             ` Tino Calancha
2016-07-11  5:49 ` bug#22694: (no subject) Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.20.1604101553280.27325@calancha-ilc.kek.jp \
    --to=f92capac@gmail.com \
    --cc=22694@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.