From: Tino Calancha <f92capac@gmail.com>
To: 21663@debbugs.gnu.org
Cc: Tino Calancha <f92capac@gmail.com>
Subject: bug#21663: 25.0.50; isearch-edit-string dont resume multi-isearch-files
Date: Tue, 13 Oct 2015 10:35:31 +0900 (JST) [thread overview]
Message-ID: <alpine.LRH.2.20.1510131029510.27198@calancha-ilc.kek.jp> (raw)
In-Reply-To: <87io6b6dva.fsf@mail.linkov.net>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
> I wonder why ‘isearch-mode-end-hook-quit’ is not initialized as
> ‘(and nopush edit)’ in the first place? If it was so, then
> you could just check for it in ‘multi-isearch-end’.
My understanding about that variable (i may be wrong) is that is should
be non nil just when the user quit the search with
C-g
we dont want this variable being non nil in the case of editing the string
with the idea to resume the same kind of search.
> have you tried to re-initialize multi-isearch on resuming isearch
> after exiting from the minibuffer? (This could be achieved by
> remembering its state variables).
I like your proposal: this way is more consistent with the original code.
See attached new patch.
[-- Attachment #2: Type: text/plain, Size: 993 bytes --]
diff --git a/lisp/isearch.el b/lisp/isearch.el
index 4fc9b38..74b1250 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -1242,6 +1242,14 @@ with-isearch-suspended
(isearch-adjusted isearch-adjusted)
(isearch-yank-flag isearch-yank-flag)
(isearch-error isearch-error)
+ ;; multi isearch variables
+ (multi-isearch-file-list multi-isearch-file-list)
+ (multi-isearch-buffer-list multi-isearch-buffer-list)
+ (multi-isearch-next-buffer-current-function multi-isearch-next-buffer-current-function)
+ (multi-isearch-current-buffer multi-isearch-current-buffer)
+ (isearch-push-state-function isearch-push-state-function)
+ (isearch-wrap-function isearch-wrap-function)
+ (isearch-search-fun-function isearch-search-fun-function)
;;; Don't bind this. We want isearch-search, below, to set it.
;;; And the old value won't matter after that.
;;; (isearch-other-end isearch-other-end)
next prev parent reply other threads:[~2015-10-13 1:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-11 4:57 bug#21663: Subject: 25.0.50; isearch-edit-string dont resume multi isearches Tino Calancha
[not found] ` <handler.21663.B.144453929427612.ack@debbugs.gnu.org>
2015-10-12 15:25 ` bug#21663: 25.0.50; isearch-edit-string dont resume multi-isearch-files Tino Calancha
2015-10-12 20:17 ` Juri Linkov
2015-10-13 1:35 ` Tino Calancha [this message]
2015-10-13 5:18 ` bug#21663: 25.0.50; isearch-edit-string dont resume multi isearches Tino Calancha
2015-10-13 22:04 ` Juri Linkov
2015-10-14 6:48 ` Tino Calancha
2015-10-14 16:17 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1510131029510.27198@calancha-ilc.kek.jp \
--to=f92capac@gmail.com \
--cc=21663@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.