* bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p'
@ 2015-09-01 1:47 Tino Calancha
2015-09-01 2:39 ` bug#21390: Corrected patch Tino Calancha
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Tino Calancha @ 2015-09-01 1:47 UTC (permalink / raw)
To: 21390; +Cc: C. Calancha
[-- Attachment #1: Type: text/plain, Size: 2302 bytes --]
Predicate `buffer-or-string-p' is declared but definition is missing in:
emacs-24.5/src/data.c
In GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23)
of 2015-08-30 on calancha-ilc.kek.jp
System Description: Scientific Linux release 6.7 (Carbon)
Configured using:
`configure --with-gif=no'
Important settings:
value of $LANG: en_US.utf8
value of $XMODIFIERS: @im=none
locale-coding-system: utf-8-unix
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Load-path shadows:
None found.
Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils xterm time-date tooltip electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)
Memory information:
((conses 16 75908 4118)
(symbols 48 17587 0)
(miscs 40 31 88)
(strings 32 9018 4405)
(string-bytes 1 248942)
(vectors 16 7095)
(vector-slots 8 341333 33198)
(floats 8 65 260)
(intervals 56 156 0)
(buffers 960 11)
(heap 1024 22077 2012))
[-- Attachment #2: Type: text/plain, Size: 569 bytes --]
--- data.c 2015-09-01 10:27:31.000000000 +0900
+++ data_patched.c 2015-09-01 10:27:48.000000000 +0900
@@ -458,6 +458,15 @@
return Qnil;
}
+DEFUN ("buffer-or-string-p", Fbuffer_or_string_p, Sbuffer_or_string_p, 1, 1, 0,
+ doc: /* Return t if OBJECT is an an editor buffer or a string.*/)
+ (Lisp_Object object)
+{
+ if ( BUFFERP (object) || STRINGP (object))
+ return Qt;
+ return Qnil;
+}
+
DEFUN ("markerp", Fmarkerp, Smarkerp, 1, 1, 0,
doc: /* Return t if OBJECT is a marker (editor pointer). */)
(Lisp_Object object)
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#21390: Corrected patch
2015-09-01 1:47 bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Tino Calancha
@ 2015-09-01 2:39 ` Tino Calancha
2015-09-01 15:45 ` bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Glenn Morris
2017-05-18 4:06 ` Tino Calancha
2 siblings, 0 replies; 5+ messages in thread
From: Tino Calancha @ 2015-09-01 2:39 UTC (permalink / raw)
To: 21390; +Cc: C. Calancha
[-- Attachment #1: Type: text/plain, Size: 86 bytes --]
My previous patch would not work. I attach a corrected version which
fix the issue.
[-- Attachment #2: Type: text/plain, Size: 790 bytes --]
--- data.c 2015-09-01 10:27:31.000000000 +0900
+++ data_patched.c 2015-09-01 11:31:41.000000000 +0900
@@ -458,6 +458,15 @@
return Qnil;
}
+DEFUN ("buffer-or-string-p", Fbuffer_or_string_p, Sbuffer_or_string_p, 1, 1, 0,
+ doc: /* Return t if OBJECT is an an editor buffer or a string.*/)
+ (Lisp_Object object)
+{
+ if ( BUFFERP (object) || STRINGP (object))
+ return Qt;
+ return Qnil;
+}
+
DEFUN ("markerp", Fmarkerp, Smarkerp, 1, 1, 0,
doc: /* Return t if OBJECT is a marker (editor pointer). */)
(Lisp_Object object)
@@ -3595,6 +3604,7 @@
defsubr (&Sarrayp);
defsubr (&Ssequencep);
defsubr (&Sbufferp);
+ defsubr (&Sbuffer_or_string_p);
defsubr (&Smarkerp);
defsubr (&Ssubrp);
defsubr (&Sbyte_code_function_p);
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p'
2015-09-01 1:47 bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Tino Calancha
2015-09-01 2:39 ` bug#21390: Corrected patch Tino Calancha
@ 2015-09-01 15:45 ` Glenn Morris
2015-09-02 2:07 ` Constantino Calancha
2017-05-18 4:06 ` Tino Calancha
2 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2015-09-01 15:45 UTC (permalink / raw)
To: Tino Calancha; +Cc: 21390
Tino Calancha wrote:
> Predicate `buffer-or-string-p' is declared but definition is missing in:
> emacs-24.5/src/data.c
I guess you are referring to the fact that src/data.c contains
DEFSYM (Qbuffer_or_string_p, "buffer-or-string-p")
This is used in CHECK_STRING_OR_BUFFER in textprop.c.
The simple presence of the DEFSYM is not by itself motivation for the
addition of a "buffer-or-string-p" predicate.
If you think such a thing is needed, you need to eg show how many places
in the current lisp sources would use it. And then if added it needs to
be documented too.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p'
2015-09-01 15:45 ` bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Glenn Morris
@ 2015-09-02 2:07 ` Constantino Calancha
0 siblings, 0 replies; 5+ messages in thread
From: Constantino Calancha @ 2015-09-02 2:07 UTC (permalink / raw)
To: Glenn Morris; +Cc: 21390@debbugs.gnu.org
Hi Glenn,
i dont think is needed i just find more natural to be defined than not.
Its also elegant.
There are two files that may use that predicate:
simple.el
2856: (not (or (bufferp output-buffer) (stringp
output-buffer))))
3118: (not (or (bufferp output-buffer) (stringp output-buffer)))))
gnus-art.el:
2800: ((not (or (bufferp (car handle)) (stringp (car handle)))))
On Wed, 02 Sep 2015 00:45:04 +0900, Glenn Morris <rgm@gnu.org> wrote:
> Tino Calancha wrote:
>
>> Predicate `buffer-or-string-p' is declared but definition is missing in:
>> emacs-24.5/src/data.c
>
> I guess you are referring to the fact that src/data.c contains
>
> DEFSYM (Qbuffer_or_string_p, "buffer-or-string-p")
>
> This is used in CHECK_STRING_OR_BUFFER in textprop.c.
> The simple presence of the DEFSYM is not by itself motivation for the
> addition of a "buffer-or-string-p" predicate.
>
> If you think such a thing is needed, you need to eg show how many places
> in the current lisp sources would use it. And then if added it needs to
> be documented too.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p'
2015-09-01 1:47 bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Tino Calancha
2015-09-01 2:39 ` bug#21390: Corrected patch Tino Calancha
2015-09-01 15:45 ` bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Glenn Morris
@ 2017-05-18 4:06 ` Tino Calancha
2 siblings, 0 replies; 5+ messages in thread
From: Tino Calancha @ 2017-05-18 4:06 UTC (permalink / raw)
To: 21390-done
> Predicate `buffer-or-string-p' is declared but definition is missing in:
> emacs-24.5/src/data.c
It seems not very attractive proposal, so i am closing the report.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-05-18 4:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-01 1:47 bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Tino Calancha
2015-09-01 2:39 ` bug#21390: Corrected patch Tino Calancha
2015-09-01 15:45 ` bug#21390: 24.5; Missing definition for predicate `buffer-or-string-p' Glenn Morris
2015-09-02 2:07 ` Constantino Calancha
2017-05-18 4:06 ` Tino Calancha
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.