Warning in replace.el

Warning in replace.el

[Lars Ingebrigtsen]

Compiling Emacs now, I get

In perform-replace:
replace.el:2714:35:Warning: assignment to free variable
    `last-replacement-replaced'

It's this code:

                                  search-string-replaced search-string
                                  last-replacement-replaced last-replacement
                                  last-was-act-and-show nil)

But setting last-replacement-replaced is the only place this variable is
mentioned.

Tino?  It's from this commit:

commit 30c4f35a6fc8a6507930923766c3126ac1c2063f
Author: Tino Calancha <tino.calancha@gmail.com>
Date:   Mon Sep 9 08:21:18 2019 +0200

    query-replace-regexp undo: Update next-replacement after undo
    
    * lisp/replace.el (perform-replace):
    Rename the local binding to not shadow next-replacement.
    Update next-replacement after undo (Bug#37287).
    
    * test/lisp/replace-tests.el (query-replace-undo-bug37287): Add test.
    (query-replace-undo-bug37073): Tweak this test.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: Warning in replace.el

[Tino Calancha]

On Tue, 17 Sep 2019, Lars Ingebrigtsen wrote:

> Compiling Emacs now, I get
>
> In perform-replace:
> replace.el:2714:35:Warning: assignment to free variable
>    `last-replacement-replaced'
>
> It's this code:
>
>                                  search-string-replaced search-string
>                                  last-replacement-replaced last-replacement
>                                  last-was-act-and-show nil)
>
> But setting last-replacement-replaced is the only place this variable is
> mentioned.


last-replacement-replaced  ---> next-replacement-replaced

I'll fix it in the evening.
Thank you