From: Arni Magnusson <arnima@hafro.is>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 14732@debbugs.gnu.org
Subject: bug#14732: Package dos-mode for ELPA
Date: Mon, 5 Aug 2013 02:20:41 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.03.1308050107430.54935@hafro.is> (raw)
In-Reply-To: <jwv4nb52kgd.fsf-monnier+emacs@gnu.org>
Hi Stefan,
Do you think that `dos-mode' could perhaps make it to Emacs core (i.e.
lisp/progmodes) instead of becoming an optional ELPA download?
The current `bat-generic-mode' provides surprisingly limited
syntax-highlighting, and earlier we discussed that instead of submitting a
patch for the generic mode, it would be better if I rewrite it as a
derived mode. While doing that, my design goal was to write a minimalistic
replacement of `bat-generic-mode' with the following improvements:
- highlighting of more commands: at attrib color date dir doskey endlocal
erase fc find mkdir more move popd pushd rmdir setlocal sort time title
type xcopy
- highlighting of more control flow keywords: cmd defined else equ exit
geq gtr in leq lss neq
- highlighting of called script: call foo
- highlighting of %%variable: for %%X in (bark meow) do echo %%X
- highlighting of defined variable: if defined VAR
I studied other code inside progmodes to use a similar style, both
internally and in the user interface, which has a menu with a few basic
but useful commands.
At 6333 bytes, I think it is a substantial improvement in Emacs support
for Dos scripts. I believe it would make many Emacs users happy to have
`auto-mode-alist' turn on `dos-mode' for the "bat" filename extension.
Actually, the net increase in code should be less than 6333 bytes, because
almost all remnants of `bat-generic-mode' could be deleted.
An analogous improvement was when `js-mode' replaced the old
`javascript-generic-mode'.
I would of course be fine with `dos-mode' being an ELPA package (my
initial proposal), but I just think Emacs should out-of-the-box have
slightly better support for editing Dos scripts. They are an unpopular but
necessary part of many free software projects, and developers would
appreciate to at least see the common Dos keywords colored.
Perhaps ELPA could be a stepping stone towards the venerable progmodes? A
kind of a review process and a general call for a SMIE patch? In that
case, we should probably change the header comment "This file is part of
GNU Emacs". Just to be explicit, I'm happy to have the Emacs developers
make any changes to the proposed
http://www.emacswiki.org/emacs/download/dos.el.
All the best,
Arni
P.S. I have received and signed the copyright assignment, and mailed it to
the Assignment Administrator (D. Robertson) on 25 July.
On Sun, 4 Aug 2013, Stefan Monnier wrote:
> [ Slowly going back over some of that email backlog. ]
>
>> http://www.emacswiki.org/emacs/download/dos.el
>
> Thanks you. The code looks ready for ELPA (I'd use call-process a bit
> more often than shell-command, to avoid quoting issues, tho).
>
> It would be nice to add some SMIE support to it.
>
>>> However, to accept such changes into Emacs, you will need to do legal
>>> paperwork
>>
>> Great. I have signed an FSF agreement regarding Texinfo, and I'm more
>> than willing to do the same for Emacs.
>
> Have you started this process? If not, then please fill the form below
> and email it as instructed so the FSF can send you the relevant
> paperwork to sign.
>
>
> Stefan
>
next prev parent reply other threads:[~2013-08-05 2:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 16:15 bug#14732: Package dos-mode for ELPA Arni Magnusson
2013-06-27 17:40 ` Eli Zaretskii
2013-07-01 1:00 ` Arni Magnusson
2013-07-01 10:44 ` Arni Magnusson
2013-07-01 16:50 ` Eli Zaretskii
2013-07-01 23:30 ` Stefan Monnier
2013-07-02 0:12 ` Arni Magnusson
2013-08-05 0:16 ` Stefan Monnier
2013-08-05 2:20 ` Arni Magnusson [this message]
2013-08-06 21:00 ` Stefan Monnier
2013-08-07 15:54 ` Stefan Monnier
2013-08-07 16:14 ` Eli Zaretskii
2013-08-07 17:27 ` Stefan Monnier
2013-08-07 17:26 ` Juanma Barranquero
2013-08-07 18:11 ` Stefan Monnier
2013-08-07 19:18 ` Eli Zaretskii
2013-08-07 19:49 ` Juanma Barranquero
2013-08-07 21:12 ` Stefan Monnier
2013-08-08 2:45 ` Eli Zaretskii
2013-08-08 3:47 ` Stefan Monnier
2013-08-08 17:05 ` Eli Zaretskii
2013-08-08 17:28 ` Glenn Morris
2013-08-08 17:52 ` Eli Zaretskii
2013-08-08 17:48 ` Stefan Monnier
2013-08-07 19:39 ` Juanma Barranquero
2013-08-07 21:12 ` Stefan Monnier
2013-08-07 21:19 ` Juanma Barranquero
2013-07-07 12:34 ` Arni Magnusson
2013-07-10 0:43 ` Arni Magnusson
2013-08-08 3:40 ` Glenn Morris
2013-08-08 16:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.03.1308050107430.54935@hafro.is \
--to=arnima@hafro.is \
--cc=14732@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.