From: john <jpff@codemist.co.uk>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Falling to build
Date: Wed, 1 Jan 2020 17:38:04 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.21.2001011735500.4281@snout.codemist.co.uk> (raw)
In-Reply-To: <83imlvjdlt.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
Yes; only oddity i saw was a message abaout an agresive macro -- but it
went past too quickly fr me to capture te details.
Anyway no errors
==John ff
On Wed, 1 Jan 2020, Eli Zaretskii wrote:
>> Date: Wed, 1 Jan 2020 16:34:05 +0000
>> From: John <jpff@codemist.co.uk>
>>
>> This morning all OK in building on openSuSe x86_64 until this happens
>>
>> CC xfns.o
>> xfns.c: In function ‘Fx_display_monitor_attributes_list’:
>> xfns.c:5072:30: warning: implicit declaration of function ‘x_get_net_workarea’; did you mean ‘x_set_undecorated’? [-Wimplicit-function-declaration]
>> if (i == primary_monitor && x_get_net_workarea (dpyinfo, &workarea_r))
>> ^~~~~~~~~~~~~~~~~~
>> x_set_undecorated
>> xfns.c:5072:30: warning: nested extern declaration of ‘x_get_net_workarea’ [-Wnested-externs]
>
> Does the patch below fix this?
>
> diff --git a/src/xfns.c b/src/xfns.c
> index b94666d..d0d5d39 100644
> --- a/src/xfns.c
> +++ b/src/xfns.c
> @@ -4572,7 +4572,7 @@ DEFUN ("x-display-save-under", Fx_display_save_under,
> return Qnil;
> }
>
> -#ifndef USE_GTK
> +#if !defined USE_GTK || !defined HAVE_GTK3
>
> /* Store the geometry of the workarea on display DPYINFO into *RECT.
> Return false if and only if the workarea information cannot be
>
next prev parent reply other threads:[~2020-01-01 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-01 16:34 Falling to build John
2020-01-01 17:22 ` Eli Zaretskii
2020-01-01 17:38 ` john [this message]
2020-01-01 17:56 ` Eli Zaretskii
2020-01-01 19:05 ` Sven Joachim
2020-01-01 19:17 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2020-01-01 16:35 John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2001011735500.4281@snout.codemist.co.uk \
--to=jpff@codemist.co.uk \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.