From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michelangelo Rodriguez Newsgroups: gmane.emacs.devel Subject: Re: Package proposal: greader, an audio emacs reader for blind and dislexic people Date: Tue, 5 Feb 2019 06:18:24 +0100 (CET) Message-ID: References: <87tvhpx0fr.fsf@web.de> <87ftt9wpfh.fsf@web.de> <87ftt36sww.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="157805"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Alpine 2.21 (DEB 202 2017-01-01) Cc: Michelangelo Rodriguez , emacs devel To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 05 06:34:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqtNq-000ev1-FI for ged-emacs-devel@m.gmane.org; Tue, 05 Feb 2019 06:34:58 +0100 Original-Received: from localhost ([127.0.0.1]:54594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqtNp-0003aE-Gh for ged-emacs-devel@m.gmane.org; Tue, 05 Feb 2019 00:34:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqtMx-0003S5-Vl for emacs-devel@gnu.org; Tue, 05 Feb 2019 00:34:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqt8C-0000h5-T9 for emacs-devel@gnu.org; Tue, 05 Feb 2019 00:18:49 -0500 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:35395) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqt8C-0000P4-N3 for emacs-devel@gnu.org; Tue, 05 Feb 2019 00:18:48 -0500 Original-Received: by mail-wr1-x430.google.com with SMTP id z18so1455291wrh.2 for ; Mon, 04 Feb 2019 21:18:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=7VUz6cxocpSvLF4BR735ZLrFpHjOf0m2nLIZzgeksmM=; b=PmUwMOZm+e3ZFwEXaOqG1YClcdEH/fZFJBBYr4poZYwOf5GrdPxJoGcmN3c/vNs0/I 1+L6cIw9ytx4DEShLjThHT3Cwml7Qj3yRkglsItYJjJd/uAMHT/bwLuyI32AcWM6Kb1t BPy+ysf/kqApGKoGdJMAeRzOh7NfiJHBPsjD+0atl2ZBLY2c92EoFN/2RRl+F4ZjXsZD WnC3UNPdagjP0IVg/PBSH7aopchPYSiNiuNgR/RyOSDTDtWlNRNP4MdCmnjrRWzYSH52 Thqr5lp4mqjzVBLDv88Of3Su6XPZxCpzW414Ut1QBzVP7d5VUNis/jtXeoRWvIs/r08o ow7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=7VUz6cxocpSvLF4BR735ZLrFpHjOf0m2nLIZzgeksmM=; b=SYP/sSk9hHUJqqx2Zb1ydaTBHJ0ylJhnIHrchfBUqIGMBCJPAovrfXe8Fz+lgrJ4j5 +rxpVrpMw2Z4SiVlLGFDgWHOrSthc1qxBGkUSql+qpeOc67XOux679ZVtfICb0LOrK4C MlCzHSVK1ccstWfMYwunHnFFOpgOXbxPcY4+pWkXI7QvcQ+heSycA+7pfoPNB0hdr5Lq 3kGHXS1DTKTOZm74J4NhPP4G2kGAijWYiB9r+069v+80HFnaIaVDwJIpelNmbC45Ad0V 5BkMALqdLjfGmys5hnsIzZZJ/0O3tiUorXcQJ4RC9WVDo9ua0B46bhRvPt7ANH9lIMG0 iJMg== X-Gm-Message-State: AHQUAuYGiaBNk72+Epk3K1yxf2NiZMMdRc51aUYfUpcJa/KgFB540GsT Auq2uYvwaYgPLBmwWuMf9+Y= X-Google-Smtp-Source: AHgI3Ia7LSp0Zdd16rsy3ZDd7X3niPwS+qPr9wRSYo8b+NY2nl3MklIam4upFoA0aqkyOf9PYvV31Q== X-Received: by 2002:adf:dbcb:: with SMTP id e11mr2088602wrj.58.1549343907370; Mon, 04 Feb 2019 21:18:27 -0800 (PST) Original-Received: from mugno.homenet.telecomitalia.it (host196-39-dynamic.55-82-r.retail.telecomitalia.it. [82.55.39.196]) by smtp.gmail.com with ESMTPSA id x15sm39651483wrs.27.2019.02.04.21.18.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Feb 2019 21:18:26 -0800 (PST) X-X-Sender: michelangelo@mugno.localdomain In-Reply-To: <87ftt36sww.fsf@web.de> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::430 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232980 Archived-At: On Tue, 5 Feb 2019, Michael Heerdegen wrote: > Michelangelo Rodriguez writes: > >> So, the link for the code is: >> https://github.com/michelangelo-rodriguez/greader.git > > Thanks. I tested it quickly. Hi Michael, Since i moved the code to gitlab, please clone this: https://gitlab.com/michelangelo-rodriguez/greader.git I will not keep updated github repo. Thanks for your hints. > > The README said I should hit C-r to let it start reading, but it should > be C-r SPC, right? That worked nicely at least. + and - didn't work > OTOH, I got an error saying that the variable "greader-rate" is > undefined. That variable is indeed declared nowhere. > > There are also a lot of compiler warnings. So a bit of code review > would probably be good, also text formatting (line breaks, capital > letters at sentence beginnings) should get some care, by someone not > blind, because it's probably easier for those (so I guess at least). > > I think the package would be a good addition to Gnu Elpa. If it is > accepted by Emacs developers, you have to sign some papers with legal > stuff. AFAIK it's important that all contributors (of more than 15 > lines or so) have also signed these papers, but it seems you are the > only contributor anyway. > > After that someone can add your package to Gnu Elpa, or you can get an > account and add it by yourself. > > > Regards, > > Michael. >