From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#30190: 27.0.50; term run in line mode shows user passwords Date: Fri, 22 Jun 2018 12:34:15 +0900 (JST) Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <87in6erte5.fsf@gmail.com> <83efh1s9s3.fsf@gnu.org> <87602drqan.fsf@gmail.com> <8336xgsvt3.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1529638387 10608 195.159.176.226 (22 Jun 2018 03:33:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Jun 2018 03:33:07 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 30190@debbugs.gnu.org, Noam Postavsky , Tino Calancha To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 22 05:33:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWCon-0002eC-NI for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jun 2018 05:33:01 +0200 Original-Received: from localhost ([::1]:58970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWCqv-0007ZV-29 for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jun 2018 23:35:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWCqn-0007YA-PM for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 23:35:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWCqk-0002do-LY for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 23:35:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51681) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWCqk-0002di-II for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 23:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fWCqk-0006ec-Cz for bug-gnu-emacs@gnu.org; Thu, 21 Jun 2018 23:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jun 2018 03:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed security Original-Received: via spool by 30190-submit@debbugs.gnu.org id=B30190.152963846725532 (code B ref 30190); Fri, 22 Jun 2018 03:35:02 +0000 Original-Received: (at 30190) by debbugs.gnu.org; 22 Jun 2018 03:34:27 +0000 Original-Received: from localhost ([127.0.0.1]:59578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWCqA-0006dk-SK for submit@debbugs.gnu.org; Thu, 21 Jun 2018 23:34:27 -0400 Original-Received: from mail-pl0-f45.google.com ([209.85.160.45]:46240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fWCq8-0006dQ-V6 for 30190@debbugs.gnu.org; Thu, 21 Jun 2018 23:34:25 -0400 Original-Received: by mail-pl0-f45.google.com with SMTP id 30-v6so2742957pld.13 for <30190@debbugs.gnu.org>; Thu, 21 Jun 2018 20:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=C0udaI+n8VtQ+CE+m71yhelBJjimKmrbWomek5cgh8k=; b=KV3CQUNUq0BwkeB156RWzzIp9FEkLxAColgUYrHF19mrclRixjKcc1Towhv1AAtkm8 5pxUL/XG5m+Q3kJRZShpovZP98CJfeHV8i9agYkftRSXn9ZwSrh4RAgJsz+Rzrhmg/Nx pfC9/UXqE7KlBeql69/2kuN1HAgOudWh6n8ChhUz/56GWU5ctHF3lS1uRT2g5xaFLF3F JVzhb0SbxxMUqTvIsAc95dbM2VIfKyNvgSFCaDtE8rPlf+c9p3coGkJnUycTdZNLxxhp wVotoxu+O0F/Qv0HUcqo7bm1EoTTrN8VYe2BURzybUt5kJ08DC3pp0EQrvblSAgWN0TN 0xlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=C0udaI+n8VtQ+CE+m71yhelBJjimKmrbWomek5cgh8k=; b=B4Vo3ubpZpMaoHUoXFflCiO+PxgkR8Aa+tQYNWzjXn+TtFPJO5/g4PENVid7jHyzd9 qnSBxFsFe0yJ5KATJZ5i0jzayVQXp9it5EFxuLryRqavoJCZIkONIR6BF5o6iXZDdMRq CduSozkr28F+TNXhLUVm5XS0VloOzygPNAUNxwPUXY00W5intM3mgeiZBVu0Ydsu4RrT KWb4pE393fuzuDl1EvcnwOBrHJFR996bQekILSuettz9HlyNJ56qySo+zUNE8UTgHPfd HsjkH1/jIt+6HfPSiUiZOkBJP0ieGviW+WiYwSD0MT1ss9S5BvdHifxEJoZ/2hkKA+CE 9iYg== X-Gm-Message-State: APt69E02dozzi+aFJPzMrytwNLMzwlp0L0+HQXFhQ0IKFLjCMmU8mxh6 h3T4LFaw3pd2c+zj9ktgQTw= X-Google-Smtp-Source: ADUXVKJgK6Ydmua2EJ9X+VYVPvVSvqJ+8F2/2600GJcvCMpClN+HOc+t+9kQFriYfgSJsbvoBaIcvA== X-Received: by 2002:a17:902:8bc6:: with SMTP id r6-v6mr30733992plo.257.1529638459149; Thu, 21 Jun 2018 20:34:19 -0700 (PDT) Original-Received: from calancha-pc.dy.bbexcite.jp (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id z64-v6sm13055131pfi.150.2018.06.21.20.34.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jun 2018 20:34:18 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc.dy.bbexcite.jp In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147722 Archived-At: On Thu, 21 Jun 2018, Stefan Monnier wrote: > I'd prefer to re-use comint code rather than copy it. Copying might be > tolerable for term-watch-for-password-prompt (it could conceivably > require adjustments for the context of term-mode), but it's out of the > question for term-password-prompt-regexp. > >> My patch just tried to mimic what is done in `comint.el' and reproduce >> it in `term.el'. My hope was that the patch would be accepted frictionless: >> if it's already done in `comint.el', why not doing the same in `term.el'? > > I'm not a great fan of the hooks in comint (tho I must say I haven't > come up with anything really better either). > > And to the extent that you can set *-password-prompt-regexp > buffer-locally in order to prevent *-watch-for-password-prompt from > getting in the way, I don't see much benefit of going through a hook. > [ The hook might be beneficial in itself, with a nil default value, but > that's a different discussion. ] Thank you for the feedback! When my current mundane duties (cooking, studying, cleaning, grocery, jogging, take care of my cat and cactus, etc) offer me a break, I will prepare a new patch (not sure when I will find the time, hopefully soon): * It will recycle (require) `comint.el', i.e., it will use `comint-password-prompt-regexp'. * It will use the hook strategy until someone comes with something smarter.