From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#31495: 26.1; filename completion -vs- "*" Date: Wed, 20 Jun 2018 21:48:40 +0900 (JST) Message-ID: References: <877eo1gern.fsf@tromey.com> <87wovzzs8c.fsf@gmail.com> <87d0wlskh8.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1529499817 16727 195.159.176.226 (20 Jun 2018 13:03:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 20 Jun 2018 13:03:37 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Tom Tromey , Michael Albinus , 31495@debbugs.gnu.org, Tino Calancha To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 20 15:03:32 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVcln-0004FA-NK for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jun 2018 15:03:31 +0200 Original-Received: from localhost ([::1]:49404 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVcnu-0002ZB-U9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jun 2018 09:05:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVcXp-0004iQ-VH for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 08:49:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVcXm-0006at-Rf for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 08:49:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVcXm-0006al-O3 for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 08:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fVcXl-00056v-VB for bug-gnu-emacs@gnu.org; Wed, 20 Jun 2018 08:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jun 2018 12:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31495 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31495-submit@debbugs.gnu.org id=B31495.152949893219628 (code B ref 31495); Wed, 20 Jun 2018 12:49:01 +0000 Original-Received: (at 31495) by debbugs.gnu.org; 20 Jun 2018 12:48:52 +0000 Original-Received: from localhost ([127.0.0.1]:57162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVcXb-00056V-OJ for submit@debbugs.gnu.org; Wed, 20 Jun 2018 08:48:51 -0400 Original-Received: from mail-pl0-f47.google.com ([209.85.160.47]:35069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVcXa-00056J-Kc for 31495@debbugs.gnu.org; Wed, 20 Jun 2018 08:48:50 -0400 Original-Received: by mail-pl0-f47.google.com with SMTP id k1-v6so1722535plt.2 for <31495@debbugs.gnu.org>; Wed, 20 Jun 2018 05:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=HRm8/J4Ff8IRM69ziOWN22RQVwJgu/AflGMuSnHOCK0=; b=NgUHueZUaVQP1Jd2DfJoVPjwi66/5MrR6B4ZkEDnArk0vzo3agices396H0QsFIiB6 ZcS9Of8uzp8DJaCSzk5eI2pobGiqZIEtw1OyY5nVR4Xnc7KQ1fcbN/Py+f3SCKVOdrr6 7go7AubFzVsCLkagfN7t9WGh7GXtBJxbVX40rw6WqgntnX0EgeRF6ZAUH2fSoH1wR4AE 7zjjFp/tPGFi2K5sKrXVF/I5KJxtb37+Y13K24mybtoCdJkKlEAwRw1/QPFT2mctKK5i D99QH7K7gvaoceH0Pc5zFaqOsMSL7mV+AsoaaM6rG81m8fxUKIeRGnjB9EGRrsVVrSQ6 uHpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=HRm8/J4Ff8IRM69ziOWN22RQVwJgu/AflGMuSnHOCK0=; b=Q0Y2DAsm4D9uEhzsxlYRaqTRLBty/J2MwYMwG5zjgvRT9S+pNlMPw0sUR6y7E1fKko 9dv+7GvuEha4rn349VyfLc0FXWiTbaLSn3xUTPvLRHEWdC6MT0yCGji1oovxKX6SOIsU 69rKSCTV7nJ4yOsk1Km926dBc6+FNdIjOLCg/JeuMPonANKWmQ54wpxCV4XfhdvNej6e 9YgTC7ODWJUmDDb0UatoHsc1Xzs3ZW1ULTumr4aZriyExRUbAmsVaqF2D2VPAfooxdZC ZB1ZwUyJigmVlcxGTJqwjfpIoiOXi4k1Pb4WV2DPzIi27Rhm+AfwSWQTXcdqOxc9xpTo kQRg== X-Gm-Message-State: APt69E2xNYD1vH2kZdc4gh829VqsChq3pVx8Q2qIAiZ2JeG+dlkw+Ctn /J2bvBKeUJVxsBd5Ilt+4gc= X-Google-Smtp-Source: ADUXVKKPn8e6cy5xGv4Usl3v1nGm66Rk/2z9AZNnvLgmHdTRh84LAdZ9jpOq7t2KIl4kHO9Y/1mvPQ== X-Received: by 2002:a17:902:778e:: with SMTP id o14-v6mr23416153pll.214.1529498924751; Wed, 20 Jun 2018 05:48:44 -0700 (PDT) Original-Received: from calancha-pc.dy.bbexcite.jp (228.225.128.101.dy.bbexcite.jp. [101.128.225.228]) by smtp.gmail.com with ESMTPSA id j127-v6sm2847831pgc.10.2018.06.20.05.48.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jun 2018 05:48:44 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc.dy.bbexcite.jp In-Reply-To: <87d0wlskh8.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147654 Archived-At: >> +(defconst dired-enable-globstar-in-shell >> + '(("ksh" . "set -G") >> + ("bash" . "shopt -s globstar")) >> + "Alist of (SHELL . COMMAND), where COMMAND enables globstar in SHELL. >> +If `dired-maybe-use-globstar' is non-nil, then `dired-insert-directory' >> +checks this alist to enable globstar in the shell subprocess.") > > Shouldn't this be a defvar or a defcustom? Using defconst makes it seem > like the code wouldn't handle it being changed. To indicate what shells Emacs is supporting for this feature. Of course it might be a defvar, and users might change that adding other shells; but then, those shells might not been heavily tested by Emacs developers, and other features can break. I just wanted to be conservative. I think that is a cheap and useful addition. I like it. I set '/bin/sh' to '/bin/zsh' mainly to have globstar in dired; often, I find that I reset it to 'bash' and globstar stop working with Dired :-(