Re: [elpa] master cfa7c4e: Add missing file gited-ci.el

[Tino Calancha <tino.calancha@gmail.com>]

On Sat, 19 May 2018, Stefan Monnier wrote:

>> +;;; gited-ci.el --- Obtain CI status of the trunk branch  -*- lexical-binding:t -*-
>> +;;
>
> This is missing the copyright and licence blurbs.
Fixed in commit 'gited-ci.el: Fix copyright stuff'

(228610373722e05776b2af8a03064c6a56f04e2c)
>
>> +(defcustom gited-show-trunk-ci-status nil
>> +  "Show CI status for the last commit in the trunk branch.
>> +An alist of conses ((TOPLEVEL_DIR_1 . CI-URI_1) (TOPLEVEL_DIR_2 . CI-URI_2) ... ).
>
> I usually prefer to say
>
>    ... a list of elements of the form (TOPLEVEL-DIR . CI-URI) ...
>
> So you don't need to talk about the "_I" thingy.
Excellent tip! I always suffer such enumerations.  Much better now.
> But other than this mostly irrelevant nitpick, I have a more serious
> comment to make: why not rely on dir-locals variable for that?
Never used dir-locals before.  I need to study such stuff first :-)