From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: master 51c8369: Run secrets suite test when Emacs has dbus support Date: Fri, 6 Apr 2018 18:20:13 +0900 (JST) Message-ID: References: <20180406000306.5540.34428@vcs0.savannah.gnu.org> <20180406000308.94E77206AB@vcs0.savannah.gnu.org> <87lge07q59.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Trace: blaine.gmane.org 1523006363 14082 195.159.176.226 (6 Apr 2018 09:19:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2018 09:19:23 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Michael Albinus , Emacs developers To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 06 11:19:19 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4NWd-0003Qa-7q for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2018 11:19:15 +0200 Original-Received: from localhost ([::1]:38604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4NYi-0001KC-8Z for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2018 05:21:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4NXj-0001Ic-F6 for emacs-devel@gnu.org; Fri, 06 Apr 2018 05:20:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4NXf-0003Rp-9s for emacs-devel@gnu.org; Fri, 06 Apr 2018 05:20:23 -0400 Original-Received: from mail-io0-x22f.google.com ([2607:f8b0:4001:c06::22f]:42494) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4NXf-0003Ra-3a for emacs-devel@gnu.org; Fri, 06 Apr 2018 05:20:19 -0400 Original-Received: by mail-io0-x22f.google.com with SMTP id d5so933903iob.9 for ; Fri, 06 Apr 2018 02:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=6TH1cLwMbr2RYIpgiKnvADq58B2+PmehhIvN28d4kBU=; b=B/BFo+Srx63cBSTNs9kPMHCmNt5Zbu3AEjiEhMmBH+5G2XxzWfJ0HGX78afzvoDEKr 8EqJlHzTcDgNQBRQ8vFtD0NpmSEMnPIkgmJ7jXsstWsaaGlz8Bh4XEfAw1MqrmkDecUA NEFbYBwhhiR9dgDv/7DFn1AgtOwKLAZRZ5x86SyLPrP2UKQ2qWNm03xyU9jCfdLmRxT4 c3AKyVW9YGLZLT+yZ3Fs2PRD8+ubEzqjR12Vadm2WrWauF4fqqEgsuumZx2M81GDe6G1 y+FHbNPDgm4n+jbqpaA0TcAmQkIAXW/9X/baMP3duJ/6maGJrM/fNzd6wpi+eFPBOO35 DOJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=6TH1cLwMbr2RYIpgiKnvADq58B2+PmehhIvN28d4kBU=; b=Wo+DwwBbOjs3Xl/UtiML9mtgY6NPpyGYZwJ1+lMGBqPA2YMVle4xn7GVBBBKJRjkQ4 aoWyt0feq3q+3Ppa6Tbto2JQitnkiVb0wuPInYDNs4fW0Ytpgbt9++IsiDNAK7y0kdlw IgPl8j3u6zmptX3k20VsjXZN3GJUDOCm5mg9L8gH2QaZwy/7i2RkM9NlKz9i91kT1Y51 1DfdJzUHT1Yoo6CtCHoqJfWY3Nb8EB0eSoEggAeFytRrJ/eHszwbLzZjGazTt9A68ewX 7eu4/yRPD1GVzAniPATutvBfHj4372HyNX34rz0QRIUXFxy1E+LwaAz2MekmVwpLY3fo aU9g== X-Gm-Message-State: ALQs6tCkgfIcoNkwvzZreeIknJpCT/vCLeRQOm2lGNCamG3nupFTSle0 TVSiNyjtMdIC73BkHKtGhoM= X-Google-Smtp-Source: AIpwx49oUTB3rS+pR2vAmw+ks5UApdeQA2xSH1kr2wYC1nP/qxxkKlkiAEl+DWHA+A90k43BN2bRow== X-Received: by 10.107.164.13 with SMTP id n13mr24771595ioe.238.1523006418532; Fri, 06 Apr 2018 02:20:18 -0700 (PDT) Original-Received: from calancha-pc (15.224.128.101.dy.bbexcite.jp. [101.128.224.15]) by smtp.gmail.com with ESMTPSA id p135-v6sm5480053itg.33.2018.04.06.02.20.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Apr 2018 02:20:17 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c06::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224397 Archived-At: On Fri, 6 Apr 2018, Tino Calancha wrote: >> >>> Run secrets suite test when Emacs has dbus support >>> >>> * test/lisp/net/secrets-tests.el (secrets-test00-availability) >>> (secrets-test01-sessions, secrets-test02-collections) >>> (secrets-test03-items, secrets-test04-search): Skip test >>> unless Emacs is compiled with dbus support. >> >> Why this? If there is no D-Bus support, secrets-enabled shall be nil, >> and the tests shall skip (except secrets-test00-availability, which >> shall fail). That's intended. > I don't know. I saw in our gitlab CI that your new test was failing: > https://gitlab.com/emacs-ci/emacs/commits/master Just re-reading my answer looks unclear (even to me). The reason why I skipped these tests if the feature 'dbusbind is not present was: * After inspecting the gitlab log file I found this: ELC lisp/net/secrets-tests.elc peculiar error: "Emacs not compiled with dbus support" Makefile:151: recipe for target 'lisp/net/secrets-tests.elc' failed make[3]: *** [lisp/net/secrets-tests.elc] Error 255 make[3]: Target 'lisp/net/secrets-tests.log' not remade because of errors. Best regards, Tino