From: Tino Calancha <tino.calancha@gmail.com>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: Michael Albinus <michael.albinus@gmx.de>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 51c8369: Run secrets suite test when Emacs has dbus support
Date: Fri, 6 Apr 2018 18:20:13 +0900 (JST) [thread overview]
Message-ID: <alpine.DEB.2.20.1804061816300.27807@calancha-pc> (raw)
In-Reply-To: <alpine.DEB.2.20.1804061634001.15878@calancha-pc>
On Fri, 6 Apr 2018, Tino Calancha wrote:
>>
>>> Run secrets suite test when Emacs has dbus support
>>>
>>> * test/lisp/net/secrets-tests.el (secrets-test00-availability)
>>> (secrets-test01-sessions, secrets-test02-collections)
>>> (secrets-test03-items, secrets-test04-search): Skip test
>>> unless Emacs is compiled with dbus support.
>>
>> Why this? If there is no D-Bus support, secrets-enabled shall be nil,
>> and the tests shall skip (except secrets-test00-availability, which
>> shall fail). That's intended.
> I don't know. I saw in our gitlab CI that your new test was failing:
> https://gitlab.com/emacs-ci/emacs/commits/master
Just re-reading my answer looks unclear (even to me). The reason why I
skipped these tests if the feature 'dbusbind is not present was:
* After inspecting the gitlab log file I found this:
ELC lisp/net/secrets-tests.elc
peculiar error: "Emacs not compiled with dbus support"
Makefile:151: recipe for target 'lisp/net/secrets-tests.elc' failed
make[3]: *** [lisp/net/secrets-tests.elc] Error 255
make[3]: Target 'lisp/net/secrets-tests.log' not remade because of errors.
Best regards,
Tino
next prev parent reply other threads:[~2018-04-06 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180406000306.5540.34428@vcs0.savannah.gnu.org>
[not found] ` <20180406000308.94E77206AB@vcs0.savannah.gnu.org>
2018-04-06 7:25 ` master 51c8369: Run secrets suite test when Emacs has dbus support Michael Albinus
2018-04-06 7:36 ` Tino Calancha
2018-04-06 8:04 ` Michael Albinus
2018-04-06 8:20 ` Tino Calancha
2018-04-06 9:20 ` Tino Calancha [this message]
2018-04-06 9:27 ` Michael Albinus
2018-04-06 9:38 ` Tino Calancha
2018-04-06 9:52 ` Michael Albinus
2018-04-06 10:27 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1804061816300.27807@calancha-pc \
--to=tino.calancha@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.