From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: master 51c8369: Run secrets suite test when Emacs has dbus support Date: Fri, 6 Apr 2018 16:36:08 +0900 (JST) Message-ID: References: <20180406000306.5540.34428@vcs0.savannah.gnu.org> <20180406000308.94E77206AB@vcs0.savannah.gnu.org> <87lge07q59.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1523000099 18514 195.159.176.226 (6 Apr 2018 07:34:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2018 07:34:59 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Tino Calancha , Emacs developers To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 06 09:34:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f4Ltc-0004hD-7Z for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2018 09:34:53 +0200 Original-Received: from localhost ([::1]:60930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4Lvh-00052O-JW for ged-emacs-devel@m.gmane.org; Fri, 06 Apr 2018 03:37:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4Luy-00051c-PF for emacs-devel@gnu.org; Fri, 06 Apr 2018 03:36:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4Luu-0003Ov-Qx for emacs-devel@gnu.org; Fri, 06 Apr 2018 03:36:16 -0400 Original-Received: from mail-it0-x22e.google.com ([2607:f8b0:4001:c0b::22e]:54386) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4Luu-0003Oc-LH for emacs-devel@gnu.org; Fri, 06 Apr 2018 03:36:12 -0400 Original-Received: by mail-it0-x22e.google.com with SMTP id h143-v6so659917ita.4 for ; Fri, 06 Apr 2018 00:36:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=YaiDo0gr8ZJQ0qC+lXO6uHCFS150/EAyr8EX8p2Hx7Q=; b=ApwUSRhNgjphlMbRCGHmyfy228dbSCQrIgmmkOGIdYHNvbtvd/7dzyXCSBRHN5OFV0 o2MUJ6OqBrc/+4vcJrYCES6yQJbPpHiVfjZEKe2P3hfpDCWfo2RQvcsL/FoHj5mJ1Gej rTis2Nfgb8QHhZM8he5OazshESndIeIqxL7aU0bAsdOIMhBeE82xc8UbARILoy0dhdeN lwUEzRAIo7ZQF59R7RtXoPVgjeKLh3zLlXdV9FGz9KoLXfcJggJ9dfHl4Wpug5Yz+jhq ffKHBb+9hBfij29eY+USUqc702tDptNWnBulOGVi9PJzWguIx3FlX8hfq4KxoLmOSVDd GP2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=YaiDo0gr8ZJQ0qC+lXO6uHCFS150/EAyr8EX8p2Hx7Q=; b=IIoO94Pb4t5DzOsHi3hECv+u1aUgdCjw0Q00Rx6/4Qm+ohGn+2L8q7WAp1CsfsEDqe Tlxs59K4J8vBwLswRsB3mVqL0bHhTPET0/LpRc4YmgKfThHENzLAQpCb9VOTcoDHFMAL kdLOtXtHiUSoUKzOSbZ4F1JriPNpkrV1fnHVaf6s7Q9VMzLwDmFyn+VHzeJUW6RBgxVP hYsEEvVyNzbBb2QityMJKks6+FrOUnV+eJQh6cTbVz4McjF8oWHGqlsBLjTIgh1H80qy +ljZrHoKCnV2zcx6xplyOLpmMhjSLPQ9IpHqX4le2KDDr2v6ndOMomY4JUnFs7f+5LBr QTzA== X-Gm-Message-State: ALQs6tD4Use5m2iW0WY8SMOx4WUCqRymRgbF8IS+0SRzQp/F1WMES9E9 oEKCJ78sgUBkIfWg3h+7Ds4= X-Google-Smtp-Source: AIpwx49ihqmtHXAEgFyXEMhi0mKyqQRmC5uIVKDnRy68CU8UZ3WBsavaU+DAQEjGQ1sHX4L78UIIXA== X-Received: by 2002:a24:7088:: with SMTP id f130-v6mr16843502itc.39.1523000171953; Fri, 06 Apr 2018 00:36:11 -0700 (PDT) Original-Received: from calancha-pc (15.224.128.101.dy.bbexcite.jp. [101.128.224.15]) by smtp.gmail.com with ESMTPSA id m21sm6274361ioi.53.2018.04.06.00.36.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Apr 2018 00:36:11 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <87lge07q59.fsf@gmx.de> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c0b::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:224392 Archived-At: On Fri, 6 Apr 2018, Michael Albinus wrote: > tino.calancha@gmail.com (Tino Calancha) writes: > > Hi Tino, > >> Run secrets suite test when Emacs has dbus support >> >> * test/lisp/net/secrets-tests.el (secrets-test00-availability) >> (secrets-test01-sessions, secrets-test02-collections) >> (secrets-test03-items, secrets-test04-search): Skip test >> unless Emacs is compiled with dbus support. > > Why this? If there is no D-Bus support, secrets-enabled shall be nil, > and the tests shall skip (except secrets-test00-availability, which > shall fail). That's intended. I don't know. I saw in our gitlab CI that your new test was failing: https://gitlab.com/emacs-ci/emacs/commits/master > >> (ert-deftest secrets-test00-availability () >> "Test availability of Secret Service API." >> + (skip-unless (featurep 'dbusbind)) >> :expected-result (if secrets-enabled :passed :failed) >> (should secrets-enabled) >> (should (dbus-ping :session secrets-service)) > > FTR, this would be wrong. :expected-result must always be the first > clause in body. I see. Could you please update this part? (Or anyother that you think might be wrong). Thanks. Tino