From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#30190: 27.0.50; term run in line mode shows user passwords Date: Sat, 10 Mar 2018 19:44:13 +0900 (JST) Message-ID: References: <87r2qjh0fs.fsf@gmail.com> <87mv17nwe4.fsf@users.sourceforge.net> <87efm259s5.fsf@gmail.com> <83vafe9f16.fsf@gnu.org> <87wozfkt9t.fsf@gmail.com> <87o9kiejd4.fsf@gmail.com> <83606q6xr7.fsf@gnu.org> <873718qpme.fsf@gmail.com> <83a7vgut17.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1520678595 1298 195.159.176.226 (10 Mar 2018 10:43:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Mar 2018 10:43:15 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 30190@debbugs.gnu.org, Tino Calancha , rms@gnu.org, npostavs@users.sourceforge.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 10 11:43:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euby2-0000B9-Bq for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 11:43:10 +0100 Original-Received: from localhost ([::1]:50202 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euc03-0000LW-JB for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 05:45:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eubzt-0000Kx-NR for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 05:45:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eubzq-0006lz-Jz for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 05:45:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eubzq-0006lr-G7 for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 05:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eubzp-00016N-UH for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 05:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Mar 2018 10:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed security Original-Received: via spool by 30190-submit@debbugs.gnu.org id=B30190.15206786834195 (code B ref 30190); Sat, 10 Mar 2018 10:45:01 +0000 Original-Received: (at 30190) by debbugs.gnu.org; 10 Mar 2018 10:44:43 +0000 Original-Received: from localhost ([127.0.0.1]:53140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eubzX-00015b-Lp for submit@debbugs.gnu.org; Sat, 10 Mar 2018 05:44:43 -0500 Original-Received: from mail-pg0-f42.google.com ([74.125.83.42]:46658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eubzW-00015M-0n for 30190@debbugs.gnu.org; Sat, 10 Mar 2018 05:44:42 -0500 Original-Received: by mail-pg0-f42.google.com with SMTP id r26so4556763pgv.13 for <30190@debbugs.gnu.org>; Sat, 10 Mar 2018 02:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=ZRChNkVAuWNzcJbgoQjA8yCatGNIMAyPq/g8Cyw9z9Y=; b=MZ3rnXJv/xtXYPRPc1jzAoXu19SLacixxYlT7jkj+zi39U4U9utZp0n+DuSnEx03Rb psdIoBLybSEqqb3VPgt8QOINdMoafY2JwX+fIODWmuTtUhX9MixrGlW6WlApWZVx/EpW BzkJDAwG9DGmwfRcad/RCmJQCfFXzYcEsJ0piUlv8k9H9LppuMju9rHJjzD7gCbiDS9d 88NkwNqOzhw3pf5fURQ3vKRjoalIcLXfvO9ri9DtPQYM4hcJGrlosbe2x6gCt3e3KkXt ZI5pc/BND83RcoU8cgU+AINKMxkR0EMOzF4nEY2L+hzi1utkZ5I92gTrzhN0Itu5tCaa AoKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=ZRChNkVAuWNzcJbgoQjA8yCatGNIMAyPq/g8Cyw9z9Y=; b=gwi/8/xLhzoHJm9LCK3mM0UL6CAcoIyxVVFylXTAWauJP3sXmK+mCyRq/qg6MB2bup ucjFdFWRAUDuiyClB4gCJ5rcEFsSNYcvthAm5anwHnC6nFGqe/XeXcAhDJQrmOg+M8pJ LDCikNWeOpeZAviOY/yj0n+fI9mAnLU/niRRpLh8PhaJRKooAVIt5csfq0w1ejb8D745 Px0oUpPxdviVvef/S2bZ99khI4DOZTaw3iHtPYtcNgES6bjsBhzS/9fJDnilghBGbvfb +bzwgAAr+QbBj43xlgR5ovVsHeCs1hWYC21fRUiMDOiIQTGdpj6W8pgOwc3RPMNxa6Gh xD+g== X-Gm-Message-State: AElRT7G+sOpftaLdmlnKspX8782XimHwK3AZCnhn1nrqgpc181o/q3Ye mpTC1da5ZrB6ebNafbrRHvE= X-Google-Smtp-Source: AG47ELtKAlQbKiWPUDaKn/27TLqqW5vkoFu9/0PgYeYKTARwg580Dgp+pePqt6ygOTIXpDiJKEg2bw== X-Received: by 10.99.108.129 with SMTP id h123mr1444209pgc.30.1520678676208; Sat, 10 Mar 2018 02:44:36 -0800 (PST) Original-Received: from calancha-pc (146.219.128.101.dy.bbexcite.jp. [101.128.219.146]) by smtp.gmail.com with ESMTPSA id p6sm7350508pfg.183.2018.03.10.02.44.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Mar 2018 02:44:35 -0800 (PST) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <83a7vgut17.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144098 Archived-At: On Sat, 10 Mar 2018, Eli Zaretskii wrote: > Here's what bothers me about the patch: > > . it installs the filter even when term.el is not in line mode It must install it by default, because the user might switch several times between char mode <-> line mode (I do a lot). Furthermore, 'term-watch-for-password-prompt' is a noop in char-mode. Besides that, 'term-send-input' is just called in line-mode, so the filter would ever be called in char mode. > . it uses many constructs in term-password-prompt-regexp that could > happen in unrelated text--does that mean such unrelated text will > become invisible, thus making the session at least look buggy? Regarding this issue, it would behave exactly as a dumb shell buffer does M-x shell RET I've never seen a bug report about that for comint.el. If you see that, you should definitely open a bug report! > The 2nd issue looks to me like a more serious one, unless I'm missing > something. Is it possible to make sure we don't mistakenly take some > innocent text as a password? Did you try in your testing to type text > that matches this regexp, and if so, what did you see as result? I tried just after I read your message. I don't find a problem. And as a pointed out above, it uses the same mechanism as comint.el (e.g. dumb shell buffers), so I don't think you should worry about it. > If anyone can show just cause why this patch cannot lawfully be joined > together in Emacs-26 branch, let them speak now or forever hold their > peace. I have booked all the celebration... :-S I hope I can marriage soon ;-)