From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#30285: dired-do-chmod vs. top line of dired Date: Wed, 31 Jan 2018 18:49:19 +0900 (JST) Message-ID: References: <87mv0wg80c.fsf@jidanni.org> <87efm8snnr.fsf@gmail.com> <83efm8irac.fsf@gnu.org> <87d11sl08v.fsf@gmail.com> <1dd0ec16-7f13-4753-beef-0daeaf84ed8d@default> <91a8c271-5d11-4ec9-ac95-ed8de1badc4b@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Trace: blaine.gmane.org 1517392137 15125 195.159.176.226 (31 Jan 2018 09:48:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 31 Jan 2018 09:48:57 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 30285@debbugs.gnu.org, Tino Calancha , jidanni@jidanni.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 31 10:48:52 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egp06-0001nQ-T2 for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jan 2018 10:48:19 +0100 Original-Received: from localhost ([::1]:48934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egp27-0003ha-SQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jan 2018 04:50:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egp1s-0003gY-It for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 04:50:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egp1m-0006zp-Vn for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 04:50:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42409) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egp1m-0006zj-Q4 for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 04:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1egp1m-00065X-GV for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2018 04:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Jan 2018 09:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30285 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30285-submit@debbugs.gnu.org id=B30285.151739217123360 (code B ref 30285); Wed, 31 Jan 2018 09:50:02 +0000 Original-Received: (at 30285) by debbugs.gnu.org; 31 Jan 2018 09:49:31 +0000 Original-Received: from localhost ([127.0.0.1]:50306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egp1G-00064i-Rj for submit@debbugs.gnu.org; Wed, 31 Jan 2018 04:49:31 -0500 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:40585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1egp1F-00064W-IE for 30285@debbugs.gnu.org; Wed, 31 Jan 2018 04:49:29 -0500 Original-Received: by mail-it0-f42.google.com with SMTP id 196so4296759iti.5 for <30285@debbugs.gnu.org>; Wed, 31 Jan 2018 01:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=2e7fCFsjR3x9slVt/hUDtJM1utxcDodb7c5nCHebAw8=; b=aEfyhqMYFohe9xZNAGCljfdev1p4+1ZXPOKCBiY1xCCzyHVh+61dUoH1ujNTM+Ncfi Ip+GX6QV03AjjAGd+imbS3nfuK2Q0ousY2Wvqpg1VpUjM9ZMRtIuarj6AzzFrwGdtnk8 LghB1w/8+Lwo+niouAvF/WpGFb4sJQZET19hPjznrXDbRyucHr6JfR5Rk/qKXwffRbzj Il0KMQkyJExkYmcm8IQQUTcpLUB2rglgTGPHGX9NdNBi5YasUBKfrRVKPHt51bhQotC0 uS/3KZ8g4ottP4OhKKfT3D9SapcMDPdK20b1IXmzffLCCcNTpj/TU+KE2aS+zOODMl8v 9Tbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=2e7fCFsjR3x9slVt/hUDtJM1utxcDodb7c5nCHebAw8=; b=s8ec5wP3t6Y4GYs3H2LmqevDVPMV1YCNEyLkuOzSenoFPNVn+q+i0bHhiaszrjEMPZ bTduYb56gnxWqjvbIqSElJWLujRrTpyBySGCzePsHYMvhZSC0A5HpmT4GVjE0G4nyoKd 6KaxM3BtkLrgq7LRRkjf8hEA4NPbJkXEuW23lRRLAVTTjs9NVGOBCgscJMfmjCrEqpho 8S24Jx6UG9Myn4PBcPyMgH10v1wP8MBVP4uxgw6BoWW3e2ZfqZDod2Y9HnoraHrkow8B eoPmPntpsRUnhrqYMuNC/6MfyXm8MjOGI1n9I9VTjQJTilW1WWJ41G+EaDTq1+zHFIzn zSqw== X-Gm-Message-State: AKwxytfAQQ18XsE81s6/EhD4jtwz6HP3jGZMqA7wZ/uSFQPE7aKTnl7U 4Z+dBamtd6O1iqKByI5DbF8= X-Google-Smtp-Source: AH8x224yYa4hBdr4P+yBdiQoKvqcjjAduFdLQhiMRzjcKXOzxg9VH1chk2FDPQb8rPEgCLiDFX06iQ== X-Received: by 10.36.1.66 with SMTP id 63mr36019926itk.104.1517392163969; Wed, 31 Jan 2018 01:49:23 -0800 (PST) Original-Received: from calancha-pc (FL1-125-193-170-29.tky.mesh.ad.jp. [125.193.170.29]) by smtp.gmail.com with ESMTPSA id d3sm8888432itf.1.2018.01.31.01.49.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Jan 2018 01:49:23 -0800 (PST) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <91a8c271-5d11-4ec9-ac95-ed8de1badc4b@default> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142731 Archived-At: On Tue, 30 Jan 2018, Drew Adams wrote: > Obviously, for `dired-do-*' commands we still need to > handle the case where files or dirs are marked. And > in that case the command should DTRT even if called from > a non-file line, i.e., one of the problematic places > we've been discussing - it should not raise an error > in that context. IIRC, my latest patch handle those situations pretty well. Could you tested it and provide feedback about how to improve it? > For `dired-do-*' commands that already call > `dired-get-marked-files' the clear solution, I think, > is to just test that return value and raise an error > if it is nil. > > If there is are `dired-do-*' commands that do not call > `dired-get-marked-files' then we have a choice how to > solve the problem. But it might well be that even then > the best solution is to use `dired-get-marked-files'. Since you are reluctant to the addition of the new predicate. That's fine. May I ask you to provide an alternative patch to compare with mine? Then, people here might do further feedback based on those 2 alternatives. Thank you very much!