From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection Date: Fri, 13 Oct 2017 10:54:41 +0900 (JST) Message-ID: References: <87ing3w8rk.fsf@gmail.com> <87o9pdazmp.fsf@users.sourceforge.net> <87o9pdaxfo.fsf@gmail.com> <87infjc1s1.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1507859721 26244 195.159.176.226 (13 Oct 2017 01:55:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 13 Oct 2017 01:55:21 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: 28631@debbugs.gnu.org, Tino Calancha To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 13 03:55:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2pBq-000567-S6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Oct 2017 03:55:07 +0200 Original-Received: from localhost ([::1]:48100 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2pBw-0001ve-BP for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Oct 2017 21:55:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2pBp-0001vL-HV for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2017 21:55:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2pBm-0005A0-Fg for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2017 21:55:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56085) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2pBm-00059h-BC for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2017 21:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e2pBl-0003Tp-UC for bug-gnu-emacs@gnu.org; Thu, 12 Oct 2017 21:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2017 01:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28631 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28631-submit@debbugs.gnu.org id=B28631.150785969313357 (code B ref 28631); Fri, 13 Oct 2017 01:55:01 +0000 Original-Received: (at 28631) by debbugs.gnu.org; 13 Oct 2017 01:54:53 +0000 Original-Received: from localhost ([127.0.0.1]:36533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2pBd-0003TN-7a for submit@debbugs.gnu.org; Thu, 12 Oct 2017 21:54:53 -0400 Original-Received: from mail-pf0-f180.google.com ([209.85.192.180]:51050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2pBb-0003T8-0n for 28631@debbugs.gnu.org; Thu, 12 Oct 2017 21:54:51 -0400 Original-Received: by mail-pf0-f180.google.com with SMTP id m63so7616011pfk.7 for <28631@debbugs.gnu.org>; Thu, 12 Oct 2017 18:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=y+67KpAKJsiap5mLqfj4Im1N9T5QsJhWh7naF1QFEhs=; b=g/SY7YDaoG+qAHf4Mo5ncbaO5ljmdLGOEPbLfnOGSH8rbWkyHn+SoExmU/DnlJQ079 6Xc6usqufMKMq+eyfRUgkqtQJRBCBFEFV60G2CjIu4BRDNb5iy/QGrsYivv0Ece9Bes7 HhvnwjAqR/St/OjHkJ4N8tPQEN1NRxrFJ30L6TH09JmsFKsnOqMTlof8EMgeSi82TNJf nlyTsNH7X1B1YcCcV6T8nl2wV6mzzBCs3ZntYZv0FZvwvtl7/qbbdqrCx2Z0l+y3BiJW Yxa1jZo7GN2X/03mT2iJgjx8C6ql82iINw7FZF5SHpEs+zzx1iZcGnlZ77bqJAhZewHg TfXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=y+67KpAKJsiap5mLqfj4Im1N9T5QsJhWh7naF1QFEhs=; b=Sdjx0UJc9ZkSOsSLFu2Z/35FULv9JCdSNmSn/It9l0vXEyfr4HNRcBvbAVZfXa+5PT mpudGyb/Yqun8kmxxGJtzRvACBXBEkqXxtrh34ucO4XSdIJfG7Y/eVjTifjGDNs8Odsw 6T87hT2Vy0lbCxvlUNs5TuiaGxvvnciG6U8MSOzgMNFGadUbJokIdYdxOH+7Mv4EczZx gnXZkEytUxvtVQT97AE/kZxRA/aDvee1UDCF5t1usc2BZoXo8+rUpoSHdvD7SXdChEb/ b5ZCDHymB9Iyzj5qg2Otsw9KNEQ2cvkZwOxMWFaSLRkbavIEjWkCUhcFeSOE0baYHqHZ Y/RQ== X-Gm-Message-State: AMCzsaX2wewVAS2XYiu2ZeoMYa5oVv3bFGeAqwJByRunMB1fy35uLH2q dzTVRBBediK8Csf4OT93w2Y= X-Google-Smtp-Source: AOwi7QDe3+DSby8VQ8GU/iEK72hMHfSnmwLJXhLq/qhwq3yjjwAsr0gj8Oms6Gav+kA0Wl8xVeHSww== X-Received: by 10.84.173.228 with SMTP id p91mr1800615plb.264.1507859684857; Thu, 12 Oct 2017 18:54:44 -0700 (PDT) Original-Received: from calancha-pc (203.191.218.133.dy.bbexcite.jp. [133.218.191.203]) by smtp.gmail.com with ESMTPSA id t24sm27778027pfj.46.2017.10.12.18.54.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 18:54:44 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <87infjc1s1.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138315 Archived-At: On Thu, 12 Oct 2017, Noam Postavsky wrote: > I think I would rather put it with the next condition: > > --- i/lisp/simple.el > +++ w/lisp/simple.el > @@ -5336,7 +5336,9 @@ deactivate-mark > ;; deactivation should not clobber it (Bug#11772). > ((and (/= (region-beginning) (region-end)) > (or (gui-backend-selection-owner-p 'PRIMARY) > - (null (gui-backend-selection-exists-p 'PRIMARY)))) > + (null (gui-backend-selection-exists-p 'PRIMARY))) > + ;; `winner-undo' shouldn't update the selection (Bug#28631). > + (not (eq this-command 'winner-undo))) > (gui-set-selection 'PRIMARY > (funcall region-extract-function nil))))) > (when mark-active (force-mode-line-update)) ;Refresh toolbar (bug#16382). > > Either way, I think it's okay to push emacs-26, but wait a bit in case > someone else thinks otherwise. OK. Thank you very much.