all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tino Calancha <tino.calancha@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Emacs developers <emacs-devel@gnu.org>,
	Tino Calancha <tino.calancha@gmail.com>
Subject: Re: dired-tests.el fails on MS-Windows
Date: Fri, 4 Aug 2017 22:39:05 +0900 (JST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1708042237090.15299@calancha-pc> (raw)
In-Reply-To: <831sorxyol.fsf@gnu.org>



On Fri, 4 Aug 2017, Eli Zaretskii wrote:

>> Does it work now in Windows?
>
> It didn't, but given the comments I've now succeeded to understand the
> idea of dired-test-bug25609, and fixed it.
Great! Thank you.

> dired-test-bug27631 still fails, and it fails because of this:
>
>          (setq buf (dired (expand-file-name "dir*/*.txt" dir)))
>
> ls-lisp signals an error here:
>
>   wrong-type-argument listp "dir*/*.txt"
>
> Didn't you add a feature lately that should support this in ls-lisp?
> I guess that feature needs to be turned on for this test to pass on
> Windows.
Yeah, that test must be skipped when Dired is using 'ls' emulation.  We 
have tests for the same bug in ls-lisp-tests.el and em-ls-tests.el.
I've just pushed a fix.



  reply	other threads:[~2017-08-04 13:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 15:22 dired-tests.el fails on MS-Windows Eli Zaretskii
2017-08-01 17:02 ` Tino Calancha
2017-08-01 19:04   ` Eli Zaretskii
2017-08-01 20:56     ` Fabrice Popineau
2017-08-02  6:44       ` Tino Calancha
2017-08-04 13:18         ` Eli Zaretskii
2017-08-04 13:30           ` Fabrice Popineau
2017-08-04 13:44             ` Tino Calancha
2017-08-04 14:01               ` Fabrice Popineau
2017-08-04 14:00             ` Eli Zaretskii
2017-08-04  5:21     ` Tino Calancha
2017-08-04 13:14       ` Eli Zaretskii
2017-08-04 13:39         ` Tino Calancha [this message]
2017-08-04 14:23         ` Fabrice Popineau
2017-08-04 14:39           ` Fabrice Popineau
2017-08-04 14:49             ` Tino Calancha
2017-08-04 14:58               ` Fabrice Popineau
2017-08-04 15:10                 ` Tino Calancha
2017-08-01 20:52 ` Fabrice Popineau
2017-08-02  3:38   ` Tino Calancha
2017-08-02  6:31     ` Michael Albinus
2017-08-02  7:59       ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1708042237090.15299@calancha-pc \
    --to=tino.calancha@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.