From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: dired-tests.el fails on MS-Windows Date: Fri, 4 Aug 2017 14:21:01 +0900 (JST) Message-ID: References: <83zibjz519.fsf@gnu.org> <87d18fw79z.fsf@calancha-pc> <83pocfyurp.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1501824108 17840 195.159.176.226 (4 Aug 2017 05:21:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 Aug 2017 05:21:48 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Emacs developers , Tino Calancha To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 04 07:21:42 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddV3M-0004Do-Pq for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 07:21:40 +0200 Original-Received: from localhost ([::1]:35065 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddV3S-0002nw-Rz for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 01:21:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddV2s-0002nh-0g for emacs-devel@gnu.org; Fri, 04 Aug 2017 01:21:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddV2q-0004cM-W8 for emacs-devel@gnu.org; Fri, 04 Aug 2017 01:21:09 -0400 Original-Received: from mail-pg0-x235.google.com ([2607:f8b0:400e:c05::235]:34351) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddV2n-0004VY-O1; Fri, 04 Aug 2017 01:21:05 -0400 Original-Received: by mail-pg0-x235.google.com with SMTP id u185so3619269pgb.1; Thu, 03 Aug 2017 22:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=5WIZhO0RsD+bsYyeyqehGfEURE2u00vt3k6P7oZ8QaM=; b=Xwoo33Bvnl2WrG03uw/q2l+LJW1Ts5TdeefUHtqtyFSlmHu66osCforcySw03wFhTO fBGakpcRxD97x9QqusPeVmd0HeB1HPA4Hxku5M075VnugY7mvaDLQe9xRjNU2gxYC4Kj CPJXxdszERraAkG1gDFlUYPZrZZ8cCJrObfFOJPPV5iQVZ9pRsFxhvRivFdRCj0oxfli DHVb8PaDC2ZsgXZEzIX+lnQrNYLzWEdRI1n9ueDtUS+qWYbUUUo5Q4eH1wrpz9Skj8To AaUxUVNjytDXyfKa8HK/1z/FIM7XQ+8rhnacO6C7LZMCUTgrZH9WDrICtQZfj5QhKqaK YLZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=5WIZhO0RsD+bsYyeyqehGfEURE2u00vt3k6P7oZ8QaM=; b=aveVnHls9QTHEzfvu1JgLDNS9+at6pFX85Hg5J5rCOIwQF4W+juoDlMNJXcNyYesdf ByKDzfwYUxANemsev1RY0rJM8iGFWBJoxpzGuIxASqvSL4ZZb/6c1h05xI8poawL7xgs npI0mZ/sp8zwyt/z6WV7HuahICZ0lt2i+Oqxf18z1XTMI5t9lGsY8xXjJGewE2xyK3Eo DkVgJnvcR265J0bN5VVKBvlMIExr07bwa7rs04Ze+d5lkPotVWDGEKAKlDericib+Dnv kaWqYBH3BXsirZ8lBRaKLOMAIZfYZ0v+DP1nXAkUM0nY/YipSXQp/VW+gU8m+hrOWF1q SLwA== X-Gm-Message-State: AIVw1133HGR8Ek3wAgVz9PR2aD9ujhZzYLV5ny9TMV7fUScrpIUYZ55Z aWnLq6rgnFrbn1qr X-Received: by 10.99.119.206 with SMTP id s197mr1093561pgc.439.1501824064707; Thu, 03 Aug 2017 22:21:04 -0700 (PDT) Original-Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id t17sm1004394pge.55.2017.08.03.22.21.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Aug 2017 22:21:04 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: <83pocfyurp.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217278 Archived-At: On Tue, 1 Aug 2017, Eli Zaretskii wrote: >> From: Tino Calancha >> Cc: emacs-devel@gnu.org, tino.calancha@gmail.com >> Date: Wed, 02 Aug 2017 02:02:32 +0900 >> >>> dired-tests.log: >>> Test dired-test-bug25609 condition: >>> (ert-test-failed >>> ((should >>> (file-exists-p target)) >>> :form >>> (file-exists-p "c:/DOCUME~1/Zaretzky/LOCALS~1/Temp/bar6828Ler/foo6828WPJ") >>> :value nil)) >> Could you check the following? > > I could, but I don't understand the purpose. This form is almost > identical to what's in dired-tests.el, and I already established that > the failure is indeed because 'target' doesn't exist at that moment. > I just didn't dig deep enough to understand why, because I didn't > really understand what the code wants to do, e.g. why it calls > dired-do-copy twice, and more importantly why 'target' is supposed to > exist after all that. > > What I see here is that at the point where file-exists-p is called, > there are two directories: /bla/blah/foNNNNNN and /bla/bla/barKKKKKK, > but not /bla/bla/fooNNNNN/barKKKKKK, as I think the code expects. > > maybe if you could explain the idea behind the code I could think of a > reason why it doesn't work here. I added more comments and sanity checks in commit db5d38ddb0de83d8f920b7a128fe3fd5156fdf85 (Fix 2 tests that fail in MS-Windows) Does it work now in Windows?