From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master e82c4f5: Don't assume /bin/sh as the 'sh' location in the local host Date: Wed, 2 Aug 2017 22:46:06 +0900 (JST) Message-ID: References: <20170802075459.16207.16636@vcs0.savannah.gnu.org> <20170802075500.60BEA20E71@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1501681623 942 195.159.176.226 (2 Aug 2017 13:47:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 Aug 2017 13:47:03 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: Tino Calancha , Michael Albinus , Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 02 15:46:55 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dctzA-00089A-KS for ged-emacs-devel@m.gmane.org; Wed, 02 Aug 2017 15:46:52 +0200 Original-Received: from localhost ([::1]:47917 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dctzG-0006ds-JF for ged-emacs-devel@m.gmane.org; Wed, 02 Aug 2017 09:46:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dctyY-0006ca-QI for emacs-devel@gnu.org; Wed, 02 Aug 2017 09:46:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dctyV-0002nB-Mr for emacs-devel@gnu.org; Wed, 02 Aug 2017 09:46:14 -0400 Original-Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:33145) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dctyV-0002mV-H5 for emacs-devel@gnu.org; Wed, 02 Aug 2017 09:46:11 -0400 Original-Received: by mail-pg0-x243.google.com with SMTP id u185so6556626pgb.0 for ; Wed, 02 Aug 2017 06:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=S6PbwKOR9Xo02Lx2SzYbUM8sKi7GBV03awROgtzIQwM=; b=nZUILqIMgpUnUwrGsEeL09RPYt0mCNWDqorZZ1V6EFbppALuY355C2+DhKwNeZuan6 ZgyHn1YIrhUmrhKqhNxY6GS2rgi4gAYI8mcsc4kJjxVaxv6c7+3uR/nXGh8z+gE3nXW/ NMQmmDl+l29QE8qViXdaekGy77xD2uXAkbLWZlk/cy2EbuNb6B7w0Z5mhLsGSwkNhcqv L5K83qcm7pWX4utTkQM/Hvsl2l3DVJ6WeWl4Zv+TU/8OLFwsELOYYj0OqbfqQ800BnnC 7z5trpNNaIVxkHlV9iMiED8yopLvSfSL1JTUTRTrsX/eoG5G3426Qc/ZhrOvIpdGi553 HD7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=S6PbwKOR9Xo02Lx2SzYbUM8sKi7GBV03awROgtzIQwM=; b=se0UalcZIP/ZRag1u4/aSsUnAmPOWKVmnRN2EVnidv+5eNnpc8frXxawOy8L+c4eHu YtQxRKM3N5GjhkK/lPcS/nS6WbNZSdVzurkUk9dwc6flZTcydcXq2JCBsgv/G7x57YVh lmzSRbvtX3rkgb+AVEvi6WxDgQPDclNvRvcwAIXD8Q7wl/MqMBjkvDR/ICkLsncGvsFZ Q6fdnnFEUgv3jqi06CDk4CH4oZPFHZC9BCd/tJeqKh3eupuTmQGuFvjtdjmKOmphe1nx ADNny9kVv/YAHrr7t8P848o9hcmGHNaiUoVghHCiTMNQ9WLylEIHoYkRCwjaPxInaRHR prIA== X-Gm-Message-State: AIVw113jedJ5DjTak2hn2BW0fgy2Xsh2VMr8PYI7efzekbX2Sa7YAjHj UIsXRqLylF7Qfg== X-Received: by 10.84.231.206 with SMTP id g14mr25019164pln.259.1501681570537; Wed, 02 Aug 2017 06:46:10 -0700 (PDT) Original-Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id p126sm53042164pfp.28.2017.08.02.06.46.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Aug 2017 06:46:09 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217239 Archived-At: On Wed, 2 Aug 2017, Stefan Monnier wrote: >> Don't assume /bin/sh as the 'sh' location in the local host > [...] >> + (and (bound-and-true-p explicit-shell-file-name) >> + (executable-find explicit-shell-file-name)) > > Hmm... why did you choose explicit-shell-file-name over shell-file-name? It was mentioned by Michael as a possibility. I chose it because is a defcustom: it might reflect an user preference compared with shell-file-name which is given. For example, my shell-file-name is bash. I might customize explicit-shell-file-name to '/bin/zsh', then i can use '**/' zsh syntaxis in the wildcard expansion: (let ((buf (dired-noselect (expand-file-name "**/*.el" source-directory)))) (with-current-buffer buf (dired-toggle-marks) (length (dired-get-marked-files)))) => 1731 ;; => 277 ; If i would use shell-file-name We might changed it if you don't like it.