Re: [Emacs-diffs] master e82c4f5: Don't assume /bin/sh as the 'sh' location in the local host

Re: [Emacs-diffs] master e82c4f5: Don't assume /bin/sh as the 'sh' location in the local host

[Stefan Monnier]

>     Don't assume /bin/sh as the 'sh' location in the local host
[...]
> +                            (and (bound-and-true-p explicit-shell-file-name)
> +                                 (executable-find explicit-shell-file-name))

Hmm... why did you choose explicit-shell-file-name over shell-file-name?


        Stefan

Re: [Emacs-diffs] master e82c4f5: Don't assume /bin/sh as the 'sh' location in the local host

[Tino Calancha]

On Wed, 2 Aug 2017, Stefan Monnier wrote:

>>     Don't assume /bin/sh as the 'sh' location in the local host
> [...]
>> +                            (and (bound-and-true-p explicit-shell-file-name)
>> +                                 (executable-find explicit-shell-file-name))
>
> Hmm... why did you choose explicit-shell-file-name over shell-file-name?
It was mentioned by Michael as a possibility.  I chose it because is a
defcustom: it might reflect an user preference compared with 
shell-file-name which is given.

For example, my shell-file-name is bash.  I might customize
explicit-shell-file-name to '/bin/zsh', then i can
use '**/' zsh syntaxis in the wildcard expansion:
(let ((buf
        (dired-noselect (expand-file-name "**/*.el" source-directory))))
   (with-current-buffer buf
     (dired-toggle-marks)
     (length (dired-get-marked-files))))
=> 1731
;; => 277 ; If i would use shell-file-name

We might changed it if you don't like it.

Re: [Emacs-diffs] master e82c4f5: Don't assume /bin/sh as the 'sh' location in the local host

[Stefan Monnier]

> It was mentioned by Michael as a possibility.  I chose it because is a
> defcustom: it might reflect an user preference compared with shell-file-name
> which is given.

explicit-shell-file-name is normally used when the user asks for a shell
(e.g. M-x shell), whereas shell-file-name is used whenever we want to
run a shell command (e.g. `shell-command`).

The docstring of `shell` says:

    Program used comes from variable `explicit-shell-file-name',
     or (if that is nil) from the ESHELL environment variable,
     or (if that is nil) from `shell-file-name'.

> For example, my shell-file-name is bash.  I might customize
> explicit-shell-file-name to '/bin/zsh', then i can
> use '**/' zsh syntaxis in the wildcard expansion:
> (let ((buf
>        (dired-noselect (expand-file-name "**/*.el" source-directory))))
>   (with-current-buffer buf
>     (dired-toggle-marks)
>     (length (dired-get-marked-files))))
> => 1731
> ;; => 277 ; If i would use shell-file-name

But setting explicit-shell-file-name to `/bin/zsh` doesn't let you use
`**/` in M-! whereas if you had set shell-file-name to `/bin/zsh` you'd
get that extra functionality everywhere.


        Stefan

Re: [Emacs-diffs] master e82c4f5: Don't assume /bin/sh as the 'sh' location in the local host

[Tino Calancha]

On Wed, 2 Aug 2017, Stefan Monnier wrote:

>> For example, my shell-file-name is bash.  I might customize
>> explicit-shell-file-name to '/bin/zsh', then i can
>> use '**/' zsh syntaxis in the wildcard expansion:
>> (let ((buf
>>        (dired-noselect (expand-file-name "**/*.el" source-directory))))
>>   (with-current-buffer buf
>>     (dired-toggle-marks)
>>     (length (dired-get-marked-files))))
>> => 1731
>> ;; => 277 ; If i would use shell-file-name
>
> But setting explicit-shell-file-name to `/bin/zsh` doesn't let you use
> `**/` in M-! whereas if you had set shell-file-name to `/bin/zsh` you'd
> get that extra functionality everywhere.
I'd also lost the extra bash functionality everywhere :-)