Re: dired-tests.el fails on MS-Windows

[Tino Calancha <tino.calancha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1773 bytes --]



On Tue, 1 Aug 2017, Fabrice Popineau wrote:

> I don't get a failure on dired-test-bug25609 with windows 10 and running from a mingw64 bash.
> I get a failure on  dired-test-bug27631 because "/bin/sh" is hardcoded in lisp/dired.el and the
> place for sh.exe in msys2 is in /usr/bin .
Thank you for the comments and suggestions!

I should used 'executable-find' for a local connection.  For a
tramp connection i don't know how to get the 'sh' location in the
remote host: i just kept '/bin/sh' for them.
Michael?

--8<-----------------------------cut here---------------start------------->8---

commit 76f1ea53c7469f7d4c5b9007633642124ae88c62
Author: Tino Calancha <tino.calancha@gmail.com>
Date:   Wed Aug 2 12:27:42 2017 +0900

     Don't assume /bin/sh as the 'sh' location in the local host

     * lisp/dired.el (dired-insert-directory): Use executable-find in
     a local host.

diff --git a/lisp/dired.el b/lisp/dired.el
index 4f8f615a34..a0e1fe185d 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -1281,7 +1281,8 @@ dired-insert-directory
                 (unless
                     (zerop
                      (process-file
-                     "/bin/sh" nil (current-buffer) nil "-c" script))
+                     (or (and (file-remote-p default-directory) "/bin/sh") (executable-find "sh"))
+                     nil (current-buffer) nil "-c" script))
                   (user-error
                    "%s: No files matching wildcard" (cdr dir-wildcard)))
                 (insert-directory-clean (point) switches)))

--8<-----------------------------cut here---------------end--------------->8---
In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
  of 2017-08-02
Repository revision: 0fd6de9cb444d6cc553ea67815ccfb7a923012a2